On Fri, 30 Oct 2020 15:28:16 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Patrick Concannon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8255584: fixed ordering of realm and username in name
>
> test/jdk/com/sun/net/httpserver/HttpPrincipalTest.java line 44:
>
>> 42: assertEquals(principal.getUsername(), "test");
>> 43: assertEquals(principal.getRealm(), "123");
>> 44: assertEquals(principal.getName(), "test:123");
>
> should be "123:test" here.
Fixed in commit 2ad0c8d8a0d21713b6b3cdbd59306fd4d57bf4d7
> src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpPrincipal.java
> line 78:
>
>> 76: */
>> 77: public String getName() {
>> 78: return String.format("%s:%s", username, realm);
>
> Isn't it the opposite you should do Patrick :-) ?
> :username```
Fixed in commit 2ad0c8d8a0d21713b6b3cdbd59306fd4d57bf4d7
-------------
PR: https://git.openjdk.java.net/jdk/pull/958
