Re: RFR: 8246431: java/net/httpclient/PathSubscriber tests fail due to missing FilePermission

Hi, Chris and I reviewed the build configuration that leads to the changing location of the library classes. The @library tag, which builds classes implicitly in the test class directory, has been supplemented with explicit @build tags for the required library classes. This way, these classes

Re: RFR: 8246431: java/net/httpclient/PathSubscriber tests fail due to missing FilePermission

> On 8 Jun 2020, at 11:23, Julia Boes wrote: > > .. > > Updated webrev: http://cr.openjdk.java.net/~jboes/webrevs/8246431/webrev.01/ LGTM. -Chris.

Re: RFR[8243999]: ’DatagramSocket and MulticastSocket constructors don't specify how a null InetAddress is handled'

Hi Daniel, Thanks for your feedback. I’ve made the change, and included the new webrev below. http://cr.openjdk.java.net/~pconcannon/8243999/webrevs/webrev.01/ Kind regards, Patrick > On 5 Jun 2020, at 13:00, Daniel Fuchs w

Re: RFR[8243999]: ’DatagramSocket and MulticastSocket constructors don't specify how a null InetAddress is handled'

Hi Patrick, Your last patch looks good to me. I have added myself as a reviewer to the CSR as well. https://bugs.openjdk.java.net/browse/JDK-8246663 best regards, -- daniel On 08/06/2020 12:53, Patrick Concannon wrote: Hi Daniel, Thanks for your feedback. I’ve made the change, and included

Re: RFR: 8246431: java/net/httpclient/PathSubscriber tests fail due to missing FilePermission

Hi Julia, Looks good to me too! best regards, -- daniel On 08/06/2020 11:23, Julia Boes wrote: Hi, Chris and I reviewed the build configuration that leads to the changing location of the library classes. The @library tag, which builds classes implicitly in the test class directory, has bee

RFR[8245828]: 'Remove unnecessary NetworkPermission checks from jdk/net/ExtendedSocketOptions.java’

Hi, Could someone please review my fix for JDK-8245828 - ‘Remove unnecessary NetworkPermission checks from jdk/net/ExtendedSocketOptions.java’ ? With the removal of socket option SO_FLOW_SLA the NetworkPermission checks in jdk/net/ExtendedSocketOptions are no longer required. This fix removes t

Re: RFR[8245828]: 'Remove unnecessary NetworkPermission checks from jdk/net/ExtendedSocketOptions.java’

On 08/06/2020 19:53, Patrick Concannon wrote: Hi, Could someone please review my fix for JDK-8245828 - ‘Remove unnecessary NetworkPermission checks from jdk/net/ExtendedSocketOptions.java’ ? With the removal of socket option SO_FLOW_SLA the NetworkPermission checks in jdk/net/ExtendedSoc