Hi Daniel, Thanks for your feedback.
I’ve made the change, and included the new webrev below. http://cr.openjdk.java.net/~pconcannon/8243999/webrevs/webrev.01/ <http://cr.openjdk.java.net/~pconcannon/8243999/webrevs/webrev.01/> Kind regards, Patrick > On 5 Jun 2020, at 13:00, Daniel Fuchs <daniel.fu...@oracle.com> wrote: > > Hi Patrick, > > MulticastSocket.java: > > 195 * @throws IllegalArgumentException if port is <a > href="#PortRange"> > 196 * out of range.</a> > > I believe this should be: > > 195 * @throws IllegalArgumentException if port is <a > href="DatagramSocket.html#PortRange"> > 196 * out of range.</a> > > Could you please make the change and regenerate the doc and double > check that the link in the generated doc is working? > > best regards, > > -- daniel > > On 05/06/2020 12:29, Patrick Concannon wrote: >> Hi, >> Could someone please review my patch and CSR for JDK-8243999 - >> ’DatagramSocket and MulticastSocket constructors don't specify how a null >> InetAddress is handled’? >> Currently, several constructors from DatagramSocket and MulticastSocket >> don't specify that the socket will be bound to the wildcard address if a >> null InetAddress is supplied, or that an unbound socket will be created if a >> null value is passed as a SocketAddress parameter. This fix provides >> clarification on this behaviour. >> issue: https://bugs.openjdk.java.net/browse/JDK-8243999 >> CSR: https://bugs.openjdk.java.net/browse/JDK-8246663 >> webrev: http://cr.openjdk.java.net/~pconcannon/8245984/webrevs/webrev.00 >> Kind regards, >> Patrick >
