On 08/06/2020 19:53, Patrick Concannon wrote:
Hi,
Could someone please review my fix for JDK-8245828 - ‘Remove
unnecessary NetworkPermission checks from
jdk/net/ExtendedSocketOptions.java’ ?
With the removal of socket option SO_FLOW_SLA the NetworkPermission
checks in jdk/net/ExtendedSocketOptions are no longer required. This
fix removes these checks.
issue: https://bugs.openjdk.java.net/browse/JDK-8245828
webrev: http://cr.openjdk.java.net/~pconcannon/8245828/webrevs/webrev.00/
The remove of the permission check looks good but I'm curious why the
security policy needs accessDeclaredMembers - is it because of the
getServerSocketTrafficClass method in the test? Just wondering if you've
tried changing that to getMethod (rather than getDeclaredMethod) as its
a public method.
-Alan
