Re: [ipv6]: 8224014: Don't run test/jdk/java/net/NetworkInterface/IPv4Only.java in IPv6 only environment

Hi Arthur, On 16/05/2019 18:01, Arthur Eubanks wrote: Good idea, done. PTAL. Tested with and without IPv4 support. http://cr.openjdk.java.net/~aeubanks/8224014/webrev.01/index.html Shouldn't you remove: 38 IPSupport.throwSkippedExceptionIfNonOperational(); In this case? best regar

Re: [ipv6]: 8224081: SOCKS v4 doesn't work with IPv6

Hi Arthur, On 17/05/2019 00:16, Arthur Eubanks wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8224081 webrev: http://cr.openjdk.java.net/~aeubanks/8224081/webrev.00/index.html Tests that try to use SOCKS v4 will fail in an IPv6 only environment since SOCKS v4 does not support IPv6. SOCKS

Re: [ipv6]: 8224081: SOCKS v4 doesn't work with IPv6

+1 On Fri, May 17, 2019 at 3:29 PM Daniel Fuchs wrote: > Hi Arthur, > > On 17/05/2019 00:16, Arthur Eubanks wrote: > > bug: https://bugs.openjdk.java.net/browse/JDK-8224081 > > webrev: > http://cr.openjdk.java.net/~aeubanks/8224081/webrev.00/index.html > > > > Tests that try to use SOCKS v4 will

Re: [ipv6] RFR: 8223214: Inet6AddressImpl.loopbackAddress() should choose loopback address that is available

Hi Arthur, On 17/05/2019 00:18, Arthur Eubanks wrote: I've tried to run this through the submit repo twice, haven't gotten a result from either run. Could somebody check what's happened to those runs? The branch names are "JDK-8223214" and "JDK-8223214-1". I'm not seeing anything for JDK-8223

Re: [ipv6]: 8224081: SOCKS v4 doesn't work with IPv6

Arthur, On 17/05/2019 06:57, Arthur Eubanks wrote: On Thu, May 16, 2019 at 7:44 PM Vyom Tiwari > wrote: Hi Arthur, do we need "Integer.toString(4)" to convert int to string in SocksProxyVersion ? Thanks, Vyom Fixed. http://cr.openjdk.java.net/~

Re: RFR: JDK-8224028: loop initial declarations introduced by JDK-8184770 (jdwp)

Hi, Aleksey has helped to push: http://hg.openjdk.java.net/jdk/jdk/rev/3205f4c40716. Thank you all! Cheers, Ao Qi On Fri, May 17, 2019 at 8:19 AM David Holmes wrote: > > On 17/05/2019 9:14 am, Martin Buchholz wrote: > > On Thu, May 16, 2019 at 4:05 PM David Holmes >

Re: [ipv6]: 8224081: SOCKS v4 doesn't work with IPv6

Arthur, > On 17 May 2019, at 17:50, Arthur Eubanks wrote: > > Looks good. > > Trivially, maybe amend the comment to be more explicit > >86 // SOCKS V4 ( requires IPv4 ) > > -Chris. > Done > http://cr.openjdk.java.net/~aeubanks/8224081/webrev.02/ >

Re: [ipv6]: 8224019: test/jdk/java/nio/channels/DatagramChannel/BasicMulticastTests.java assumes IPv4 is always available

On 17/05/2019 18:22, Arthur Eubanks wrote: Done, order is protocol family, group/notGroup InetAddress, NetworkInterface, source InetAddress http://cr.openjdk.java.net/~aeubanks/8224019/webrev.02/ Thanks, this version looks okay to me. -Alan

Re: [ipv6]: 8224014: Don't run test/jdk/java/net/NetworkInterface/IPv4Only.java in IPv6 only environment

On 17/05/19 18:02, Arthur Eubanks wrote: Oh yes, http://cr.openjdk.java.net/~aeubanks/8224014/webrev.02/ Made sure that the "caught expected exception" lines were printed out under IPv6-only environment. Yes, looks good! best regards, -- daniel

Re: RFR: 8223553: Fix code constructs that do not compile with the Eclipse Java Compiler

Hi Christoph, I'm still not entirely sure why this is so, but the introduction of a local variable in MethodHandles.java seems to make things work for Eclipse. Addition of a local variable seems to be minimally invasive, so it makes sense to see if this technique can be applied to other cases.