RFR(XS): 8217311: Improve Exception thrown when MulticastSocket.setInterface fails on AIX(Unix)

Hi, please help to review a tiny fix. While working on the issue with the AIX multicast tests (https://bugs.openjdk.java.net/browse/JDK-8207404), I found a place where a SocketException thrown in a specific error case could be improved. There already exists code to throw a SocketException with

Re: RFR(XS): 8217311: Improve Exception thrown when MulticastSocket.setInterface fails on AIX(Unix)

Hi Chris, Looks OK to me. That is one of the changes I had made locally while investigating https://bugs.openjdk.java.net/browse/JDK-8207404, so happy to accept it. Thanks Steve Groeger IBM Runtime Technologies Hursley, Winchester Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 Fax

Re: RFR(XS): 8217311: Improve Exception thrown when MulticastSocket.setInterface fails on AIX(Unix)

Looks okay to me too.  I think we should encourage new multicast applications to move to DatagramChannel as it a defines factory methods to specify the protocol family at creation time. Also setOption(IP_MULTICAST_IF, ...) and the join methods are also specified for such cases. Going forward I

RFR: 8207404: MulticastSocket tests failing on AIX

Hi, here is a fix for the MulticastSocket tests failing on AIX (in certain sceanrios): Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8207404.0/ Bug: https://bugs.openjdk.java.net/browse/JDK-8207404 First of all, I "modernized" the testcases test/jdk/java/net/MulticastSocket/SetGetNetwork

RE: RFR(XS): 8217311: Improve Exception thrown when MulticastSocket.setInterface fails on AIX(Unix)

Thanks Alan and Steve for the reviews. From: net-dev On Behalf Of Alan Bateman Sent: Donnerstag, 17. Januar 2019 11:45 To: net-dev@openjdk.java.net Subject: Re: RFR(XS): 8217311: Improve Exception thrown when MulticastSocket.setInterface fails on AIX(Unix) Looks okay to me too. I think we shou

RE: RFR(XS): 8217311: Improve Exception thrown when MulticastSocket.setInterface fails on AIX(Unix)

Hi Christoph, I do not even see EADDRNOTAVAIL listed in the list of error codes of setsockopt on AIX 7.1 (manpage). Strange that it shows up (maybe the manpage is incomplete ?). But otherwise it looks good to me (not a Reviewer). Maybe one could mention the error (or errno)in the

Re: RFR(XS): 8217311: Improve Exception thrown when MulticastSocket.setInterface fails on AIX(Unix)

> On 17 Jan 2019, at 09:54, Langer, Christoph wrote: > > Hi, > > please help to review a tiny fix. > > While working on the issue with the AIX multicast tests > (https://bugs.openjdk.java.net/browse/JDK-8207404 > ), I found a place where a

Re: RFR: 8207404: MulticastSocket tests failing on AIX

> On 17 Jan 2019, at 10:55, Langer, Christoph wrote: > > Hi, > > here is a fix for the MulticastSocket tests failing on AIX (in certain > sceanrios): > > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8207404.0/ > Why remove th

RE: RFR: 8207404: MulticastSocket tests failing on AIX

Hi Chris, for me it was the other way round... I did not see immediately where the methods came from and had to do some navigation. But I'm happy to revert this. As I had only worked with AIX so far, I'll put the test update into our test system to see whether there'll be issues on other platfo

Re: RFR: 8217237 HttpClient does not deal well with multi-valued WWW-Authenticate challenge headers

Thanks Daniel. Good catch. - Michael. On 16/01/2019, 17:51, Daniel Fuchs wrote: Hi Michael, I believe the code changes looks good. WRT to the test: 150 if (response.statusCode() != 200 && !response.body().equals(server.response())) { I believe you meant || not && best regards,

RE: RFR: 8207404: MulticastSocket tests failing on AIX

Hi Christoph, Have reviewed you changes and they look OK. I have no preference with regards the static imports, but my view is keep the changes as simple as possible and to not make changes just for the sake of it. Have tested your patches on a couple of AIX systems, both with IPv6 enabled b

RE: RFR: 8207404: MulticastSocket tests failing on AIX

Hi Steve, thanks for the review and the additional testing. I’ll post an update tomorrow after I have results from our test system which will test all platforms that we have an eye on. I’ll roll back the change to the import statement and will also add an update to the problem list in order to