> On 17 Jan 2019, at 09:54, Langer, Christoph <christoph.lan...@sap.com> wrote:
> 
> Hi,
>  
> please help to review a tiny fix.
>  
> While working on the issue with the AIX multicast tests 
> (https://bugs.openjdk.java.net/browse/JDK-8207404 
> <https://bugs.openjdk.java.net/browse/JDK-8207404>), I found a place where a 
> SocketException thrown in a specific error case could be improved. There 
> already exists code to throw a SocketException with the text 
> "IPV6_MULTICAST_IF failed (interface has IPv4 address only?) " when 
> setsockopt(IPV6_MULTICAST_IF) fails with EINVAL. On AIX, when you have IPv4 
> addresses only on an interface, you’ll run into when setting the option on an 
> AF_INET6 socket. So that specific SocketException text would match very well 
> then. I guess the addition is fine to be platform independent. At best on 
> other platforms EADDRNOTAVAIL is never seen at that place. Or if it was, it 
> would certainly have to do with an IP address problem on the interface...
>  
> Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8217311.0/ 
> <http://cr.openjdk.java.net/~clanger/webrevs/8217311.0/>
Looks ok.

-Chris.

Reply via email to