Hi Steve, thanks for the review and the additional testing.
I’ll post an update tomorrow after I have results from our test system which will test all platforms that we have an eye on. I’ll roll back the change to the import statement and will also add an update to the problem list in order to make the tests run by default on AIX. You could do me a favor though. There’s not only the issue with the IPV6_MULTICAST_IF setsockopt operation but there’s also the other where node local IPv6 multicast does not work when only the loopback interface is configured for IPv6 (as show in Test.java). Could you check this also with the AIX team whether they consider this a bug or working as expected? Thanks & Best regards Christoph From: Steve Groeger <groe...@uk.ibm.com> Sent: Donnerstag, 17. Januar 2019 14:32 To: Langer, Christoph <christoph.lan...@sap.com> Cc: Chris Hegarty <chris.hega...@oracle.com>; net-dev@openjdk.java.net; net-dev <net-dev-boun...@openjdk.java.net>; ppc-aix-port-...@openjdk.java.net Subject: RE: RFR: 8207404: MulticastSocket tests failing on AIX Hi Christoph, Have reviewed you changes and they look OK. I have no preference with regards the static imports, but my view is keep the changes as simple as possible and to not make changes just for the sake of it. Have tested your patches on a couple of AIX systems, both with IPv6 enabled but one didn't have an IPv6 address configured and the other did. All the jdk/java/net/MulticastSocket tests passed. So the change also looks functionally OK. Thanks Steve Groeger IBM Runtime Technologies Hursley, Winchester Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 Fax (44) 1962 816800 Lotus Notes: Steve Groeger/UK/IBM Internet: groe...@uk.ibm.com<mailto:groe...@uk.ibm.com> Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From: "Langer, Christoph" <christoph.lan...@sap.com<mailto:christoph.lan...@sap.com>> To: Chris Hegarty <chris.hega...@oracle.com<mailto:chris.hega...@oracle.com>> Cc: "ppc-aix-port-...@openjdk.java.net<mailto:ppc-aix-port-...@openjdk.java.net>" <ppc-aix-port-...@openjdk.java.net<mailto:ppc-aix-port-...@openjdk.java.net>>, "net-dev@openjdk.java.net<mailto:net-dev@openjdk.java.net>" <net-dev@openjdk.java.net<mailto:net-dev@openjdk.java.net>> Date: 17/01/2019 11:34 Subject: RE: RFR: 8207404: MulticastSocket tests failing on AIX Sent by: "net-dev" <net-dev-boun...@openjdk.java.net<mailto:net-dev-boun...@openjdk.java.net>> ________________________________ Hi Chris, for me it was the other way round… I did not see immediately where the methods came from and had to do some navigation. But I’m happy to revert this. As I had only worked with AIX so far, I’ll put the test update into our test system to see whether there’ll be issues on other platforms. I’ll send an updated webrev tomorrow. Best regards Christoph From: Chris Hegarty <chris.hega...@oracle.com<mailto:chris.hega...@oracle.com>> Sent: Donnerstag, 17. Januar 2019 12:27 To: Langer, Christoph <christoph.lan...@sap.com<mailto:christoph.lan...@sap.com>> Cc: net-dev@openjdk.java.net<mailto:net-dev@openjdk.java.net>; ppc-aix-port-...@openjdk.java.net<mailto:ppc-aix-port-...@openjdk.java.net> Subject: Re: RFR: 8207404: MulticastSocket tests failing on AIX On 17 Jan 2019, at 10:55, Langer, Christoph <christoph.lan...@sap.com<mailto:christoph.lan...@sap.com>> wrote: Hi, here is a fix for the MulticastSocket tests failing on AIX (in certain sceanrios): Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8207404.0/ Why remove the static imports from NetworkConfiguration? It makes the code more verbose ( and IMO harder to read ). -Chris. Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
