Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v7]

2021-06-09 Thread Lance Andersen
On Wed, 9 Jun 2021 08:44:44 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.net` >> and `java.nio` packages to make use of the switch expressions? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull reques

Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v7]

2021-06-09 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.net` > and `java.nio` packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental w

Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v6]

2021-06-03 Thread Alan Bateman
On Thu, 3 Jun 2021 10:12:03 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.net` >> and `java.nio` packages to make use of the switch expressions? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull reques

Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v5]

2021-06-03 Thread Patrick Concannon
On Thu, 3 Jun 2021 05:51:59 GMT, Alan Bateman wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> comm

Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v6]

2021-06-03 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.net` > and `java.nio` packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental w

Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v5]

2021-06-02 Thread Alan Bateman
On Wed, 2 Jun 2021 15:23:01 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.net` >> and `java.nio` packages to make use of the switch expressions? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull reques

Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v5]

2021-06-02 Thread Iris Clark
On Wed, 2 Jun 2021 15:23:01 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.net` >> and `java.nio` packages to make use of the switch expressions? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull reques

Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v5]

2021-06-02 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.net` > and `java.nio` packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental w

Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v4]

2021-06-02 Thread Chris Hegarty
On Wed, 2 Jun 2021 11:06:46 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.net` >> and `java.nio` packages to make use of the switch expressions? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull reques

Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v4]

2021-06-02 Thread Daniel Fuchs
On Wed, 2 Jun 2021 11:06:46 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.net` >> and `java.nio` packages to make use of the switch expressions? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull reques

Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v4]

2021-06-02 Thread Michael McMahon
On Wed, 2 Jun 2021 11:06:46 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.net` >> and `java.nio` packages to make use of the switch expressions? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull reques

Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v2]

2021-06-02 Thread Patrick Concannon
On Wed, 2 Jun 2021 09:13:44 GMT, Chris Hegarty wrote: >> Patrick Concannon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8268056: Reverted changes to URLDecoder; reformatted change to FileTime > > src/java.base/share/classes/java/nio/f

Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v4]

2021-06-02 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.net` > and `java.nio` packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v2]

2021-06-02 Thread Chris Hegarty
On Tue, 1 Jun 2021 17:20:38 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.net` >> and `java.nio` packages to make use of the switch expressions? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull reques

Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v3]

2021-06-02 Thread Patrick Concannon
On Tue, 1 Jun 2021 16:58:12 GMT, Daniel Fuchs wrote: >> Patrick Concannon has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> com

Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v3]

2021-06-02 Thread Patrick Concannon
On Tue, 1 Jun 2021 17:46:10 GMT, Alan Bateman wrote: >> Sorry about that. I've changed it now. See 2f179b5 > > This still looks a bit messy because you've got 3 different styles in the one > switch statement. It's okay to drop FileTime from the patch if you want as > it's not worth spending tim

Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v3]

2021-06-02 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.net` > and `java.nio` packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental w

Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v2]

2021-06-01 Thread Alan Bateman
On Tue, 1 Jun 2021 17:16:59 GMT, Patrick Concannon wrote: >> src/java.base/share/classes/java/nio/file/attribute/FileTime.java line 256: >> >>> 254: nanos = (int) Math.floorMod(value, >>> NANOS_PER_SECOND); >>> 255: } >>> 256: default -> thro

Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v2]

2021-06-01 Thread Daniel Fuchs
On Tue, 1 Jun 2021 17:20:38 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.net` >> and `java.nio` packages to make use of the switch expressions? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull reques

Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v2]

2021-06-01 Thread Patrick Concannon
On Tue, 1 Jun 2021 16:56:39 GMT, Alan Bateman wrote: >> Patrick Concannon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8268056: Reverted changes to URLDecoder; reformatted change to FileTime > > src/java.base/share/classes/java/nio/fi

Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v2]

2021-06-01 Thread Patrick Concannon
On Tue, 1 Jun 2021 16:56:36 GMT, Daniel Fuchs wrote: >> Patrick Concannon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8268056: Reverted changes to URLDecoder; reformatted change to FileTime > > src/java.base/share/classes/java/net/UR

Re: RFR: 8268056: Update java.net and java.nio to use switch expressions [v2]

2021-06-01 Thread Patrick Concannon
> Hi, > > Could someone please review my code for updating the code in the `java.net` > and `java.nio` packages to make use of the switch expressions? > > Kind regards, > Patrick Patrick Concannon has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8268056: Update java.net and java.nio to use switch expressions

2021-06-01 Thread Alan Bateman
On Tue, 1 Jun 2021 16:44:38 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my code for updating the code in the `java.net` > and `java.nio` packages to make use of the switch expressions? > > Kind regards, > Patrick src/java.base/share/classes/java/nio/file/attribute/Fil

Re: RFR: 8268056: Update java.net and java.nio to use switch expressions

2021-06-01 Thread Daniel Fuchs
On Tue, 1 Jun 2021 16:44:38 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my code for updating the code in the `java.net` > and `java.nio` packages to make use of the switch expressions? > > Kind regards, > Patrick src/java.base/share/classes/java/net/URLDecoder.java li