On Tue, 1 Jun 2021 17:16:59 GMT, Patrick Concannon <pconcan...@openjdk.org> 
wrote:

>> src/java.base/share/classes/java/nio/file/attribute/FileTime.java line 256:
>> 
>>> 254:                     nanos = (int) Math.floorMod(value, 
>>> NANOS_PER_SECOND);
>>> 255:                 }
>>> 256:                 default -> throw new AssertionError("Unit not 
>>> handled");
>> 
>> The formatting here is all messed up, I think you'll need to fix this up 
>> before it can be reviewed.
>
> Sorry about that. I've changed it now. See 2f179b5

This still looks a bit messy because you've got 3 different styles in the one 
switch statement. It's okay to drop FileTime from the patch if you want as it's 
not worth spending time on.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4285

Reply via email to