On Wed, 2 Jun 2021 15:23:01 GMT, Patrick Concannon <pconcan...@openjdk.org>
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.net`
>> and `java.nio` packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request with a new target base due to
> a merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains six additional
> commits since the last revision:
>
> - Merge remote-tracking branch 'origin/master' into JDK-8268056
> - 8268056: Added yield to switch expression in Files
> - 8268056: reverted changes to FileTime
> - Merge remote-tracking branch 'origin/master' into JDK-8268056
> - 8268056: Reverted changes to URLDecoder; reformatted change to FileTime
> - 8268056: Update java.net and java.nio to use switch expressions
src/java.base/share/classes/java/nio/file/Files.java line 2817:
> 2815: }
> 2816: case START_DIRECTORY -> {
> 2817: var r = visitor.preVisitDirectory(ev.file(),
> ev.attributes());
Can you all uses of "r" with "res" to make it little bit clear that it's a
result, that will get it a bit more consistent with the exist code? Otherwise I
think this version is okay.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4285
