Re: DefaultProxySelector socks override

2013-04-04 Thread Kurchi Subhra Hazra
013 01:13 AM, Kurchi Hazra wrote: Hi Christos/Chris, Here is a webrev for this change: http://cr.openjdk.java.net/~khazra/5001942/webrev.00/ Thanks, - Kurchi On 3/27/2013 10:49 AM, chris...@zoulas.com wrote: On Mar 27, 5:30pm, chris.hega...@oracle.com (Chris Hegarty) wrote: -- Subject: Re:

Re: DefaultProxySelector socks override

2013-04-04 Thread Chris Hegarty
is change: http://cr.openjdk.java.net/~khazra/5001942/webrev.00/ Thanks, - Kurchi On 3/27/2013 10:49 AM, chris...@zoulas.com wrote: On Mar 27, 5:30pm, chris.hega...@oracle.com (Chris Hegarty) wrote: -- Subject: Re: DefaultProxySelector socks override | On 03/27/2013 05:22 PM, chris...@zoulas.com wrote: | >

Re: DefaultProxySelector socks override

2013-04-03 Thread Kurchi Subhra Hazra
: DefaultProxySelector socks override | Hi Christos, | | It is ok to push the test changes alongwith the code changes - we do not | want | to break our tests as a result of new changes.. | I am making an attempt at reading the actual IP address of the machine that | the test is running on, rather than the

Re: DefaultProxySelector socks override

2013-04-03 Thread Kurchi Subhra Hazra
zoulas.com wrote: On Mar 27, 5:30pm, chris.hega...@oracle.com (Chris Hegarty) wrote: -- Subject: Re: DefaultProxySelector socks override | On 03/27/2013 05:22 PM, chris...@zoulas.com wrote: | > | > Sure, I just requested a subscription to net-dev so I might not see the | > first few m

Re: DefaultProxySelector socks override

2013-04-03 Thread Christos Zoulas
On Apr 3, 9:15am, kurchi.subhra.ha...@oracle.com (Kurchi Subhra Hazra) wrote: -- Subject: Re: DefaultProxySelector socks override | Hi Christos, | | It is ok to push the test changes alongwith the code changes - we do not | want | to break our tests as a result of new changes.. | I am making

Re: DefaultProxySelector socks override

2013-04-03 Thread Chris Hegarty
: DefaultProxySelector socks override | On 03/27/2013 05:22 PM, chris...@zoulas.com wrote: | > | > Sure, I just requested a subscription to net-dev so I might not see the | > first few messages. To clarify: | > | > 1. I will add socks.proxyHost and socks.proxyPort for consistency | >

Re: DefaultProxySelector socks override

2013-04-03 Thread Kurchi Subhra Hazra
On 4/2/13 6:27 PM, chris...@zoulas.com wrote: On Apr 2, 5:26pm, kurchi.subhra.ha...@oracle.com (Kurchi Hazra) wrote: -- Subject: Re: DefaultProxySelector socks override | Also, I should have clarified why I am changing the test. Since now we | are defining the socks non-proxy property

Re: DefaultProxySelector socks override

2013-04-02 Thread Christos Zoulas
On Apr 2, 5:26pm, kurchi.subhra.ha...@oracle.com (Kurchi Hazra) wrote: -- Subject: Re: DefaultProxySelector socks override | Also, I should have clarified why I am changing the test. Since now we | are defining the socks non-proxy property - | localhost gets added to the list of non-proxy hosts

Re: DefaultProxySelector socks override

2013-04-02 Thread Christos Zoulas
On Apr 2, 5:13pm, kurchi.subhra.ha...@oracle.com (Kurchi Hazra) wrote: -- Subject: Re: DefaultProxySelector socks override | Hi Christos/Chris, | | Here is a webrev for this change: | http://cr.openjdk.java.net/~khazra/5001942/webrev.00/ LGTM, for DefaultProxySelector.java. The

Re: DefaultProxySelector socks override

2013-04-02 Thread Kurchi Hazra
rty) wrote: -- Subject: Re: DefaultProxySelector socks override | On 03/27/2013 05:22 PM, chris...@zoulas.com wrote: | > | > Sure, I just requested a subscription to net-dev so I might not see the | > first few messages. To clarify: | > | > 1. I will add socks.proxyHos

Re: DefaultProxySelector socks override

2013-04-02 Thread Kurchi Hazra
Hi Christos/Chris, Here is a webrev for this change: http://cr.openjdk.java.net/~khazra/5001942/webrev.00/ Thanks, - Kurchi On 3/27/2013 10:49 AM, chris...@zoulas.com wrote: On Mar 27, 5:30pm, chris.hega...@oracle.com (Chris Hegarty) wrote: -- Subject: Re: DefaultProxySelector socks

Re: DefaultProxySelector socks override

2013-03-27 Thread Christos Zoulas
On Mar 27, 5:30pm, chris.hega...@oracle.com (Chris Hegarty) wrote: -- Subject: Re: DefaultProxySelector socks override | On 03/27/2013 05:22 PM, chris...@zoulas.com wrote: | > | > Sure, I just requested a subscription to net-dev so I might not see the | > first few messages. T

Re: DefaultProxySelector socks override

2013-03-27 Thread Chris Hegarty
On 03/27/2013 05:22 PM, chris...@zoulas.com wrote: Sure, I just requested a subscription to net-dev so I might not see the first few messages. To clarify: 1. I will add socks.proxyHost and socks.proxyPort for consistency with the other protocols, leaving as is socksProxyH

Re: DefaultProxySelector socks override

2013-03-27 Thread Chris Hegarty
[cc'ing net-dev, we can then probably drop core-libs-dev and continue the discussion over on net-dev] Christos, SOCKS is really old and not as widely deployed as other proxies. That said, I don't have any specific problem with your proposal. SOCKS is really in maintenance mode in the JDK, but