On Apr 3, 9:15am, kurchi.subhra.ha...@oracle.com (Kurchi Subhra Hazra) wrote: -- Subject: Re: DefaultProxySelector socks override
| Hi Christos, | | It is ok to push the test changes alongwith the code changes - we do not | want | to break our tests as a result of new changes.. | I am making an attempt at reading the actual IP address of the machine that | the test is running on, rather than the string "localhost". It is a | workaround, | the other option is to remove the test - I do not see any other way of | automating | what the changed test is trying to check. I guess it is fine, but put a comment to clearly indicate why you are doing this. But this is just my suggestion, I clearly am not the one to make a decision :-) christos
