Re: RFR: 8276774: Cookie stored in CookieHandler not sent if user headers contain cookie [v5]

2021-11-19 Thread Michael McMahon
On Fri, 19 Nov 2021 10:12:15 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find enclosed a patch that solves an unexpected interaction between >> server-set cookies and user-set cookies in the `java.net.HttpClient`. >> >> In JDK 12 we fixed >> [JDK-8213189](https://bugs.openjdk.java.net/browse

Re: RFR: 8276774: Cookie stored in CookieHandler not sent if user headers contain cookie [v4]

2021-11-19 Thread Daniel Fuchs
On Fri, 19 Nov 2021 02:44:52 GMT, Jaikiran Pai wrote: >> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commits

Re: RFR: 8276774: Cookie stored in CookieHandler not sent if user headers contain cookie [v5]

2021-11-19 Thread Daniel Fuchs
> Hi, > > Please find enclosed a patch that solves an unexpected interaction between > server-set cookies and user-set cookies in the `java.net.HttpClient`. > > In JDK 12 we fixed > [JDK-8213189](https://bugs.openjdk.java.net/browse/JDK-8213189) to allow > user-supplied header to take preceden

Re: RFR: 8276774: Cookie stored in CookieHandler not sent if user headers contain cookie [v4]

2021-11-18 Thread Jaikiran Pai
On Thu, 18 Nov 2021 19:49:19 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find enclosed a patch that solves an unexpected interaction between >> server-set cookies and user-set cookies in the `java.net.HttpClient`. >> >> In JDK 12 we fixed >> [JDK-8213189](https://bugs.openjdk.java.net/browse

Re: RFR: 8276774: Cookie stored in CookieHandler not sent if user headers contain cookie [v3]

2021-11-18 Thread Daniel Fuchs
On Thu, 18 Nov 2021 12:04:01 GMT, Michael McMahon wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> More cleanup > > src/java.net.http/share/classes/jdk/internal/net/http/Http1Request.java line > 124: > >> 122:

Re: RFR: 8276774: Cookie stored in CookieHandler not sent if user headers contain cookie [v4]

2021-11-18 Thread Daniel Fuchs
> Hi, > > Please find enclosed a patch that solves an unexpected interaction between > server-set cookies and user-set cookies in the `java.net.HttpClient`. > > In JDK 12 we fixed > [JDK-8213189](https://bugs.openjdk.java.net/browse/JDK-8213189) to allow > user-supplied header to take preceden

Re: RFR: 8276774: Cookie stored in CookieHandler not sent if user headers contain cookie [v3]

2021-11-18 Thread Michael McMahon
On Wed, 17 Nov 2021 14:07:09 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find enclosed a patch that solves an unexpected interaction between >> server-set cookies and user-set cookies in the `java.net.HttpClient`. >> >> In JDK 12 we fixed >> [JDK-8213189](https://bugs.openjdk.java.net/browse

Re: RFR: 8276774: Cookie stored in CookieHandler not sent if user headers contain cookie [v2]

2021-11-17 Thread Daniel Fuchs
On Wed, 17 Nov 2021 07:58:28 GMT, viretp wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Minor cleanup > > src/java.net.http/share/classes/jdk/internal/net/http/Stream.java line 38: > >> 36: import java.util.Colle

Re: RFR: 8276774: Cookie stored in CookieHandler not sent if user headers contain cookie [v3]

2021-11-17 Thread Daniel Fuchs
> Hi, > > Please find enclosed a patch that solves an unexpected interaction between > server-set cookies and user-set cookies in the `java.net.HttpClient`. > > In JDK 12 we fixed > [JDK-8213189](https://bugs.openjdk.java.net/browse/JDK-8213189) to allow > user-supplied header to take preceden

Re: RFR: 8276774: Cookie stored in CookieHandler not sent if user headers contain cookie [v2]

2021-11-17 Thread viretp
On Tue, 16 Nov 2021 13:17:16 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find enclosed a patch that solves an unexpected interaction between >> server-set cookies and user-set cookies in the `java.net.HttpClient`. >> >> In JDK 12 we fixed >> [JDK-8213189](https://bugs.openjdk.java.net/browse

Re: RFR: 8276774: Cookie stored in CookieHandler not sent if user headers contain cookie [v2]

2021-11-16 Thread Daniel Fuchs
> Hi, > > Please find enclosed a patch that solves an unexpected interaction between > server-set cookies and user-set cookies in the `java.net.HttpClient`. > > In JDK 12 we fixed > [JDK-8213189](https://bugs.openjdk.java.net/browse/JDK-8213189) to allow > user-supplied header to take preceden

RFR: 8276774: Cookie stored in CookieHandler not sent if user headers contain cookie

2021-11-16 Thread Daniel Fuchs
Hi, Please find enclosed a patch that solves an unexpected interaction between server-set cookies and user-set cookies in the `java.net.HttpClient`. In JDK 12 we fixed [JDK-8213189](https://bugs.openjdk.java.net/browse/JDK-8213189) to allow user-supplied header to take precedence over (that is