On Fri, 19 Nov 2021 02:44:52 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commits since the last revision: >> >> - Merge branch 'master' into user-cookie-8276774 >> - Improved comment as requested during review >> - More cleanup >> - Minor cleanup >> - Updated tests >> - 8276774: Cookie stored in CookieHandler not sent if user headers contain >> cookie > > src/java.net.http/share/classes/jdk/internal/net/http/Stream.java line 659: > >> 657: >> 658: // Filter any headers from systemHeaders that are set in >> userHeaders >> 659: // except for "Cookies" - user cookies will be appended to >> system > > Hello Daniel, A minor comment issue - "Cookie" instead of "Cookies", perhaps? Changed to "Cookie:" > test/jdk/java/net/httpclient/UserCookieTest.java line 2: > >> 1: /* >> 2: * Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved. > > Should the year be 2021? Darn. I thought I'd already fixed that. Good catch! ------------- PR: https://git.openjdk.java.net/jdk/pull/6408
