> Hi, > > Please find enclosed a patch that solves an unexpected interaction between > server-set cookies and user-set cookies in the `java.net.HttpClient`. > > In JDK 12 we fixed > [JDK-8213189](https://bugs.openjdk.java.net/browse/JDK-8213189) to allow > user-supplied header to take precedence over (that is, replace) > system-headers. > At the time the fact that server cookies would be added to the > system-supplied headers by the `CookieHandler` (if present), and that a > user-supplied cookie would therefore replace them (instead of simply > appending to them) was overlooked. > > This fix proposes to restore the behavior of JDK 11 WRT to cookies - and > arrange for user-supplied cookies to be appended to server-supplied cookies.
Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision: - Merge branch 'master' into user-cookie-8276774 - Improved comment as requested during review - More cleanup - Minor cleanup - Updated tests - 8276774: Cookie stored in CookieHandler not sent if user headers contain cookie ------------- Changes: - all: https://git.openjdk.java.net/jdk/pull/6408/files - new: https://git.openjdk.java.net/jdk/pull/6408/files/ade3b9bc..6433c2b5 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=6408&range=03 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=6408&range=02-03 Stats: 4668 lines in 223 files changed: 3506 ins; 485 del; 677 mod Patch: https://git.openjdk.java.net/jdk/pull/6408.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6408/head:pull/6408 PR: https://git.openjdk.java.net/jdk/pull/6408
