d...@openjdk.java.net>
> Subject: Re: RFR: 8170920 SO_RCVBUF and SO_SNDBUF options problem for
> network channels on MacOS
>
> Hi Goetz,
>
> Christoph has already done the work to split these changes into smaller
> chunks, 8171075 and 8171077. He has reviews out, and they
ng its way into jdk9.
>
> Best regards,
> Goetz.
>
>> -Original Message-
>> From: Langer, Christoph
>> Sent: Dienstag, 13. Dezember 2016 10:54
>> To: Lindenmaier, Goetz
>> Subject: FW: RFR: 8170920 SO_RCVBUF and SO_SNDBUF options problem for
>
ber 2016 10:54
> To: Lindenmaier, Goetz
> Subject: FW: RFR: 8170920 SO_RCVBUF and SO_SNDBUF options problem for
> network channels on MacOS
>
>
>
> -Original Message-
> From: Michael McMahon [mailto:michael.x.mcma...@oracle.com]
> Sent: Freitag, 9. Dezember 2
OpenJDK Network Dev list
>
> Subject: Re: RFR: 8170920 SO_RCVBUF and SO_SNDBUF options problem for
> network channels on MacOS
>
> Those suggestions are reasonable Christoph. I think given the subtle
> nature of the bug
> (removing the #include not causing a compile error) I'm
170920 SO_RCVBUF and SO_SNDBUF options problem for
network channels on MacOS
On 09/12/16 10:33, Michael McMahon wrote:
Could I get the following change reviewed please?
http://cr.openjdk.java.net/~michaelm/8170920/webrev.1/
Looks good.
You may just want to remove the "from" year from the co
Bernd,
I'll add a test for SO_SNDBUF. These parameters are too system dependent
to use hard coded values in the tests though. I'm not sure you could depend
on the initial/default value never being the same as the maximum value
either.
Thanks,
Michael
On 09/12/2016, 11:31, Bernd Eckenfels wrot
Should the test maybe assert that a change was made (or maybe be a bit more
whitebox and assert the result is >64k? Should it test SND+RCV?
Gruss
Bernd
--
http://bernd.eckenfels.net
On Fri, Dec 9, 2016 at 12:04 PM +0100, "Michael McMahon"
wrote:
Could I get the following change r
hanks
Christoph
> -Original Message-
> From: net-dev [mailto:net-dev-boun...@openjdk.java.net] On Behalf Of Chris
> Hegarty
> Sent: Freitag, 9. Dezember 2016 11:52
> To: Michael McMahon ; OpenJDK Network
> Dev list
> Subject: Re: RFR: 8170920 SO_RCVBUF and SO_SNDBUF optio
On 09/12/16 10:33, Michael McMahon wrote:
Could I get the following change reviewed please?
http://cr.openjdk.java.net/~michaelm/8170920/webrev.1/
Looks good.
You may just want to remove the "from" year from the copyright
year range in the test, before pushing.
-Chris.
Could I get the following change reviewed please?
http://cr.openjdk.java.net/~michaelm/8170920/webrev.1/
Thanks,
Michael.
10 matches
Mail list logo
