Hi Michael, the bug then obviously was a side effect of my change http://hg.openjdk.java.net/jdk9/dev/jdk/rev/9f0ab4b20ff7 for 8167481. Sorry for that.
To follow the concept of my cleanups I'd prefer if you could use #if defined(MACOSX) rather than #ifdef MACOSX in net_util_md.c to be consistent within the file. I also followed the platform order 1. Linux, 2. AIX, 3. Solaris, 4. Mac in all parts of the native code, so your newly introduced section should go after the "#if defined(__solaris__)" system header include parts, e.g. line 47 of the original file. Thanks Christoph > -----Original Message----- > From: net-dev [mailto:net-dev-boun...@openjdk.java.net] On Behalf Of Chris > Hegarty > Sent: Freitag, 9. Dezember 2016 11:52 > To: Michael McMahon <michael.x.mcma...@oracle.com>; OpenJDK Network > Dev list <net-dev@openjdk.java.net> > Subject: Re: RFR: 8170920 SO_RCVBUF and SO_SNDBUF options problem for > network channels on MacOS > > > On 09/12/16 10:33, Michael McMahon wrote: > > Could I get the following change reviewed please? > > > > http://cr.openjdk.java.net/~michaelm/8170920/webrev.1/ > > Looks good. > > You may just want to remove the "from" year from the copyright > year range in the test, before pushing. > > -Chris.
