Bernd,

I'll add a test for SO_SNDBUF. These parameters are too system dependent
to use hard coded values in the tests though. I'm not sure you could depend
on the initial/default value never being the same as the maximum value either.

Thanks,
Michael

On 09/12/2016, 11:31, Bernd Eckenfels wrote:
Should the test maybe assert that a change was made (or maybe be a bit more whitebox and assert the result is >64k? Should it test SND+RCV?

Gruss
Bernd
--
http://bernd.eckenfels.net




On Fri, Dec 9, 2016 at 12:04 PM +0100, "Michael McMahon" <michael.x.mcma...@oracle.com <mailto:michael.x.mcma...@oracle.com>> wrote:

    Could I get the following change reviewed please?

    http://cr.openjdk.java.net/~michaelm/8170920/webrev.1/

    Thanks,
    Michael.

Reply via email to