RE: Patch for adding SO_REUSEPORT socket option

Subject: Re: Patch for adding SO_REUSEPORT socket option On 11/02/2016 17:47, Lu, Yingqi wrote: > : > > Please let us know if everything is all right. > > Again, thank you very much for your help! > I've pushed the changes to the jdk9/dev forest: http://hg.openjdk.ja

Re: Patch for adding SO_REUSEPORT socket option

On 11/02/2016 17:47, Lu, Yingqi wrote: : Please let us know if everything is all right. Again, thank you very much for your help! I've pushed the changes to the jdk9/dev forest: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/f92af283ab18 -Alan.

Re: Patch for adding SO_REUSEPORT socket option

> Yingqi >>> Sent: Thursday, February 11, 2016 9:47 AM >>> To: Alan Bateman ; Volker Simonis >>> ; Michael McMahon >>> Cc: Kaczmarek, Eric ; Viswanathan, Sandhya >>> ; Kharbas, Kishor ; >>> Aundhe, Shirish ; net-dev@openjdk.java.net >>> Subjec

Re: Patch for adding SO_REUSEPORT socket option

9:47 AM To: Alan Bateman ; Volker Simonis ; Michael McMahon Cc: Kaczmarek, Eric ; Viswanathan, Sandhya ; Kharbas, Kishor ; Aundhe, Shirish ; net-dev@openjdk.java.net Subject: RE: Patch for adding SO_REUSEPORT socket option Hi Alan, Here is the most recent modification of the patch. The link is

Re: Patch for adding SO_REUSEPORT socket option

On 17/02/2016 11:43, Chris Hegarty wrote: I know this has gone through several rounds of review already. I do not want to stall progress, I am reasonably happy with the changes, but I have a few comments ( that can be addressed later, if needed ). - MulticastSocket.java: I would add a javado

Re: Patch for adding SO_REUSEPORT socket option

: Patch for adding SO_REUSEPORT socket option Hi Alan, Here is the most recent modification of the patch. The link is available here: http://cr.openjdk.java.net/~mcberg/jdk/6432031/webrev.11/ I know this has gone through several rounds of review already. I do not want to stall progress, I am

Re: Patch for adding SO_REUSEPORT socket option

On 17/02/2016 09:22, Volker Simonis wrote: Hi Alan, I'm just running a quick test build on AIX to see if everything is still working. I'll let you know once it completes (latest today evening). I've done the same and I think we need to drop the patches to the DatagramChannel multicast tests

Re: Patch for adding SO_REUSEPORT socket option

Hi Alan, I'm just running a quick test build on AIX to see if everything is still working. I'll let you know once it completes (latest today evening). Thanks, Volker On Tue, Feb 16, 2016 at 11:18 PM, Alan Bateman wrote: > > > On 16/02/2016 18:03, Lu, Yingqi wrote: >> >> Hi Alan, >> >> I am won

Re: Patch for adding SO_REUSEPORT socket option

Thank u very much, Alan! Sent from my iPhone > On Feb 16, 2016, at 2:18 PM, Alan Bateman wrote: > > > >> On 16/02/2016 18:03, Lu, Yingqi wrote: >> Hi Alan, >> >> I am wondering if you got chances to review the latest patch? Thank you! >> >> Thanks, >> Lucy > I'm happy with the latest patch

Re: Patch for adding SO_REUSEPORT socket option

On 16/02/2016 18:03, Lu, Yingqi wrote: Hi Alan, I am wondering if you got chances to review the latest patch? Thank you! Thanks, Lucy I'm happy with the latest patch and I will try to get it into JDK 9 soon for you. -Alan

RE: Patch for adding SO_REUSEPORT socket option

McMahon Cc: Kaczmarek, Eric ; Viswanathan, Sandhya ; Kharbas, Kishor ; Aundhe, Shirish ; net-dev@openjdk.java.net Subject: RE: Patch for adding SO_REUSEPORT socket option Hi Alan, Here is the most recent modification of the patch. The link is available here: http://cr.openjdk.java.net/~mcberg/jdk

RE: Patch for adding SO_REUSEPORT socket option

Bateman [mailto:alan.bate...@oracle.com] Sent: Wednesday, February 10, 2016 10:38 AM To: Lu, Yingqi ; Volker Simonis ; Michael McMahon Cc: net-dev@openjdk.java.net; Viswanathan, Sandhya ; Kharbas, Kishor ; Aundhe, Shirish ; Kaczmarek, Eric Subject: Re: Patch for adding SO_REUSEPORT socket option

Re: Patch for adding SO_REUSEPORT socket option

On 05/02/2016 17:27, Lu, Yingqi wrote: Hi Alan, Here is the new modification of the patch. The link is available here: http://cr.openjdk.java.net/~mcberg/jdk/6432031/webrev.10/ In this version, we make supportedOptions() in AbstractPlainSocketImpl and AbstractPlainDatagramSocketImpl return an

RE: Patch for adding SO_REUSEPORT socket option

@openjdk.java.net; Viswanathan, Sandhya ; Kharbas, Kishor ; Aundhe, Shirish ; Kaczmarek, Eric Subject: Re: Patch for adding SO_REUSEPORT socket option On 28/01/2016 06:03, Lu, Yingqi wrote: > Hi Alan, > > Here is a new version of the patch: > http://cr.openjdk.java.net/~mcberg/jdk/64320

Re: Patch for adding SO_REUSEPORT socket option

On 28/01/2016 06:03, Lu, Yingqi wrote: Hi Alan, Here is a new version of the patch: http://cr.openjdk.java.net/~mcberg/jdk/6432031/webrev.08/ In this version, based on your comment, we have changed following items: 1. Remove the dependency of DatagramSocketImpl and MulticastSocket with Abstr

RE: Patch for adding SO_REUSEPORT socket option

, Sandhya ; Kharbas, Kishor ; Aundhe, Shirish ; Kaczmarek, Eric Subject: Re: Patch for adding SO_REUSEPORT socket option On 14/01/2016 18:28, Lu, Yingqi wrote: > Hi Alan/Michael/Volker, > > Here is the link to the version 7 of the patch. > http://cr.openjdk.java.net/~mcberg/jdk/64320

Re: Patch for adding SO_REUSEPORT socket option

On 14/01/2016 18:28, Lu, Yingqi wrote: Hi Alan/Michael/Volker, Here is the link to the version 7 of the patch. http://cr.openjdk.java.net/~mcberg/jdk/6432031/webrev.07/ Please note: after the code has been uploaded, I found out I forgot to remove extra check of ENOPROTOOPT in the net_util_md.

RE: Patch for adding SO_REUSEPORT socket option

; Kaczmarek, Eric Subject: Re: Patch for adding SO_REUSEPORT socket option On 07/01/2016 16:41, Lu, Yingqi wrote: > Hi Alan, > > In AbstractPlainSocketImpl, I am using the existing/default initializer so > that there is only 1 initializer. However, it does not execute. That is the

Re: Patch for adding SO_REUSEPORT socket option

On 07/01/2016 16:41, Lu, Yingqi wrote: Hi Alan, In AbstractPlainSocketImpl, I am using the existing/default initializer so that there is only 1 initializer. However, it does not execute. That is the issue I am seeing. Any suggestion on the issue? Are you 100% sure that your updated Abstrac

RE: Patch for adding SO_REUSEPORT socket option

...@oracle.com] Sent: Wednesday, January 06, 2016 7:38 AM To: Lu, Yingqi ; Volker Simonis Cc: net-dev@openjdk.java.net; Viswanathan, Sandhya ; Kharbas, Kishor ; Aundhe, Shirish ; Kaczmarek, Eric Subject: Re: Patch for adding SO_REUSEPORT socket option On 05/01/2016 18:56, Lu, Yingqi wrote: >

Re: Patch for adding SO_REUSEPORT socket option

On 05/01/2016 18:56, Lu, Yingqi wrote: Hi Alan, Sorry for the confusion. Let me be more detailed on the issue. In previous version of the patch, I added an initializer in SocketImpl.java to load the libnet.so since the isReusePortAvailable and its native implementation were there. Then, thi

RE: Patch for adding SO_REUSEPORT socket option

for adding SO_REUSEPORT socket option On 05/01/2016 04:32, Lu, Yingqi wrote: > Hi Alan/Volker, > > I just found out that the code works by adding the same static block (net > library loading) into SocketImpl.java although isReusePortAvailable() is > being defined

Re: Patch for adding SO_REUSEPORT socket option

Hi Lucy, I've just looked at the javadoc of MulticastSocket. It has this sentence: * When the socket is created the * {@link DatagramSocket#setReuseAddress(boolean)} method is * called to enable the SO_REUSEADDR socket option. but it doesn't mention SO_REUSEPORT. Could you please

Re: Patch for adding SO_REUSEPORT socket option

On 05/01/2016 04:32, Lu, Yingqi wrote: Hi Alan/Volker, I just found out that the code works by adding the same static block (net library loading) into SocketImpl.java although isReusePortAvailable() is being defined in its subclass AbstractPlainSocketIml.java. I use a print statement to con

Re: Patch for adding SO_REUSEPORT socket option

On 04/01/2016 19:24, Volker Simonis wrote: On Mon, Jan 4, 2016 at 8:02 PM, Lu, Yingqi wrote: : 2. Regarding to the code snippet in net_util_md.c, the reason I check for ENOPROTOOPT is to enable SO_REUSEPORT in the situation that the feature is supported but something else happens during se

RE: Patch for adding SO_REUSEPORT socket option

...@openjdk.java.net] On Behalf Of Lu, Yingqi Sent: Monday, January 04, 2016 3:30 PM To: Volker Simonis ; Alan Bateman Cc: net-dev@openjdk.java.net; Viswanathan, Sandhya ; Kharbas, Kishor ; Aundhe, Shirish ; Kaczmarek, Eric Subject: RE: Patch for adding SO_REUSEPORT socket option One more

RE: Patch for adding SO_REUSEPORT socket option

: Volker Simonis [mailto:volker.simo...@gmail.com] Sent: Monday, January 04, 2016 11:26 AM To: Alan Bateman Cc: Lu, Yingqi ; Kaczmarek, Eric ; Viswanathan, Sandhya ; Kharbas, Kishor ; Aundhe, Shirish ; net-dev@openjdk.java.net Subject: Re: Patch for adding SO_REUSEPORT socket option On Mon, Jan 4, 2016

Re: Patch for adding SO_REUSEPORT socket option

On Mon, Jan 4, 2016 at 8:24 PM, Alan Bateman wrote: > > > On 04/01/2016 18:43, Volker Simonis wrote: >> >> : >> Alan, what do you mean by "unknown" platform? Currently, as far as I >> know, 0x0200 is used by AIX and MacOS X. Do you suggest to name these >> platforms explicitly and set it to 0 othe

Re: Patch for adding SO_REUSEPORT socket option

> Cc: Lu, Yingqi ; Kaczmarek, Eric > ; Viswanathan, Sandhya > ; Kharbas, Kishor ; > Aundhe, Shirish ; net-dev@openjdk.java.net > Subject: Re: Patch for adding SO_REUSEPORT socket option > > Hi Lucy, Alan, > > I'm back from vacation so here we go :) > > On F

Re: Patch for adding SO_REUSEPORT socket option

On 04/01/2016 18:43, Volker Simonis wrote: : Alan, what do you mean by "unknown" platform? Currently, as far as I know, 0x0200 is used by AIX and MacOS X. Do you suggest to name these platforms explicitly and set it to 0 otherwise? Leaving the default at 0x0200 has the advantage that it would i

RE: Patch for adding SO_REUSEPORT socket option

, Kishor ; Aundhe, Shirish ; net-dev@openjdk.java.net Subject: Re: Patch for adding SO_REUSEPORT socket option Hi Lucy, Alan, I'm back from vacation so here we go :) On Fri, Jan 1, 2016 at 12:18 PM, Alan Bateman wrote: > > On 21/12/2015 17:53, Lu, Yingqi wrote: >> >> Hi A

Re: Patch for adding SO_REUSEPORT socket option

Hi Lucy, Alan, I'm back from vacation so here we go :) On Fri, Jan 1, 2016 at 12:18 PM, Alan Bateman wrote: > > On 21/12/2015 17:53, Lu, Yingqi wrote: >> >> Hi All, >> >> Sorry for the late reply. Here is the link to the most recent reversion of >> the patch (version #6). >> http://cr.openjdk.

RE: Patch for adding SO_REUSEPORT socket option

: Lu, Yingqi Cc: Viswanathan, Sandhya ; net-dev@openjdk.java.net; Kharbas, Kishor ; Aundhe, Shirish ; Kaczmarek, Eric Subject: Re: Patch for adding SO_REUSEPORT socket option On 21/12/2015 17:53, Lu, Yingqi wrote: > Hi All, > > Sorry for the late reply. Here is the link to the mo

Re: Patch for adding SO_REUSEPORT socket option

On 21/12/2015 17:53, Lu, Yingqi wrote: Hi All, Sorry for the late reply. Here is the link to the most recent reversion of the patch (version #6). http://cr.openjdk.java.net/~mcberg/jdk/6432031/webrev.06/ In this version, we have done following modifications based on the feedback we received.

RE: Patch for adding SO_REUSEPORT socket option

el McMahon ; Volker Simonis Cc: Viswanathan, Sandhya ; net-dev@openjdk.java.net; Kharbas, Kishor ; Aundhe, Shirish ; Kaczmarek, Eric Subject: RE: Patch for adding SO_REUSEPORT socket option Hi All, Here is an update on the progress. Based on the comments and feedback we received, we modified

RE: Patch for adding SO_REUSEPORT socket option

Lu, Yingqi Sent: Tuesday, December 08, 2015 9:11 AM To: Alan Bateman ; Michael McMahon ; Volker Simonis Cc: Viswanathan, Sandhya ; net-dev@openjdk.java.net; Kharbas, Kishor ; Aundhe, Shirish ; Kaczmarek, Eric Subject: RE: Patch for adding SO_REUSEPORT socket option Thank you very much for

RE: Patch for adding SO_REUSEPORT socket option

; Viswanathan, Sandhya ; Aundhe, Shirish Subject: Re: Patch for adding SO_REUSEPORT socket option On 08/12/2015 00:53, Lu, Yingqi wrote: > Hi Alan, > > I heard that the feature freeze for OpenJDK9 is approaching. Given the > significant performance impact (up to 1.93x with Hadoop Dist

Re: Patch for adding SO_REUSEPORT socket option

On 08/12/2015 00:53, Lu, Yingqi wrote: Hi Alan, I heard that the feature freeze for OpenJDK9 is approaching. Given the significant performance impact (up to 1.93x with Hadoop Distributed File System) this feature provides and the status of the existing work, we would be really interested in

RE: Patch for adding SO_REUSEPORT socket option

;Alan Bateman' ; Volker Simonis Cc: Michael McMahon ; Kaczmarek, Eric ; net-dev@openjdk.java.net; Kharbas, Kishor Subject: RE: Patch for adding SO_REUSEPORT socket option OK, will do. Thanks, Lucy -Original Message- From: Alan Bateman [mailto:alan.bate...@oracle.com] Sent: Monday

RE: Patch for adding SO_REUSEPORT socket option

OK, will do. Thanks, Lucy -Original Message- From: Alan Bateman [mailto:alan.bate...@oracle.com] Sent: Monday, December 07, 2015 1:01 PM To: Lu, Yingqi ; Volker Simonis Cc: Michael McMahon ; Kaczmarek, Eric ; net-dev@openjdk.java.net; Kharbas, Kishor Subject: Re: Patch for adding

Re: Patch for adding SO_REUSEPORT socket option

On 07/12/2015 18:59, Lu, Yingqi wrote: Oh, I got it now. You want SO_REUSEPORT to be disabled by default for both ServerSocketChannelImpl and SocketChannelImpl. I am actually OK either way. Alan/Michael, what is your take on this? If we all think "default off" is the correct/better way to go

RE: Patch for adding SO_REUSEPORT socket option

as, Kishor Subject: Re: Patch for adding SO_REUSEPORT socket option On Mon, Dec 7, 2015 at 7:02 PM, Lu, Yingqi wrote: > Hi Volker, > > Thank you very much for your feedback. > > 1. For the following code, I will do it as platform specific as you suggested. > 37 /* Defines SO

Re: Patch for adding SO_REUSEPORT socket option

> > > - that's probably another clean-up change, but do we really still need to > support pre-1.4 DatagramSocketImpl? > > > And as always, the copyright of all the files you've touched has to be > updated to 2015 (or 2016 :) > > Regard

RE: Patch for adding SO_REUSEPORT socket option

mo...@gmail.com] Sent: Monday, December 07, 2015 9:51 AM To: Lu, Yingqi ; Alan Bateman ; Michael McMahon Cc: Kaczmarek, Eric ; net-dev@openjdk.java.net; Kharbas, Kishor Subject: Re: Patch for adding SO_REUSEPORT socket option Hi Lucy, thanks for updating the change and sorry for the late rev

Re: Patch for adding SO_REUSEPORT socket option

> > Thanks, > > Lucy > > > > From: Lu, Yingqi > Sent: Monday, November 30, 2015 11:25 PM > To: Lu, Yingqi ; Volker Simonis > > > > Cc: Kaczmarek, Eric ; net-dev@openjdk.java.net; > Kharbas, Kishor > Subject: RE: Patch for adding SO_REUSEPORT so

RE: Patch for adding SO_REUSEPORT socket option

, Yingqi ; Alan Bateman Cc: Kaczmarek, Eric ; Kharbas, Kishor ; net-dev@openjdk.java.net Subject: Re: Patch for adding SO_REUSEPORT socket option Yes, since the functionality is basically duplicated across the two mechanisms and since setOption/getOption already exists, the only new part of the

Re: Patch for adding SO_REUSEPORT socket option

. I will work on this today. Hopefully can send out an update tomorrow. Thanks, Lucy *From:*Alan Bateman [mailto:alan.bate...@oracle.com] *Sent:* Monday, December 07, 2015 7:04 AM *To:* Lu, Yingqi *Cc:* net-dev@openjdk.java.net; Kharbas, Kishor ; Kaczmarek, Eric *Subject:* Re: Patch for a

RE: Patch for adding SO_REUSEPORT socket option

t: Re: Patch for adding SO_REUSEPORT socket option On 02/12/2015 17:08, Lu, Yingqi wrote: Hi All, A quick check here. Does anyone get a chance to try the most recent patch? Any feedback and comments? Thanks, Lucy I looked through the latest webrev (webrev.05) and it's looking quite good. I

Re: Patch for adding SO_REUSEPORT socket option

On 02/12/2015 17:08, Lu, Yingqi wrote: Hi All, A quick check here. Does anyone get a chance to try the most recent patch? Any feedback and comments? Thanks, Lucy I looked through the latest webrev (webrev.05) and it's looking quite good. I agree with Michael, we should decide whether

Re: Patch for adding SO_REUSEPORT socket option

eck. I will get back to you as soon as I can. Thanks, Lucy -Original Message- From: Volker Simonis [mailto:volker.simo...@gmail.com ] Sent: Wednesday, November 25, 2015 10:46 AM To: Lu, Yingqi > Cc: Michael McMahon >; Alan Bateman >; Kharbas, Kishor

RE: Patch for adding SO_REUSEPORT socket option

: Patch for adding SO_REUSEPORT socket option Hi All, Here is the most recent version of the patch. http://cr.openjdk.java.net/~mcberg/jdk/6432031/webrev.05/ We already tested patch on Linux 3.4.110 kernel and 3.18 kernel with regression tests from java.net and java.nio, and a simple program for

RE: Patch for adding SO_REUSEPORT socket option

...@openjdk.java.net] On Behalf Of Lu, Yingqi Sent: Wednesday, November 25, 2015 5:12 PM To: Volker Simonis Cc: Kaczmarek, Eric ; net-dev@openjdk.java.net; Kharbas, Kishor Subject: RE: Patch for adding SO_REUSEPORT socket option Here is an update. Changes are already completed locally. All the

RE: Patch for adding SO_REUSEPORT socket option

; net-dev@openjdk.java.net; Kaczmarek, Eric Subject: RE: Patch for adding SO_REUSEPORT socket option Yes, it should work! I already located the issues. Good catch! I will submit an update as soon as possible. Thanks, Lucy From: Volker Simonis [mailto:volker.simo...@gmail.com] Sent: Wednesday, Novembe

RE: Patch for adding SO_REUSEPORT socket option

; net-dev@openjdk.java.net; Kaczmarek, Eric Subject: Re: Patch for adding SO_REUSEPORT socket option Yes, I indeed tested on an old kernel - but that should still work after your change! On Wednesday, November 25, 2015, Lu, Yingqi mailto:yingqi...@intel.com>> wrote: Hi Volker, Thanks very mu

Re: Patch for adding SO_REUSEPORT socket option

com ] > Sent: Wednesday, November 25, 2015 10:46 AM > To: Lu, Yingqi > > Cc: Michael McMahon >; Alan > Bateman >; Kharbas, Kishor < > kishor.khar...@intel.com >; net-dev@openjdk.java.net > ; Kaczmarek, Eric > > Subject: Re: Patch for adding SO_REUSEPORT socket

RE: Patch for adding SO_REUSEPORT socket option

- > From: net-dev [mailto:net-dev-boun...@openjdk.java.net] On Behalf Of > Michael McMahon > Sent: Monday, November 23, 2015 2:54 AM > To: Volker Simonis ; Alan Bateman > > Cc: Kharbas, Kishor ; > net-dev@openjdk.java.net > Subject: Re: Patch for adding SO_REUSEPORT socket

Re: Patch for adding SO_REUSEPORT socket option

t-dev-boun...@openjdk.java.net] On Behalf Of Michael > McMahon > Sent: Monday, November 23, 2015 2:54 AM > To: Volker Simonis ; Alan Bateman > > Cc: Kharbas, Kishor ; net-dev@openjdk.java.net > Subject: Re: Patch for adding SO_REUSEPORT socket option > > I agree we should

RE: Patch for adding SO_REUSEPORT socket option

- From: net-dev [mailto:net-dev-boun...@openjdk.java.net] On Behalf Of Michael McMahon Sent: Monday, November 23, 2015 2:54 AM To: Volker Simonis ; Alan Bateman Cc: Kharbas, Kishor ; net-dev@openjdk.java.net Subject: Re: Patch for adding SO_REUSEPORT socket option I agree we should enable

Re: Patch for adding SO_REUSEPORT socket option

;> Lucy >> >> -Original Message- >> From: Michael McMahon [mailto:michael.x.mcma...@oracle.com] >> Sent: Monday, November 23, 2015 3:42 AM >> To: Volker Simonis ; Alan Bateman >> >> Cc: Kharbas, Kishor ; net-dev@openjdk.java.net; >>

RE: Patch for adding SO_REUSEPORT socket option

ael.x.mcma...@oracle.com] Sent: Monday, November 23, 2015 3:42 AM To: Volker Simonis ; Alan Bateman Cc: Kharbas, Kishor ; net-dev@openjdk.java.net; Lu, Yingqi Subject: Re: Patch for adding SO_REUSEPORT socket option How about the following for the apidoc in j.n.StandardSocketOptions? We can then refe

Re: Patch for adding SO_REUSEPORT socket option

On Mon, Nov 23, 2015 at 11:54 AM, Michael McMahon wrote: > I agree we should enable the option on all platforms. > We can add the code to do that and run the tests. > > On the existing use of SO_REUSEPORT on AIX and Mac > it appears that is set to emulate expected behavior on > other platforms whe

Re: Patch for adding SO_REUSEPORT socket option

el McMahon [mailto:michael.x.mcma...@oracle.com] Sent: Monday, November 23, 2015 3:42 AM To: Volker Simonis ; Alan Bateman Cc: Kharbas, Kishor ; net-dev@openjdk.java.net; Lu, Yingqi Subject: Re: Patch for adding SO_REUSEPORT socket option How about the following for the apidoc in j.n.StandardSoc

Re: Patch for adding SO_REUSEPORT socket option

I agree we should enable the option on all platforms. We can add the code to do that and run the tests. On the existing use of SO_REUSEPORT on AIX and Mac it appears that is set to emulate expected behavior on other platforms when SO_REUSEADDR is set for datagram sockets. The expectation is that

Re: Patch for adding SO_REUSEPORT socket option

How about the following for the apidoc in j.n.StandardSocketOptions? We can then reference this text from everywhere else rather than repeating it. (just noticed Lucy was not included in the last few mails) - Michael /** * Re-use port. * * The value of this socket option is

Re: Patch for adding SO_REUSEPORT socket option

Hi Lucy, in general I support the addition of SO_REUSEPORT to the set of standard socket options. However for me the problem is not that this new option is not supported on all platforms, but instead that it has such different semantics on different platforms. If you look at the code, you'll see t

Re: Patch for adding SO_REUSEPORT socket option

On 23/11/2015 04:12, Lu, Yingqi wrote: Hi Alan, One more question please JI want to make sure I understand correctly on your following suggestion. In order to use supportedOptions method to test SO_REUSEPORT, I will need to first write a native function to check if SO_REUSEPORT is supporte

RE: Patch for adding SO_REUSEPORT socket option

, November 22, 2015 12:25 AM To: Lu, Yingqi ; Kharbas, Kishor ; net-dev@openjdk.java.net Subject: Re: Patch for adding SO_REUSEPORT socket option On 21/11/2015 02:08, Lu, Yingqi wrote: Hi Alan, Please let me know if there is anything we can do at the meantime to help. We are more than happy to

RE: Patch for adding SO_REUSEPORT socket option

Kharbas, Kishor ; net-dev@openjdk.java.net Subject: Re: Patch for adding SO_REUSEPORT socket option On 21/11/2015 02:08, Lu, Yingqi wrote: Hi Alan, Please let me know if there is anything we can do at the meantime to help. We are more than happy to help. Sorry, I wasn't clear. I meant that

Re: Patch for adding SO_REUSEPORT socket option

On 21/11/2015 02:08, Lu, Yingqi wrote: Hi Alan, Please let me know if there is anything we can do at the meantime to help. We are more than happy to help. Sorry, I wasn't clear. I meant that you will need to work on the javadoc. In many of the classes you've added the following to the spec

RE: Patch for adding SO_REUSEPORT socket option

McMahon Subject: Re: Patch for adding SO_REUSEPORT socket option On 20/11/2015 20:59, Lu, Yingqi wrote: Hello All, We added Version 3 of the patch here. http://cr.openjdk.java.net/~mcberg/jdk/6432031/webrev.03/<http://cr.openjdk.java.net/%7Emcberg/jdk/6432031/webrev.03/> It has the exac

Re: Patch for adding SO_REUSEPORT socket option

On 20/11/2015 20:59, Lu, Yingqi wrote: Hello All, We added Version 3 of the patch here. http://cr.openjdk.java.net/~mcberg/jdk/6432031/webrev.03/ It has the exact same implementation as Version 1 which implements SO_REUSEPORT

RE: Patch for adding SO_REUSEPORT socket option

; Kharbas, Kishor ; net-dev@openjdk.java.net; Michael McMahon ; core-libs-dev Subject: RE: Patch for adding SO_REUSEPORT socket option Hi Alan and Michael, Thank very much to both of you for your feedback. Currently, I think the only platform that does not have SO_REUSEPORT is Windows. As

RE: Patch for adding SO_REUSEPORT socket option

e time to review the patches and let us know your feedback and comments! Thanks, Lucy From: net-dev [mailto:net-dev-boun...@openjdk.java.net] On Behalf Of Alan Bateman Sent: Thursday, November 19, 2015 9:52 AM To: Kharbas, Kishor; net-dev@openjdk.java.net Subject: Re: Patch for adding SO_REU

Re: Patch for adding SO_REUSEPORT socket option

On 16/11/2015 18:49, Kharbas, Kishor wrote: P.S. Based on Alan Baleman's comment on JBS, we are in meanwhile working on adding this option to 'java.net.ExtendedSocketOption'. My comment in the bug was just to bring up the question as to whether this should be a standard or JDK-specific so

RE: Patch for adding SO_REUSEPORT socket option

OpenJDK so that users can take advantage of it. Thanks, Yingqi (Lucy) Lu From: Michael McMahon [mailto:michael.x.mcma...@oracle.com] Sent: Thursday, November 19, 2015 9:12 AM To: Lu, Yingqi; Kharbas, Kishor; net-dev@openjdk.java.net Subject: Re: Patch for adding SO_REUSEPORT socket option Hi

Re: Patch for adding SO_REUSEPORT socket option

gqi Lu (Lucy) *From:*net-dev [mailto:net-dev-boun...@openjdk.java.net] *On Behalf Of *Michael McMahon *Sent:* Thursday, November 19, 2015 6:11 AM *To:* Kharbas, Kishor; net-dev@openjdk.java.net *Subject:* Re: Patch for adding SO_REUSEPORT socket option Hi Kishor Did you mean to include the patch wit

RE: Patch for adding SO_REUSEPORT socket option

; Kharbas, Kishor; net-dev@openjdk.java.net Subject: Re: Patch for adding SO_REUSEPORT socket option there would appear to be a link to a webrev in the JBS bug https://bugs.openjdk.java.net/browse/JDK-6432031 http://cr.openjdk.java.net/~mcberg/jdk/6432031/webrev.01/ I presume that a review is

Re: Patch for adding SO_REUSEPORT socket option

Thanks Mark. I'll take a look at the patch then - Michael On 19/11/15 14:52, Mark Sheppard wrote: there would appear to be a link to a webrev in the JBS bug https://bugs.openjdk.java.net/browse/JDK-6432031 http://cr.openjdk.java.net/~mcber

Re: Patch for adding SO_REUSEPORT socket option

there would appear to be a link to a webrev in the JBS bug https://bugs.openjdk.java.net/browse/JDK-6432031 http://cr.openjdk.java.net/~mcberg/jdk/6432031/webrev.01/ I presume t

RE: Patch for adding SO_REUSEPORT socket option

this community. Thanks, Yingqi Lu (Lucy) From: net-dev [mailto:net-dev-boun...@openjdk.java.net] On Behalf Of Michael McMahon Sent: Thursday, November 19, 2015 6:11 AM To: Kharbas, Kishor; net-dev@openjdk.java.net Subject: Re: Patch for adding SO_REUSEPORT socket option Hi Kishor Did you me

Re: Patch for adding SO_REUSEPORT socket option

Hi Kishor Did you mean to include the patch with this message? If you send it, I can convert it to a webrev and put it on the cr.openjdk server for review Thanks Michael On 16/11/15 18:49, Kharbas, Kishor wrote: Hello all, I request the community to review a patch for adding SO_REUSEPORT su

Patch for adding SO_REUSEPORT socket option

Hello all, I request the community to review a patch for adding SO_REUSEPORT support. There is already an existing JBS opened at https://bugs.openjdk.java.net/browse/JDK-6432031 Details : SO_REUSEPORT removes 1:1 assignment between listen socket and IP:PORT pair and enable multiple sockets li