Hello All, We added Version 3 of the patch here. http://cr.openjdk.java.net/~mcberg/jdk/6432031/webrev.03/
It has the exact same implementation as Version 1 which implements SO_REUSEPORT as the standard socket option. The only difference in Version 3 is that we added 1 test file for testing set/get reuseport. The file is located at ./jdk/test/java/net/Socket/setReusePort/Basic.java Please let us know your comments and feedback! Thanks, Lucy From: net-dev [mailto:net-dev-boun...@openjdk.java.net] On Behalf Of Lu, Yingqi Sent: Thursday, November 19, 2015 12:21 PM To: Alan Bateman <alan.bate...@oracle.com>; Kharbas, Kishor <kishor.khar...@intel.com>; net-dev@openjdk.java.net; Michael McMahon <michael.x.mcma...@oracle.com>; core-libs-dev <core-libs-dev-boun...@openjdk.java.net> Subject: RE: Patch for adding SO_REUSEPORT socket option Hi Alan and Michael, Thank very much to both of you for your feedback. Currently, I think the only platform that does not have SO_REUSEPORT is Windows. As Michael mentioned, API allows this possibility by throwing SocketException with message "Invalid option". Older kernel that does not support the feature throws SocketException with message "Protocol not available". By the way, I just got notified that the second version is also uploaded. I put it here as well in case you want to take a look and compare. However, I agree, standard socket option may be a better way to implement. Please let us know your feedback. Here is the first version (standard socket option): http://cr.openjdk.java.net/~mcberg/jdk/6432031/webrev.01/ Here is the second version (extended socket option): http://cr.openjdk.java.net/~mcberg/jdk/6432031/webrev.02/ All, please take some time to review the patches and let us know your feedback and comments! Thanks, Lucy From: net-dev [mailto:net-dev-boun...@openjdk.java.net] On Behalf Of Alan Bateman Sent: Thursday, November 19, 2015 9:52 AM To: Kharbas, Kishor; net-dev@openjdk.java.net<mailto:net-dev@openjdk.java.net> Subject: Re: Patch for adding SO_REUSEPORT socket option On 16/11/2015 18:49, Kharbas, Kishor wrote: P.S. Based on Alan Baleman's comment on JBS, we are in meanwhile working on adding this option to 'java.net.ExtendedSocketOption'. My comment in the bug was just to bring up the question as to whether this should be a standard or JDK-specific socket option. If it is consistently implemented on most platforms then having in the standard API make sense. -Alan
