Chris Hegarty wrote:
Thanks, got 'em
http://cr.openjdk.java.net/~chegar/7020136/webrev.02/webrev/
-Chris.
Looks much better now, thumbs up from me.
-Alan.
On 02/24/11 11:11 AM, Alan Bateman wrote:
Chris Hegarty wrote:
Yeah, a little more love is required. I hope I've covered all your
concerns.
http://cr.openjdk.java.net/~chegar/7020136/webrev.01/webrev/
This looks much better. In the main method it doesn't look like you need
to catch IOExceptio
Chris Hegarty wrote:
Yeah, a little more love is required. I hope I've covered all your
concerns.
http://cr.openjdk.java.net/~chegar/7020136/webrev.01/webrev/
This looks much better. In the main method it doesn't look like you
need to catch IOException. In run() you just could use
try-wit
On 02/24/11 10:38 AM, Alan Bateman wrote:
Chris Hegarty wrote:
Michael, Alan,
The timeout of 2 seconds would appear to be too small for busy
systems. Increase to 10 seconds (and add some extra debugging
information if failure).
http://cr.openjdk.java.net/~chegar/7020136/webrev.00/webrev/
-Chr
Chris Hegarty wrote:
Michael, Alan,
The timeout of 2 seconds would appear to be too small for busy
systems. Increase to 10 seconds (and add some extra debugging
information if failure).
http://cr.openjdk.java.net/~chegar/7020136/webrev.00/webrev/
-Chris.
The change looks okay to me but it l
Michael, Alan,
The timeout of 2 seconds would appear to be too small for busy systems.
Increase to 10 seconds (and add some extra debugging information if
failure).
http://cr.openjdk.java.net/~chegar/7020136/webrev.00/webrev/
-Chris.
