On 02/24/11 10:38 AM, Alan Bateman wrote:
Chris Hegarty wrote:
Michael, Alan,
The timeout of 2 seconds would appear to be too small for busy
systems. Increase to 10 seconds (and add some extra debugging
information if failure).
http://cr.openjdk.java.net/~chegar/7020136/webrev.00/webrev/
-Chris.
The change looks okay to me but it looks like this old test could do
with some other cleanup (if you have cycles). It looks like it passes if
it can't create a ServerSocket, the run method will leave s1 open if
there is an error writing the reply and more. Given that it's such a
small test it might be worth re-writing it.
Yeah, a little more love is required. I hope I've covered all your concerns.
http://cr.openjdk.java.net/~chegar/7020136/webrev.01/webrev/
Thanks,
-Chris.
-Alan.
