Chris Hegarty wrote:

Yeah, a little more love is required. I hope I've covered all your concerns.

http://cr.openjdk.java.net/~chegar/7020136/webrev.01/webrev/
This looks much better. In the main method it doesn't look like you need to catch IOException. In run() you just could use try-with-resource to ensure that s is closed (two cases). Otherwise I think this is a big improvement.

-Alan

Reply via email to