Re: RFR: 8258422: Cleanup unnecessary null comparison before instanceof check in java.base [v3]

> On Dec 16, 2020, at 1:47 AM, Chris Hegarty wrote: > > On Wed, 16 Dec 2020 09:20:09 GMT, Andrey Turbanov > wrote: > >>> 8258422: Cleanup unnecessary null comparison before instanceof check in >>> java.base >> >> Andrey Turbanov has updated the pull request incrementally with one >> addi

Re: [10] RFR: 8186930: Constant fold URI constants

One way to proceed in the future is to use those static methods as constant producing functions (via condy), then at jlink time run the functions and possibly strip out the then redundant code. Paul. > On 30 Aug 2017, at 09:16, Daniel Fuchs wrote: > > Hi Claes, > > Maybe it could be interest

Re: RFR JDK-8156742: Miscellaneous WebSocket API improvements

> On 1 Jun 2016, at 15:17, Pavel Rappo wrote: > > On the stream thing, well... If you say it's a rare use case, I say let's hear > more people. I don't have much experience working with WebSocket as a user, > so I > would like to listen to people who have it (like yourself). YAGNI is one of my

Re: RFR 8146758, NetworkInterfaceStreamTest.java fails intermittently at comparing network interfaces

> On 15 Apr 2016, at 11:29, Felix Yang wrote: > > Hi all, > please review the following fix. It is an intermittent failure because of > Teredo Tunneling Pseudo-Interface. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8146758 > Webrev: http://cr.openjdk.java.net/~xiaofeya/8146758/webrev.0

Re: RFR: 8087112 HTTP API and HTTP/1.1 implementation

> On 18 Feb 2016, at 17:34, Michael McMahon > wrote: > > On 18/02/16 16:06, Paul Sandoz wrote: >>> On 18 Feb 2016, at 16:37, Michael McMahon >>> wrote: >>> >>>> When building a request how does one set multiple values for a header?

Re: RFR: 8087112 HTTP API and HTTP/1.1 implementation

> On 18 Feb 2016, at 16:37, Michael McMahon > wrote: > >> When building a request how does one set multiple values for a header? >> setHeaders overwrites, does one used headers(…) instead? >> > > headers(String, String) > and headers(String ...) both accumulate headers > What headers would

Re: RFR: 8087112 HTTP API and HTTP/1.1 implementation

> On 4 Feb 2016, at 17:14, Michael McMahon wrote: > > Hi, > > The following webrevs are for the initial implementation of JEP 110. > Most of it is in the jdk repository with some build configuration in the top > level repo for putting this code in its own module (java.httpclient). > > http://c

Re: RFR 8131155/9, java/net/NetworkInterface/NetworkInterfaceStreamTest.java failed because of Teredo Tunneling Pseudo-Interface

> On 18 Dec 2015, at 10:42, Amy Lu wrote: > > Change looks fine. Thank you for the update Felix. > > (But please wait for the final GO from one official reviewer.) > +1 Amy, can you sponsor? Thanks, Paul. signature.asc Description: Message signed with OpenPGP using GPGMail

Re: RFR 8131155/9, java/net/NetworkInterface/NetworkInterfaceStreamTest.java failed because of Teredo Tunneling Pseudo-Interface

> On 14 Dec 2015, at 11:53, Chris Hegarty wrote: > > > > On 14/12/15 10:07, Paul Sandoz wrote: >> Hi Felix, >> >> Is it correct to filter out all network interfaces on windows platforms? > > I may be missing something, but this should ONLY filter out

Re: RFR 8131155/9, java/net/NetworkInterface/NetworkInterfaceStreamTest.java failed because of Teredo Tunneling Pseudo-Interface

Hi Felix, Is it correct to filter out all network interfaces on windows platforms? IIUC that renders the tests testSubNetworkInterfaces and testInetAddresses redundant on windows. If so it would be useful to document that on those tests. Some minor suggestions: s/isWindows/IS_WINDOWS Colo

Re: WebSocket client API

Hi Pavel, Simone, One way to make progress is to get the basic shape of the API agreed on without flow/resource management features. That probably represented the simplest form. I think we are very close to that. Then lets iterate from that form and consider the additional features (back-press

Re: WebSocket client API

Hi, Overall i think this API seems to be compressing down nicely to a small number of classes/interfaces, but i still think there is some room for further simplifications. WebSocket I don’t see the need for a context parameter. Context can be obtained via capturing. That reduces the requirem

Re: RFR 8081678: Add Stream returning methods to classes where there currently exist only Enumeration returning methods

On Jun 3, 2015, at 11:00 PM, Chris Hegarty wrote: > Looks good Paul, just a few minor comments. ( looked at all, but *security* > and *sql* ) > > NetworkInterface > s/Enumertion/Stream >L127 * will be returned in the Enumeration. However, if the caller has the > > s/an/a >L131 * @re

Re: RFR 8081678: Add Stream returning methods to classes where there currently exist only Enumeration returning methods

On Jun 3, 2015, at 9:27 PM, Alan Bateman wrote: > On 03/06/2015 17:47, Paul Sandoz wrote: >> : >> Ok, i removed it but added an assert for the array being non-null and >> containing at least one element. I also refined the documentation of the >> stream return

Re: RFR 8081678: Add Stream returning methods to classes where there currently exist only Enumeration returning methods

On Jun 3, 2015, at 12:46 PM, Alan Bateman wrote: > > On 02/06/2015 14:37, Paul Sandoz wrote: > >> : >> >> There is one small area of uncertainty with NetworkInterface. Can the >> following method ever return null? >> >> 342 public stat

Re: RFR [9] 8075139: Restore java.protocol.handler.pkgs to work as a fallback for migration

On Apr 21, 2015, at 12:32 PM, Alan Bateman wrote: > > > On 21/04/2015 11:20, Chris Hegarty wrote: >> On 15 Apr 2015, at 16:43, Paul Sandoz wrote: >> >>> On Apr 15, 2015, at 4:35 PM, Chris Hegarty wrote: >>>>> I marginally prefer usi

Re: RFR [9] 8075139: Restore java.protocol.handler.pkgs to work as a fallback for migration

On Apr 15, 2015, at 4:35 PM, Chris Hegarty wrote: >> >> I marginally prefer using flatMap rather than map/filter e.g. change >> getHandler to return Stream< URLStreamHandler> and change the last line to >> be "return Stream.ofNullable(handle). Up to you. > > That's better. For completeness, th

Re: RFR [9] 8075139: Restore java.protocol.handler.pkgs to work as a fallback for migration

On Apr 15, 2015, at 1:36 PM, Chris Hegarty wrote: > > Paul, > > > > > Yes, one could use a Pattern.splitAsStream, sorry could not resist :-) > > assuming this area is not sensitive to bootstrap issues e.g. > > > >hander = > > p.splitAsStream().map(String::trim).flatMap(this::getHandler).fi

Re: RFR [9] 8075139: Restore java.protocol.handler.pkgs to work as a fallback for migration

On Apr 14, 2015, at 9:33 PM, Alan Bateman wrote: > On 14/04/2015 17:24, Chris Hegarty wrote: >> The work done as part of JDK-8064924 [1] to introduce a new service type, >> java.net.spi.URLStreamHandlerProvider, provides a clean provider mechanism >> that will work well with modules. That part

Re: RFR 8064924: Update java.net.URL to work with modules

On Feb 2, 2015, at 12:34 PM, Chris Hegarty wrote: > On 02/02/15 11:00, Paul Sandoz wrote: >> >> On Jan 30, 2015, at 10:10 PM, Alan Bateman wrote: >> >>> On 30/01/2015 15:35, Chris Hegarty wrote: >>>> : >>>> >>>> Update

Re: RFR 8064924: Update java.net.URL to work with modules

On Jan 30, 2015, at 10:10 PM, Alan Bateman wrote: > On 30/01/2015 15:35, Chris Hegarty wrote: >> : >> >> Update webrev and spec diffs: >>http://cr.openjdk.java.net/~chegar/8064924/01/ >> > I think the javadoc looks much better now, thanks. > Minor comments in URL: Java doc on URL constr

Re: The future of Serialization

On Aug 9, 2014, at 7:20 PM, Brian Goetz wrote: >> I've noticed there's not much interest in improving Serialization on >> these lists. This makes me wonder if java Serialization has lost >> relevance in recent years with the rise of protocol buffers apache >> thrift and other means of data tran

Re: RFR 8049220: URL.factory data race

On Jul 7, 2014, at 1:07 PM, Peter Levart wrote: > Hi Pavel, Alan and Paul, > > Thanks for reviewing. I accepted the suggestions from Pavel and Paul and > created webrev.02: > > http://cr.openjdk.java.net/~plevart/jdk9-dev/URL.factory/webrev.02/ > > Is this good to go into jdk9-dev? > Looks

Re: RFR 8049220: URL.factory data race

On Jul 3, 2014, at 6:33 PM, Alan Bateman wrote: > On 03/07/2014 09:43, Peter Levart wrote: >> Hi, >> >> I noticed a data race in java.net.URL: >> >>https://bugs.openjdk.java.net/browse/JDK-8049220 >> >> I propose the following simple patch: >> >> http://cr.openjdk.java.net/~plevart/jdk9-de

Re: JDK-8041679 Replace uses of StringBuffer with StringBuilder within the JDK

On May 12, 2014, at 4:07 PM, Daniel Fuchs wrote: > Hi Paul, > > I looked at -management and the changes there look good. > > There is just some two spaces vs four space formatting in >

Re: JDK-8041679 Replace uses of StringBuffer with StringBuilder within the JDK

On May 12, 2014, at 1:00 PM, Ivan Gerasimov wrote: > src/share/classes/sun/misc/UUDecoder.java > 126 StringBuilder x = new StringBuilder(); > Is only filled, but doesn't seem to be used anyhow. > Maybe just delete it? > Thanks, i will take a look at this and your other change once s/S

Re: JDK-8041679 Replace uses of StringBuffer with StringBuilder within the JDK

On May 12, 2014, at 12:42 PM, Alan Bateman wrote: > On 12/05/2014 11:03, Paul Sandoz wrote: >> >> It covers many areas and i have grouped the patches into such areas to aid >> reviewing. When commenting please including core-libs. > The groupings are a bit odd Yeah,

JDK-8041679 Replace uses of StringBuffer with StringBuilder within the JDK

Hi, This is a request for review of Otavio's patch replacing StringBuffer with StringBuilder within OpenJDK. (I also need to review it.) It covers many areas and i have grouped the patches into such areas to aid reviewing. When commenting please including core-libs. Jtreg tests showed no regre

hg: jdk8/tl/jdk: 4 new changesets

Changeset: 9f098aed44c0 Author:anazarov Date: 2014-01-31 12:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9f098aed44c0 8032025: Update repeating annotations demo Reviewed-by: jfranck + src/share/sample/annotations/DependencyChecker/PluginChecker/src/checker/Device.java

hg: jdk8/tl/jdk: 8032190: Specifications of stream flatMap methods should require mapped streams to be closed

Changeset: 68eb0c55a8c0 Author:psandoz Date: 2014-01-21 10:49 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/68eb0c55a8c0 8032190: Specifications of stream flatMap methods should require mapped streams to be closed Reviewed-by: chegar, alanb ! src/share/classes/java/util/st

hg: jdk8/tl/jdk: 8031187: DoubleStream.count is incorrect for a stream containing > Integer.MAX_VALUE elements

Changeset: 630a92015993 Author:psandoz Date: 2014-01-09 10:52 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/630a92015993 8031187: DoubleStream.count is incorrect for a stream containing > Integer.MAX_VALUE elements Reviewed-by: darcy ! src/share/classes/java/util/stream/Do

hg: jdk8/tl/jdk: 8028564: Concurrent calls to CHM.put can fail to add the key/value to the map

Changeset: dc2f0c40399a Author:psandoz Date: 2013-12-05 09:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dc2f0c40399a 8028564: Concurrent calls to CHM.put can fail to add the key/value to the map Reviewed-by: psandoz, chegar, alanb Contributed-by: Doug Lea ! src/share/c

hg: jdk8/tl/jdk: 8029164: Race condition in CompletableFuture.thenCompose with asynchronous task

Changeset: 2aa455506c49 Author:psandoz Date: 2013-12-04 10:27 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2aa455506c49 8029164: Race condition in CompletableFuture.thenCompose with asynchronous task Reviewed-by: dl, chegar, mduigou ! src/share/classes/java/util/concurrent

hg: jdk8/tl/jdk: 8028516: Java doc error in Int/Long/Double/Stream.peek

Changeset: 1f45b24ffe4b Author:psandoz Date: 2013-11-25 09:55 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1f45b24ffe4b 8028516: Java doc error in Int/Long/Double/Stream.peek Reviewed-by: chegar ! src/share/classes/java/util/stream/DoubleStream.java ! src/share/classes/jav

hg: jdk8/tl/jdk: 8027712: DistinctOpTest fails for unordered test

Changeset: d5b3f83ffc40 Author:psandoz Date: 2013-11-05 12:08 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d5b3f83ffc40 8027712: DistinctOpTest fails for unordered test Reviewed-by: henryjen, alanb ! test/java/util/stream/test/org/openjdk/tests/java/util/stream/DistinctOp

hg: jdk8/tl/jdk: 8027316: Distinct operation on an unordered stream should not be a barrier

Changeset: 18c111c17231 Author:psandoz Date: 2013-10-31 11:59 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/18c111c17231 8027316: Distinct operation on an unordered stream should not be a barrier Reviewed-by: henryjen, mduigou, briangoetz ! src/share/classes/java/util/strea

hg: jdk8/tl/jdk: 8020061: Clarify reporting characteristics between splits

Changeset: 1cd20806fd5c Author:psandoz Date: 2013-10-09 15:19 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1cd20806fd5c 8020061: Clarify reporting characteristics between splits Reviewed-by: alanb, chegar ! src/share/classes/java/util/Spliterator.java

hg: jdk8/tl/jdk: 8025136: SplittableRandom enchancements

Changeset: b90dcd1a71bf Author:psandoz Date: 2013-10-08 11:17 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b90dcd1a71bf 8025136: SplittableRandom enchancements Reviewed-by: psandoz, martin Contributed-by: Doug Lea , Guy Steele ! src/share/classes/java/util/Random.java !

hg: jdk8/tl/jdk: 2 new changesets

Changeset: 811c35a6a58f Author:psandoz Date: 2013-10-02 16:34 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/811c35a6a58f 8025534: Unsafe typecast in java.util.stream.Streams.Nodes 8025538: Unsafe typecast in java.util.stream.SpinedBuffer 8025533: Unsafe typecast in java.uti

hg: jdk8/tl/jdk: 8025535: Unsafe typecast in java.util.stream.SortedOps

Changeset: e1b04fd49204 Author:psandoz Date: 2013-10-01 18:20 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e1b04fd49204 8025535: Unsafe typecast in java.util.stream.SortedOps Reviewed-by: mduigou, chegar ! src/share/classes/java/util/stream/SortedOps.java ! test/java/util

hg: jdk8/tl/jdk: 8024408: Specifications for Collection/List/Set/SortedSet.spliterator() need to document if all the (subclass) instances are required to return SIZED spliterators

Changeset: f8b3ab514564 Author:psandoz Date: 2013-10-01 12:19 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f8b3ab514564 8024408: Specifications for Collection/List/Set/SortedSet.spliterator() need to document if all the (subclass) instances are required to return SIZED sp

hg: jdk8/tl/jdk: 8024341: j.u.regex.Pattern.splitAsStream() doesn't correspond to split() method if using an example from the spec

Changeset: c30dc8e7744e Author:psandoz Date: 2013-09-20 17:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c30dc8e7744e 8024341: j.u.regex.Pattern.splitAsStream() doesn't correspond to split() method if using an example from the spec Reviewed-by: alanb ! src/share/classes

hg: jdk8/tl/jdk: 8024253: ThreadLocal random can use SecureRandom for the initial seed

Changeset: 7913855ff66c Author:psandoz Date: 2013-09-20 11:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7913855ff66c 8024253: ThreadLocal random can use SecureRandom for the initial seed Reviewed-by: psandoz, chegar, alanb Contributed-by: Doug Lea , Peter Levart , Guy S

hg: jdk8/tl/jdk: 8024405: Spliterators.spliterator should support CONCURRENT characteristic

Changeset: 0ef7ddef9de0 Author:psandoz Date: 2013-09-19 20:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0ef7ddef9de0 8024405: Spliterators.spliterator should support CONCURRENT characteristic Reviewed-by: martin ! src/share/classes/java/util/Spliterator.java ! src/share

hg: jdk8/tl/jdk: 8025002: "".codePoints().sorted().iterator().hasNext() causes NegativeArraySizeException

Changeset: f36714707c38 Author:psandoz Date: 2013-09-18 10:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f36714707c38 8025002: "".codePoints().sorted().iterator().hasNext() causes NegativeArraySizeException Reviewed-by: henryjen, alanb ! src/share/classes/java/lang/Char

hg: jdk8/tl/jdk: 8024837: Rename java/util/concurrent/ConcurrentHashMap/toArray.java to ToArray.java

Changeset: 5025ed287a4a Author:psandoz Date: 2013-09-15 16:13 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5025ed287a4a 8024837: Rename java/util/concurrent/ConcurrentHashMap/toArray.java to ToArray.java Reviewed-by: alanb ! test/java/util/concurrent/ConcurrentHashMap/ToA

hg: jdk8/tl/jdk: 8010293: java/util/concurrent/ConcurrentHashMap/toArray.java fails intermittently

Levart , Paul Sandoz ! src/share/classes/java/util/concurrent/ConcurrentHashMap.java ! test/java/util/concurrent/ConcurrentHashMap/toArray.java

hg: jdk8/tl/jdk: 8023463: Improvements to HashMap/LinkedHashMap use of bins/buckets and trees (red/black); ...

report ORDERED Reviewed-by: mduigou, forax, bchristi, alanb Contributed-by: Doug Lea , Paul Sandoz ! src/share/classes/java/util/HashMap.java ! src/share/classes/java/util/LinkedHashMap.java ! test/java/lang/reflect/Generics/Probe.java ! test/java/util/Map/CheckRandomHashSeed.java ! test/java/util

hg: jdk8/tl/jdk: 8024182: test/java/util/Arrays/SetAllTest.java fails to compile due to recent compiler changes

Changeset: 462c5589bc1a Author:psandoz Date: 2013-08-12 12:22 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/462c5589bc1a 8024182: test/java/util/Arrays/SetAllTest.java fails to compile due to recent compiler changes Summary: Use explicit lambda due to javac simplfying rules

hg: jdk8/tl/jdk: 8023155: Ensure functional consistency across Random, ThreadLocalRandom, SplittableRandom

Changeset: b1f41565b806 Author:psandoz Date: 2013-08-28 22:11 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b1f41565b806 8023155: Ensure functional consistency across Random, ThreadLocalRandom, SplittableRandom Reviewed-by: mduigou Contributed-by: Doug Lea , Paul Sandoz

hg: jdk8/tl/jdk: 8020292: j.u.SplittableRandom

Changeset: 5ce9025c9e1a Author:psandoz Date: 2013-08-26 22:55 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5ce9025c9e1a 8020292: j.u.SplittableRandom Reviewed-by: mduigou Contributed-by: Guy Steele , Doug Lea , Brian Goetz , Paul Sandoz + src/share/classes/java/util

hg: jdk8/tl/jdk: 8023234: StampedLock serializes readers on writer unlock

Changeset: 8a36fc7f494c Author:shade Date: 2013-08-26 17:50 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a36fc7f494c 8023234: StampedLock serializes readers on writer unlock Summary: Sync-up the fix from jsr166 CVS, signal more readers on writer unlock Reviewed-by: martin,

hg: jdk8/tl/jdk: 8023367: Collections.emptyList().sort((Comparator)null) throws NPE

Changeset: c17d6543b30f Author:psandoz Date: 2013-08-20 17:36 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c17d6543b30f 8023367: Collections.emptyList().sort((Comparator)null) throws NPE Reviewed-by: alanb, mduigou ! src/share/classes/java/util/Collections.java ! test/java

hg: jdk8/tl/jdk: 8014824: Document Spliterator characteristics and binding policy of java util collection impls

Changeset: 3647aab7b1d5 Author:psandoz Date: 2013-08-06 14:26 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3647aab7b1d5 8014824: Document Spliterator characteristics and binding policy of java util collection impls Reviewed-by: chegar ! src/share/classes/java/util/ArrayDe

hg: jdk8/tl/jdk: 8022318: Document Spliterator characteristics and binding policy of java util concurrent collection impls

Buchholz , Paul Sandoz ! src/share/classes/java/util/concurrent/ArrayBlockingQueue.java ! src/share/classes/java/util/concurrent/ConcurrentHashMap.java ! src/share/classes/java/util/concurrent/ConcurrentLinkedDeque.java ! src/share/classes/java/util/concurrent/ConcurrentLinkedQueue.java ! src/share

hg: jdk8/tl/jdk: 8022797: Clarify spliterator characteristics for collections containing no elements

Changeset: 737b6c298d81 Author:psandoz Date: 2013-08-13 11:16 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/737b6c298d81 8022797: Clarify spliterator characteristics for collections containing no elements Reviewed-by: alanb, mduigou ! src/share/classes/java/util/Collection

hg: jdk8/tl/jdk: 2 new changesets

Changeset: 2eebaff52a94 Author:psandoz Date: 2013-08-16 12:46 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2eebaff52a94 8012940: More than 50 tests failed in Serialization/DeSerialization testing (test-mangled) Reviewed-by: ksrini + test/java/util/stream/bootlib/java/util

hg: jdk8/tl/jdk: 8023150: java/util/stream tests no longer compiling following JDK-8019401

Changeset: 5fe19566b6f0 Author:psandoz Date: 2013-08-16 12:29 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5fe19566b6f0 8023150: java/util/stream tests no longer compiling following JDK-8019401 Reviewed-by: alanb ! test/java/util/stream/test/org/openjdk/tests/java/util/st

hg: jdk8/tl/jdk: 8022326: Spliterator for values of j.u.c.ConcurrentSkipListMap does not report ORDERED

Changeset: c29ca19cb816 Author:psandoz Date: 2013-08-09 11:44 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c29ca19cb816 8022326: Spliterator for values of j.u.c.ConcurrentSkipListMap does not report ORDERED Reviewed-by: martin, chegar ! src/share/classes/java/util/TreeMap

hg: jdk8/tl/jdk: 8020016: Numerous splitereator impls do not throw NPE for null Consumers

Changeset: 0be7839d4599 Author:psandoz Date: 2013-08-01 15:28 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0be7839d4599 8020016: Numerous splitereator impls do not throw NPE for null Consumers Reviewed-by: mduigou, alanb, henryjen ! src/share/classes/java/util/stream/Spine

hg: jdk8/tl/jdk: 8021883: j.u.Random/RandomStream.java test needs more robust timeout duration

Changeset: d30f357c6050 Author:psandoz Date: 2013-07-30 14:03 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d30f357c6050 8021883: j.u.Random/RandomStream.java test needs more robust timeout duration Reviewed-by: chegar ! test/java/util/Random/RandomStreamTest.java

hg: jdk8/tl/jdk: 8021863: Stream.concat incorrectly calculates unsized state

Changeset: 76d88a752a03 Author:psandoz Date: 2013-07-30 11:32 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/76d88a752a03 8021863: Stream.concat incorrectly calculates unsized state Reviewed-by: chegar ! src/share/classes/java/util/stream/Streams.java ! test/java/util/strea

hg: jdk8/tl/jdk: 8020156: TreeMap.values().spliterator() does not report ORDERED; ...

Changeset: e83fc6d9cf03 Author:psandoz Date: 2013-07-29 19:41 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e83fc6d9cf03 8020156: TreeMap.values().spliterator() does not report ORDERED 8020009: TreeMap.entrySet().spliterator() reports SORTED + null comparator but the elemen

hg: jdk8/tl/jdk: 8019395: Consolidate StreamSupport.{stream, parallelStream} into a single method

Changeset: be096613bfb5 Author:psandoz Date: 2013-07-03 21:43 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/be096613bfb5 8019395: Consolidate StreamSupport.{stream,parallelStream} into a single method Reviewed-by: henryjen, briangoetz ! src/share/classes/java/io/BufferedRea

hg: jdk8/tl/jdk: 8019484: Sync j.u.c.ConcurrentHashMap from 166 to tl

Changeset: 05b164788aab Author:psandoz Date: 2013-07-11 13:07 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/05b164788aab 8019484: Sync j.u.c.ConcurrentHashMap from 166 to tl Reviewed-by: martin Contributed-by: Doug Lea ! src/share/classes/java/util/concurrent/ConcurrentHas

hg: jdk8/tl/jdk: 8020040: Improve and generalize the F/J tasks to handle right or left-balanced trees

Changeset: 882baa1e0a38 Author:psandoz Date: 2013-07-10 10:24 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/882baa1e0a38 8020040: Improve and generalize the F/J tasks to handle right or left-balanced trees Reviewed-by: briangoetz Contributed-by: doug lea , paul sandoz

hg: jdk8/tl/jdk: 8017447: Unmodifiable map entry becomes modifiable if taken from a stream of map entries

Changeset: ff5df05222d1 Author:psandoz Date: 2013-07-10 09:52 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ff5df05222d1 8017447: Unmodifiable map entry becomes modifiable if taken from a stream of map entries Reviewed-by: briangoetz ! src/share/classes/java/util/Collectio

hg: jdk8/tl/jdk: 8019370: Sync j.u.c Fork/Join from 166 to tl

Changeset: 43134e79c0bb Author:psandoz Date: 2013-07-09 16:04 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/43134e79c0bb 8019370: Sync j.u.c Fork/Join from 166 to tl Reviewed-by: chegar, martin Contributed-by: Doug Lea ! src/share/classes/java/util/concurrent/AbstractExecu

hg: jdk8/tl/jdk: 8019551: Make BaseStream public

Changeset: 44a634c1edc4 Author:psandoz Date: 2013-07-09 10:44 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/44a634c1edc4 8019551: Make BaseStream public Reviewed-by: chegar, psandoz Contributed-by: brian goetz ! src/share/classes/java/util/stream/AbstractPipeline.java ! sr

hg: jdk8/tl/jdk: 8017141: java.util/stream Spliterators from sequential sources should not catch OOME

Changeset: 628432ee4d68 Author:henryjen Date: 2013-07-09 09:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/628432ee4d68 8017141: java.util/stream Spliterators from sequential sources should not catch OOME Reviewed-by: mchung Contributed-by: paul.san...@oracle.com ! src/s

hg: jdk8/tl/jdk: 8017329: 8b92-lambda regression: TreeSet("a", "b").stream().substream(1).parallel().iterator() is empty

Changeset: 7532bb2d6476 Author:psandoz Date: 2013-07-03 21:19 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7532bb2d6476 8017329: 8b92-lambda regression: TreeSet("a", "b").stream().substream(1).parallel().iterator() is empty Reviewed-by: alanb ! src/share/classes/java/util

hg: jdk8/tl/jdk: 2 new changesets

Changeset: dfd7fb0ce54b Author:psandoz Date: 2013-07-03 11:58 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dfd7fb0ce54b 8011427: java.util.concurrent collection Spliterator implementations Reviewed-by: martin Contributed-by: Doug Lea ! src/share/classes/java/util/concurre

hg: jdk8/tl/jdk: 8012987: Optimizations for Stream.limit/substream

Changeset: 28b71c97a72d Author:psandoz Date: 2013-06-28 10:29 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/28b71c97a72d 8012987: Optimizations for Stream.limit/substream Reviewed-by: mduigou Contributed-by: Brian Goetz , Paul Sandoz ! src/share/classes/java/util/stream

hg: jdk8/tl/jdk: 8009736: Comparator API cleanup

Changeset: c1df54fd19b2 Author:henryjen Date: 2013-06-11 13:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c1df54fd19b2 8009736: Comparator API cleanup Reviewed-by: psandoz, briangoetz, mduigou, plevart ! src/share/classes/java/util/Collections.java ! src/share/classes/ja

hg: jdk8/tl/jdk: 8016139: PrimitiveIterator.forEachRemaining

Changeset: 562f5cf13a9c Author:psandoz Date: 2013-06-20 11:21 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/562f5cf13a9c 8016139: PrimitiveIterator.forEachRemaining Reviewed-by: alanb ! src/share/classes/java/util/PrimitiveIterator.java

hg: jdk8/tl/jdk: 8016455: Sync stream tests from lambda to tl

Changeset: f758d7c24396 Author:psandoz Date: 2013-06-20 11:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f758d7c24396 8016455: Sync stream tests from lambda to tl Reviewed-by: mduigou Contributed-by: Brian Goetz , Paul Sandoz ! test/java/util/stream/bootlib/java/util

hg: jdk8/tl/jdk: 8016324: filter/flatMap pipeline sinks should pass size information to downstream sink

Changeset: 85524d9839dc Author:psandoz Date: 2013-06-20 11:02 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/85524d9839dc 8016324: filter/flatMap pipeline sinks should pass size information to downstream sink Reviewed-by: chegar, mduigou Contributed-by: Brian Goetz ! src/s

hg: jdk8/tl/jdk: 8016308: Updates to j.u.stream.Node/Nodes

Changeset: 656ea2349aa5 Author:psandoz Date: 2013-06-20 10:45 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/656ea2349aa5 8016308: Updates to j.u.stream.Node/Nodes Reviewed-by: mduigou Contributed-by: Brian Goetz , Paul Sandoz ! src/share/classes/java/util/stream

hg: jdk8/tl/jdk: 8016251: Balanced spliterator for SpinedBuffer

Changeset: a50394c44464 Author:psandoz Date: 2013-06-13 11:13 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a50394c44464 8016251: Balanced spliterator for SpinedBuffer Reviewed-by: mduigou Contributed-by: Brian Goetz , Peter Levart , Paul Sandoz ! src/share/classes/java

hg: jdk8/tl/jdk: 8015895: Int/LongStream.range/rangeClosed; ...

Changeset: 8d627f324c38 Author:psandoz Date: 2013-06-11 12:13 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8d627f324c38 8015895: Int/LongStream.range/rangeClosed 8012986: Right-bias range spliterators for large ranges Reviewed-by: mduigou ! src/share/classes/java/util/stre

hg: jdk8/tl/jdk: 8015492: Remove DoubleStream.range methods

Changeset: 3990fcab2cd9 Author:psandoz Date: 2013-06-10 11:52 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3990fcab2cd9 8015492: Remove DoubleStream.range methods Reviewed-by: alanb ! src/share/classes/java/util/stream/DoubleStream.java ! src/share/classes/java/util/stream

hg: jdk8/tl/jdk: 8015798: Rename IntStream.longs/doubles and LongStream.doubles to asXxxStream

Changeset: 7322e8ad7c01 Author:psandoz Date: 2013-06-10 12:20 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7322e8ad7c01 8015798: Rename IntStream.longs/doubles and LongStream.doubles to asXxxStream Reviewed-by: alanb ! src/share/classes/java/util/stream/IntPipeline.java !

hg: jdk8/tl/jdk: 8015792: Rename Spliterators.spliteratorFromIterator to Spliterators.iterator

Changeset: 9c462579b624 Author:psandoz Date: 2013-06-10 12:26 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9c462579b624 8015792: Rename Spliterators.spliteratorFromIterator to Spliterators.iterator Reviewed-by: chegar ! src/share/classes/java/util/Spliterators.java ! src/s

hg: jdk8/tl/jdk: 8013649: HashMap spliterator tryAdvance() encounters remaining elements after forEachRemaining()

Changeset: de11b20f8c01 Author:psandoz Date: 2013-05-31 10:53 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/de11b20f8c01 8013649: HashMap spliterator tryAdvance() encounters remaining elements after forEachRemaining() Reviewed-by: chegar ! src/share/classes/java/util/HashM

hg: jdk8/tl/jdk: 8015790: Remove duplicate spliterator tests

Changeset: fad4ef2123ca Author:psandoz Date: 2013-06-04 11:53 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fad4ef2123ca 8015790: Remove duplicate spliterator tests Reviewed-by: alanb, mduigou - test/java/util/stream/test/org/openjdk/tests/java/util/stream/SpliteratorLateB

hg: jdk8/tl/jdk: 8014383: StringJoiner example in class description not in sync with streams API

Changeset: a79e2683eae3 Author:psandoz Date: 2013-06-03 17:37 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a79e2683eae3 8014383: StringJoiner example in class description not in sync with streams API Reviewed-by: alanb ! src/share/classes/java/util/StringJoiner.java

hg: jdk8/tl/jdk: 8014731: j.u.stream.StreamSupport class has default constructor generated

Contributed-by: Paul Sandoz , Henry Jen ! src/share/classes/java/util/stream/StreamSupport.java

hg: jdk8/tl/jdk: 8015008: Primitive iterator over empty sequence, null consumer: forEachRemaining methods do not throw NPE

Changeset: f3c7c5f753dc Author:psandoz Date: 2013-06-03 10:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f3c7c5f753dc 8015008: Primitive iterator over empty sequence, null consumer: forEachRemaining methods do not throw NPE Reviewed-by: chegar ! src/share/classes/java/u

hg: jdk8/tl/jdk: 8014732: Minor spec issue: java.util.Spliterator.getExactSizeIfKnown

Changeset: b47044426bcd Author:psandoz Date: 2013-05-31 09:58 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b47044426bcd 8014732: Minor spec issue: java.util.Spliterator.getExactSizeIfKnown Summary: A minor documentation issue (not a spec issue). Reviewed-by: chegar, dl ! s

hg: jdk8/tl/jdk: 8014393: Minor typo in the spec for j.u.stream.Stream.findFirst()

Changeset: b4742d038100 Author:psandoz Date: 2013-05-28 15:22 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b4742d038100 8014393: Minor typo in the spec for j.u.stream.Stream.findFirst() Reviewed-by: alanb, chegar ! src/share/classes/java/util/stream/DoubleStream.java ! src

hg: jdk8/tl/jdk: 8014409: Spec typo: extra } in the spec for j.u.s.StreamBuilder

Changeset: 156ee44cd456 Author:psandoz Date: 2013-05-30 16:08 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/156ee44cd456 8014409: Spec typo: extra } in the spec for j.u.s.StreamBuilder Summary: Also fixes documentation on StreamBuilder.OfDouble Reviewed-by: alanb, chegar, md

Re: Indenting code?

e dealing with multiple release families, it makes the >> merges much more difficult. >> >> Brad > One think that Paul Sandoz suggested recently is that we should have a NB > template that folks can use to avoid some discussions/debates on styles. +1 i.e. make produci

Re: Review of new Http client API

h Chris shows easily allows for a default handler when one is not supplied. > But, it raises a question in that while we currently have callback interfaces > for both > headers and data, we only have a Future based interface for headers (but not > data). > Indeed! Paul

Re: Review of new Http client API

On Aug 23, 2012, at 5:05 PM, Chris Hegarty wrote: > Paul, > > All good feedback, and I will leave it to Michael to reply to the specifics. > On thought I had on separation of modes is something list this: > > interface HeaderHandler { > onHeaders(HttpResponse); > } > interface ErrorHa

Re: Review of new Http client API

Hi, A potential simplification of the HttpResponseHeadersHandler interface is to turn it into a functional interface: HttpResponseHandler onHeaders(Future dresp) throws InterruptedException, ExecutionException; [Chris, i am not sure if an interface with two methods, one default, is classifi

Re: UrlEncodedQueryString CCC request

Paul Sandoz wrote: Hi Richard, Michael, Some clarifications on UriBuilder, URI templates and URI processing in JSR-311. UriBuilder is primarily concerned about making easy to safely and efficiently build URIs. It was designed to be general in nature rather than scoped to a certain way in

Re: UrlEncodedQueryString CCC request

a zip file Thanks, Michael. -- | ? + ? = To question \ Paul Sandoz x38109 +33-4-76188109