On Sep 14, 2012, at 1:20 PM, Alan Bateman <alan.bate...@oracle.com> wrote:
> On 14/09/2012 01:21, Brad Wetmore wrote:
>> Netbean's automatic formatting does a pretty good job with new code.
>> However, I think the general advice is to not change existing code just
>> because. When you're dealing with multiple release families, it makes the
>> merges much more difficult.
>>
>> Brad
> One think that Paul Sandoz suggested recently is that we should have a NB
> template that folks can use to avoid some discussions/debates on styles.
+1 i.e. make producing and reviewing code easier.
> It would be great for someone to run with that, the hard part is of course
> that it will be impossible to get agreement. Personally I find NB's defaults
> okay but there are several cases where its indenting is horrible.
>
> Anyway, the main advice I think is to keep things locally consistent where
> possible. Also major refactoring or formatting in a bug fix is a royal pain
> for reviewers.
>
The solution to that is to re-format all JDK source code using a tool and
commit independent of any fixes, i bet the NBs formatter could be extracted for
command line operation.
IMHO it requires a benevolent dictator to decide on the exact formatting rules,
since agreement is unlikely to be reached and much more heat than light will
ever come from such discussions about where to place a '{'.
FWIW i really don't care about what the style would be as long as it is not
equivalent to a Huggy Bear sofa so garish as to require one to wear peril
sensitive sunglasses.
Paul.
