Re: RFR 8131155/9, java/net/NetworkInterface/NetworkInterfaceStreamTest.java failed because of Teredo Tunneling Pseudo-Interface

Mon, 14 Dec 2015 02:09:07 -0800 

Hi Felix,

Is it correct to filter out all network interfaces on windows platforms?

IIUC that renders the tests testSubNetworkInterfaces and testInetAddresses 
redundant on windows.

If so it would be useful to document that on those tests.


Some minor suggestions:

  s/isWindows/IS_WINDOWS

Colocate the “isIncluded" with IS_WINDOWS.

Paul.

> On 14 Dec 2015, at 07:53, Felix Yang <felix.y...@oracle.com> wrote:
> 
> Hi all,
>    please review the fix for 
> java/net/NetworkInterface/NetworkInterfaceStreamTest.java. It is necessary to 
> exclude "Teredo Tunneling Pseudo-Interface" whose configuration changes 
> frequently.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8131155
> Webrev: http://cr.openjdk.java.net/~xiaofeya/8131155/webrev.00
> 
> Thanks,
> Felix

Attachment: signature.asc
Description: Message signed with OpenPGP using GPGMail

Reply via email to