RE: RFR 8153674: Expected SocketException not thrown when calling bind() with setReuseAddress(false)

2016-09-28 Thread Lu, Yingqi
[mailto:vyom.tew...@oracle.com] Sent: Wednesday, September 28, 2016 1:26 AM To: Chris Hegarty ; Mark Sheppard ; net-dev ; Kaczmarek, Eric ; Viswanathan, Sandhya ; Kharbas, Kishor ; Aundhe, Shirish ; Lu, Yingqi Subject: Re: RFR 8153674: Expected SocketException not thrown when calling bind() with

RE: Patch for adding SO_REUSEPORT socket option

2016-02-23 Thread Lu, Yingqi
Thank you for your help, Alan! -Original Message- From: Alan Bateman [mailto:alan.bate...@oracle.com] Sent: Tuesday, February 23, 2016 9:55 AM To: Lu, Yingqi ; Volker Simonis Cc: net-dev@openjdk.java.net; Viswanathan, Sandhya ; Kharbas, Kishor ; Aundhe, Shirish ; Kaczmarek, Eric

Re: Patch for adding SO_REUSEPORT socket option

2016-02-16 Thread Lu, Yingqi
Thank u very much, Alan! Sent from my iPhone > On Feb 16, 2016, at 2:18 PM, Alan Bateman wrote: > > > >> On 16/02/2016 18:03, Lu, Yingqi wrote: >> Hi Alan, >> >> I am wondering if you got chances to review the latest patch? Thank you! >> >> T

RE: Patch for adding SO_REUSEPORT socket option

2016-02-16 Thread Lu, Yingqi
Hi Alan, I am wondering if you got chances to review the latest patch? Thank you! Thanks, Lucy -Original Message- From: net-dev [mailto:net-dev-boun...@openjdk.java.net] On Behalf Of Lu, Yingqi Sent: Thursday, February 11, 2016 9:47 AM To: Alan Bateman ; Volker Simonis ; Michael

RE: Patch for adding SO_REUSEPORT socket option

2016-02-11 Thread Lu, Yingqi
Bateman [mailto:alan.bate...@oracle.com] Sent: Wednesday, February 10, 2016 10:38 AM To: Lu, Yingqi ; Volker Simonis ; Michael McMahon Cc: net-dev@openjdk.java.net; Viswanathan, Sandhya ; Kharbas, Kishor ; Aundhe, Shirish ; Kaczmarek, Eric Subject: Re: Patch for adding SO_REUSEPORT socket option

RE: Patch for adding SO_REUSEPORT socket option

2016-02-05 Thread Lu, Yingqi
addition, we corrected couple formatting issues. Please let us know your feedback and comments. Thanks, Lucy -Original Message- From: Alan Bateman [mailto:alan.bate...@oracle.com] Sent: Friday, January 29, 2016 6:38 AM To: Lu, Yingqi ; Volker Simonis ; Michael McMahon Cc: net-dev

RE: Patch for adding SO_REUSEPORT socket option

2016-01-27 Thread Lu, Yingqi
addReusePortOption() to be both thread safe and package private. Please let us know your feedback and comments. Thanks, Lucy -Original Message- From: Alan Bateman [mailto:alan.bate...@oracle.com] Sent: Friday, January 15, 2016 4:29 AM To: Lu, Yingqi Cc: net-dev@openjdk.java.net; Viswanathan

RE: Patch for adding SO_REUSEPORT socket option

2016-01-14 Thread Lu, Yingqi
consistent with the rest of the code. Thanks, Lucy -Original Message- From: Alan Bateman [mailto:alan.bate...@oracle.com] Sent: Thursday, January 07, 2016 9:56 AM To: Lu, Yingqi ; Volker Simonis Cc: net-dev@openjdk.java.net; Viswanathan, Sandhya ; Kharbas, Kishor ; Aundhe, Shirish

RE: Patch for adding SO_REUSEPORT socket option

2016-01-07 Thread Lu, Yingqi
...@oracle.com] Sent: Wednesday, January 06, 2016 7:38 AM To: Lu, Yingqi ; Volker Simonis Cc: net-dev@openjdk.java.net; Viswanathan, Sandhya ; Kharbas, Kishor ; Aundhe, Shirish ; Kaczmarek, Eric Subject: Re: Patch for adding SO_REUSEPORT socket option On 05/01/2016 18:56, Lu, Yingqi wrote: >

RE: Patch for adding SO_REUSEPORT socket option

2016-01-05 Thread Lu, Yingqi
your help, Lucy -Original Message- From: Alan Bateman [mailto:alan.bate...@oracle.com] Sent: Tuesday, January 05, 2016 8:00 AM To: Lu, Yingqi ; Volker Simonis Cc: net-dev@openjdk.java.net; Viswanathan, Sandhya ; Kharbas, Kishor ; Aundhe, Shirish ; Kaczmarek, Eric Subject: Re: Patch

RE: Patch for adding SO_REUSEPORT socket option

2016-01-04 Thread Lu, Yingqi
...@openjdk.java.net] On Behalf Of Lu, Yingqi Sent: Monday, January 04, 2016 3:30 PM To: Volker Simonis ; Alan Bateman Cc: net-dev@openjdk.java.net; Viswanathan, Sandhya ; Kharbas, Kishor ; Aundhe, Shirish ; Kaczmarek, Eric Subject: RE: Patch for adding SO_REUSEPORT socket option One more

RE: Patch for adding SO_REUSEPORT socket option

2016-01-04 Thread Lu, Yingqi
: Volker Simonis [mailto:volker.simo...@gmail.com] Sent: Monday, January 04, 2016 11:26 AM To: Alan Bateman Cc: Lu, Yingqi ; Kaczmarek, Eric ; Viswanathan, Sandhya ; Kharbas, Kishor ; Aundhe, Shirish ; net-dev@openjdk.java.net Subject: Re: Patch for adding SO_REUSEPORT socket option On Mon, Jan 4, 2016

RE: Patch for adding SO_REUSEPORT socket option

2016-01-04 Thread Lu, Yingqi
, really appreciate the quick responses and helpful feedback from both of you :-) Thanks, Lucy -Original Message- From: Volker Simonis [mailto:volker.simo...@gmail.com] Sent: Monday, January 04, 2016 10:43 AM To: Alan Bateman Cc: Lu, Yingqi ; Kaczmarek, Eric ; Viswanathan, Sandhya ; Kharbas

RE: Patch for adding SO_REUSEPORT socket option

2016-01-01 Thread Lu, Yingqi
: Lu, Yingqi Cc: Viswanathan, Sandhya ; net-dev@openjdk.java.net; Kharbas, Kishor ; Aundhe, Shirish ; Kaczmarek, Eric Subject: Re: Patch for adding SO_REUSEPORT socket option On 21/12/2015 17:53, Lu, Yingqi wrote: > Hi All, > > Sorry for the late reply. Here is the link to the mo

RE: Patch for adding SO_REUSEPORT socket option

2015-12-21 Thread Lu, Yingqi
PORT to be disabled by default for both ServerSocketChannelImpl and SocketChannelImpl. Leave the feature enablement to the users. 14. Updated the copyright date. Thanks, Lucy -Original Message----- From: Lu, Yingqi Sent: Tuesday, December 08, 2015 10:25 PM To: Lu, Yingqi ; Alan Bateman ; Micha

RE: Patch for adding SO_REUSEPORT socket option

2015-12-08 Thread Lu, Yingqi
ryone. 13. Make SO_REUSEPORT to be disabled by default for both ServerSocketChannelImpl and SocketChannelImpl. Leave the feature enablement to the users. 14. Updated the copyright date. Thanks, Lucy -Original Message- From: net-dev [mailto:net-dev-boun...@openjdk.java.net] On Behalf Of

RE: Patch for adding SO_REUSEPORT socket option

2015-12-08 Thread Lu, Yingqi
Thank you very much for your help, Alan! Thanks, Lucy -Original Message- From: Alan Bateman [mailto:alan.bate...@oracle.com] Sent: Tuesday, December 08, 2015 8:46 AM To: Lu, Yingqi ; Michael McMahon ; Volker Simonis Cc: Kaczmarek, Eric ; net-dev@openjdk.java.net; Kharbas, Kishor

RE: Patch for adding SO_REUSEPORT socket option

2015-12-07 Thread Lu, Yingqi
OpenJDK9. We will surely continue working with the community to address opens/issues until it is completely ready to be merged into the source code tree. Please let us know what you think. Thanks, Lucy -Original Message- From: Lu, Yingqi Sent: Monday, December 07, 2015 1:02 PM To: '

RE: Patch for adding SO_REUSEPORT socket option

2015-12-07 Thread Lu, Yingqi
OK, will do. Thanks, Lucy -Original Message- From: Alan Bateman [mailto:alan.bate...@oracle.com] Sent: Monday, December 07, 2015 1:01 PM To: Lu, Yingqi ; Volker Simonis Cc: Michael McMahon ; Kaczmarek, Eric ; net-dev@openjdk.java.net; Kharbas, Kishor Subject: Re: Patch for adding

RE: Patch for adding SO_REUSEPORT socket option

2015-12-07 Thread Lu, Yingqi
that block and leave it to the user. Please let me know! Thanks, Lucy -Original Message- From: Volker Simonis [mailto:volker.simo...@gmail.com] Sent: Monday, December 07, 2015 10:38 AM To: Lu, Yingqi Cc: Alan Bateman ; Michael McMahon ; Kaczmarek, Eric ; net-dev@openjdk.java.net; Kharb

RE: Patch for adding SO_REUSEPORT socket option

2015-12-07 Thread Lu, Yingqi
mo...@gmail.com] Sent: Monday, December 07, 2015 9:51 AM To: Lu, Yingqi ; Alan Bateman ; Michael McMahon Cc: Kaczmarek, Eric ; net-dev@openjdk.java.net; Kharbas, Kishor Subject: Re: Patch for adding SO_REUSEPORT socket option Hi Lucy, thanks for updating the change and sorry for the late rev

RE: Patch for adding SO_REUSEPORT socket option

2015-12-07 Thread Lu, Yingqi
API is the SO_REUSEPORT option itself in StandardSocketOptions. - Michael On 07/12/15 17:04, Lu, Yingqi wrote: Hi Alan and Michael, Thank you very much for your detailed feedback. Before I start modify the code, I want to make sure I understand correctly. Regarding the following comment, do you

RE: Patch for adding SO_REUSEPORT socket option

2015-12-07 Thread Lu, Yingqi
ption/getOption should be fine. I will work on this today. Hopefully can send out an update tomorrow. Thanks, Lucy From: Alan Bateman [mailto:alan.bate...@oracle.com] Sent: Monday, December 07, 2015 7:04 AM To: Lu, Yingqi Cc: net-dev@openjdk.java.net; Kharbas, Kishor ; Kaczmarek, Eric Subjec

RE: Patch for adding SO_REUSEPORT socket option

2015-12-02 Thread Lu, Yingqi
Hi All, A quick check here. Does anyone get a chance to try the most recent patch? Any feedback and comments? Thanks, Lucy From: Lu, Yingqi Sent: Monday, November 30, 2015 11:25 PM To: Lu, Yingqi ; Volker Simonis Cc: Kaczmarek, Eric ; net-dev@openjdk.java.net; Kharbas, Kishor Subject: RE

RE: Patch for adding SO_REUSEPORT socket option

2015-11-30 Thread Lu, Yingqi
...@openjdk.java.net] On Behalf Of Lu, Yingqi Sent: Wednesday, November 25, 2015 5:12 PM To: Volker Simonis Cc: Kaczmarek, Eric ; net-dev@openjdk.java.net; Kharbas, Kishor Subject: RE: Patch for adding SO_REUSEPORT socket option Here is an update. Changes are already completed locally. All the

RE: Patch for adding SO_REUSEPORT socket option

2015-11-25 Thread Lu, Yingqi
to the Thanksgiving holiday schedule, we will send updated webrev package on Monday. Thank you all for your help and happy thanksgiving! Lucy From: Lu, Yingqi Sent: Wednesday, November 25, 2015 1:23 PM To: 'Volker Simonis' Cc: Michael McMahon ; Alan Bateman ; Kharbas, Kishor

RE: Patch for adding SO_REUSEPORT socket option

2015-11-25 Thread Lu, Yingqi
Yes, it should work! I already located the issues. Good catch! I will submit an update as soon as possible. Thanks, Lucy From: Volker Simonis [mailto:volker.simo...@gmail.com] Sent: Wednesday, November 25, 2015 12:17 PM To: Lu, Yingqi Cc: Michael McMahon ; Alan Bateman ; Kharbas, Kishor

RE: Patch for adding SO_REUSEPORT socket option

2015-11-25 Thread Lu, Yingqi
can. Thanks, Lucy -Original Message- From: Volker Simonis [mailto:volker.simo...@gmail.com] Sent: Wednesday, November 25, 2015 10:46 AM To: Lu, Yingqi Cc: Michael McMahon ; Alan Bateman ; Kharbas, Kishor ; net-dev@openjdk.java.net; Kaczmarek, Eric Subject: Re: Patch for adding

RE: Patch for adding SO_REUSEPORT socket option

2015-11-24 Thread Lu, Yingqi
_DGRAM sockets, SO_REUSEADDR allows >multiple sockets to receive UDP multicast datagrams addressed to >the bound port number. For all SOCK_DGRAM sockets bound to the >same local address, SO_REUSEADDR must be set before calling >bind(). > >S

RE: Patch for adding SO_REUSEPORT socket option

2015-11-23 Thread Lu, Yingqi
ael.x.mcma...@oracle.com] Sent: Monday, November 23, 2015 3:42 AM To: Volker Simonis ; Alan Bateman Cc: Kharbas, Kishor ; net-dev@openjdk.java.net; Lu, Yingqi Subject: Re: Patch for adding SO_REUSEPORT socket option How about the following for the apidoc in j.n.StandardSocketOptions? We can then refe

RE: Patch for adding SO_REUSEPORT socket option

2015-11-22 Thread Lu, Yingqi
, November 22, 2015 12:25 AM To: Lu, Yingqi ; Kharbas, Kishor ; net-dev@openjdk.java.net Subject: Re: Patch for adding SO_REUSEPORT socket option On 21/11/2015 02:08, Lu, Yingqi wrote: Hi Alan, Please let me know if there is anything we can do at the meantime to help. We are more than happy to

RE: Patch for adding SO_REUSEPORT socket option

2015-11-22 Thread Lu, Yingqi
this socket option * after the socket is bound has no effect. * * @see https://lwn.net/Articles/542629/";> * @see ServerSocket#setReusePort */ Thanks, Lucy From: Alan Bateman [mailto:alan.bate...@oracle.com] Sent: Sunday, November 22, 2015 12:25 AM To: Lu, Yingqi ;

RE: Patch for adding SO_REUSEPORT socket option

2015-11-20 Thread Lu, Yingqi
Hi Alan, Please let me know if there is anything we can do at the meantime to help. We are more than happy to help. Thanks, Lucy From: Alan Bateman [mailto:alan.bate...@oracle.com] Sent: Friday, November 20, 2015 2:53 PM To: Lu, Yingqi ; Kharbas, Kishor ; net-dev@openjdk.java.net; Michael

RE: Patch for adding SO_REUSEPORT socket option

2015-11-20 Thread Lu, Yingqi
set/get reuseport. The file is located at ./jdk/test/java/net/Socket/setReusePort/Basic.java Please let us know your comments and feedback! Thanks, Lucy From: net-dev [mailto:net-dev-boun...@openjdk.java.net] On Behalf Of Lu, Yingqi Sent: Thursday, November 19, 2015 12:21 PM To: Alan Bateman

RE: Patch for adding SO_REUSEPORT socket option

2015-11-19 Thread Lu, Yingqi
Hi Alan and Michael, Thank very much to both of you for your feedback. Currently, I think the only platform that does not have SO_REUSEPORT is Windows. As Michael mentioned, API allows this possibility by throwing SocketException with message "Invalid option". Older kernel that does not suppor

RE: Patch for adding SO_REUSEPORT socket option

2015-11-19 Thread Lu, Yingqi
OpenJDK so that users can take advantage of it. Thanks, Yingqi (Lucy) Lu From: Michael McMahon [mailto:michael.x.mcma...@oracle.com] Sent: Thursday, November 19, 2015 9:12 AM To: Lu, Yingqi; Kharbas, Kishor; net-dev@openjdk.java.net Subject: Re: Patch for adding SO_REUSEPORT socket option Hi

RE: Patch for adding SO_REUSEPORT socket option

2015-11-19 Thread Lu, Yingqi
Yes, that was our first version of the patch. We just completed the second version which will be uploaded soon, hopefully today. In the new version, we implemented the SO_REUSEPORT as an extended socket option (jdk.net.ExtendedSocketOptions) instead of the standard socket option. Once we are d

RE: Patch for adding SO_REUSEPORT socket option

2015-11-19 Thread Lu, Yingqi
Hi Michael, Thank you very much for your email. The version 1 of the patch is already uploaded at http://cr.openjdk.java.net/~mcberg/jdk/6432031/webrev.01/. The link is also available from https://bugs.openjdk.java.net/browse/JDK-6432031. We just completed the version 2 which implements the SO