Hi Benjamin,
As Alan stated I'm working on adding an SPI [1] which will provide a
possibility to alter how host names and IP addresses are resolved by JDK
platform.
I believe it would be possible to use this mechanism for addressing
issue described in JDK-8257080.
Best Regards,
Aleksei
[1]
Hi Daniel,
Thanks for documenting the system properties. It looks good to me.
NIT: You might want to update the copyright's last modification year to 2020
Best Regards,
Aleksei
On 06/07/2020 16:39, Daniel Fuchs wrote:
Hi,
Please find below a doc only change to document two
JDK specific JNDI/
Thank you Alan
-Aleksei
On 26/05/2020 13:50, Alan Bateman wrote:
On 26/05/2020 11:22, Aleks Efimov wrote:
Hi Alan,
Thank you for the review. I've renamed 'appendAddresses' to
'concatAddresses' per your suggestion.
And also removed 'arrangeAddresses
new webrev.
best regards,
-- daniel
On 26/05/2020 11:22, Aleks Efimov wrote:
Hi Alan,
Thank you for the review. I've renamed 'appendAddresses' to
'concatAddresses' per your suggestion.
And also removed 'arrangeAddresses' method and moved its code to
'lo
ttp://cr.openjdk.java.net/~aefimov/8244958/02
-Aleksei
On 26/05/2020 09:51, Alan Bateman wrote:
On 25/05/2020 11:47, Aleks Efimov wrote:
Hi Alan, Daniel,
Thank you for looking into this change. I've cleaned-up the fix and
the test according to your comments.
Modified fix can be viewed he
milar variables(preferIPv6Address) in InetAddress.java.
Thanks,
Vyom
On Mon, May 25, 2020 at 4:18 PM Aleks Efimov
mailto:aleksej.efi...@oracle.com>> wrote:
Hi Alan, Daniel,
Thank you for looking into this change. I've cleaned-up the fix
and the
test according to your comment
Hi Alan, Daniel,
Thank you for looking into this change. I've cleaned-up the fix and the
test according to your comments.
Modified fix can be viewed here:
http://cr.openjdk.java.net/~aefimov/8244958/01
Kind Regards,
Aleksei
On 24/05/2020 08:12, Alan Bateman wrote:
On 22/05/2020 16:45,
Hi,
The "java.net.preferIPv4Stack" and "java.net.preferIPv6Addresses" system
properties do not affect the addresses and their order, returned by the
HostsFileNameService provider that can be created by specifying
"jdk.net.hosts.file" system property.
The following fix analyses the system prope
updated to 2020.
No need for a new webrev if that's the only change!
best regards,
-- daniel
On 09/01/2020 17:17, Aleks Efimov wrote:
Hi Anuuraag,
Latest webrev: http://cr.openjdk.java.net/~aefimov/anuraaga/7006496/05/
Looks fine to me
CI is also happy
Best Regards,
Aleksei
pters);
+
return STS_SL_FOUND & STS_NS_FOUND;
}
/*
- * Initialize JNI field IDs.
+ * Initialize JNI field IDs and classes.
*/
JNIEXPORT void JNICALL
Java_sun_net_dns_ResolverConfigurationImpl_init0(JNIEnv *env,
jclass cls)
@@ -260,7 +197,7 @@
Java_sun_net_dns_ResolverConfigurationImpl_loadDNSconfig0(JNIEnv
*env, jclass cl
searchlist[0] = '\0';
nameservers[0] = '\0';
- if (loadConfig(searchlist, nameservers) != STS_ERROR) {
+ if (loadConfig(env, searchlist, nameservers) != STS_ERROR) {
/*
* Populate static fields in
sun.net.DefaultResolverConfiguration
@@ -272,8 +209,6 @@
Java_sun_net_dns_ResolverConfigurationImpl_loadDNSconfig0(JNIEnv
*env, jclass cl
obj = (*env)->NewStringUTF(env, nameservers);
CHECK_NULL(obj);
(*env)->SetStaticObjectField(env, cls, nameserversID, obj);
- } else {
- JNU_ThrowOutOfMemoryError(env, "native memory allocation
failed");
}
}
best regards,
-- daniel
On 09/01/2020 00:54, Aleks Efimov wrote:
> Got the testing results: the CI is happy with the last patch
- no JNDI
> test failures observed
>
> Kind Regards,
> Aleksei
Got the testing results: the CI is happy with the last patch - no JNDI
test failures observed
Kind Regards,
Aleksei
On 08/01/2020 18:23, Aleks Efimov wrote:
Hi Anuraag,
I've uploaded your latest patch to the following location:
http://cr.openjdk.java.net/~aefimov/anuraaga/7006496/04
Hi Anuraag,
I've uploaded your latest patch to the following location:
http://cr.openjdk.java.net/~aefimov/anuraaga/7006496/04
The local Windows build and the acquired configuration are good.
I will run you patch through our CI system and will update this thread
once I get the results.
Kind
}
- }
- /*
- * Free the adpater structure
- */
- if (adapterP) {
- free(adapterP);
+ adapter = adapter->Next;
}
+ free(adapters);
+
return STS_SL_FOUND & STS_NS_FOUND;
}
@@ -260,7 +185,7 @@
Java_sun_net_dns_ResolverConfigurationImpl_loadDNSconf
the adpater structure
- */
- if (adapterP) {
- free(adapterP);
+ adapter = adapter->Next;
}
+ free(adapters);
+
return STS_SL_FOUND & STS_NS_FOUND;
}
@@ -260,7 +189,7 @@
Java_sun_net_dns_ResolverConfigurationImpl_loadDNSconfig0(JNIEnv *env,
jclass cl
searchlist[0] = '
2/12/2019 13:04, Aleks Efimov wrote:
Hi Anuraag,
I've submited your patch to our CI system and I'm observing a bunch of
NPE failures with such stack trace:
java.lang.NullPointerException
at
java.base/sun.net.dns.ResolverConfigurationImpl.allocateListForDelimitedString(ResolverConfigura
Hi Anuraag,
I've submited your patch to our CI system and I'm observing a bunch of
NPE failures with such stack trace:
java.lang.NullPointerException
at
java.base/sun.net.dns.ResolverConfigurationImpl.allocateListForDelimitedString(ResolverConfigurationImpl.java:108)
at
java.base/sun.
trick
On 02/09/2019 14:29, Aleks Efimov wrote:
Hey Patrick,
Looks good to me!
You could utilize jdk.test.lib.Platform::isWindows from test library
to check if the test is running on Windows platform.
With Best Regards,
Aleksei
On 29/08/2019 16:01, Patrick Concannon wrote:
Hi,
Would
Hey Patrick,
Looks good to me!
You could utilize jdk.test.lib.Platform::isWindows from test library to
check if the test is running on Windows platform.
With Best Regards,
Aleksei
On 29/08/2019 16:01, Patrick Concannon wrote:
Hi,
Would it be possible to have my fix for JDK-8230132 reviewe
Hi Julia,
Minor comments:
test/jdk/java/net/httpclient/LineStreamsAndSurrogatesTest.java#2:
Could you please add the missing comma after the last modification year,
i.e. "2018, 2019,"
test/jdk/java/net/httpclient/LineSubscribersAndSurrogatesTest.java#2:
Same stuff: "2018, 2019,"
Otherwise loo
Thanks Chris!
With Best Regards,
Aleksei
On 12/08/2019 18:17, Chris Hegarty wrote:
On 12 Aug 2019, at 18:14, Aleks Efimov wrote:
Hi Daniel, Chris,
The second version of the fix that addresses your on-line and off-line
suggestions and comments could be viewed here:
http
Hi Daniel, Chris,
The second version of the fix that addresses your on-line and off-line
suggestions and comments could be viewed here:
http://cr.openjdk.java.net/~aefimov/8228508/01/
Summary of the changes:
1. Usages of com/sun/net/httpserver/EchoHandler were replaced with newly
added SmokeT
Daniel, Chris,
Thanks for your reviews!
With Best Regards,
Aleksei
On 08/08/2019 11:59, Daniel Fuchs wrote:
Thanks Aleksei!
Looks good.
-- daniel
On 07/08/2019 19:46, Aleks Efimov wrote:
Hi Daniel,
HandleContentTypeWithAttrs correction - removed bind and used
three-args constructor
Thanks Vyom!
With Best Regards,
Aleksei
On 07/08/2019 06:45, Vyom Tewari26 wrote:
looks good to me.
Thanks,
Vyom
- Original message -
From: Aleks Efimov
Sent by: "net-dev"
To: net-dev
Cc:
Subject: [teststabilization] RFR: 8225430: Replac
Hi Daniel,
HandleContentTypeWithAttrs correction - removed bind and used three-args
constructor instead - looks much nicer.
The webrev location is same: http://cr.openjdk.java.net/~aefimov/8225430/01
Best Regards,
Aleksei
On 07/08/2019 17:09, Aleks Efimov wrote:
Hi Daniel,
Thank you for the
anks I will keep that trick in mind and apply it if test fails again.
On 06/08/2019 15:35, Aleks Efimov wrote:
Hi,
Please help to review few test fixes which address intermittent
networking failures:
http://cr.openjdk.java.net/~aefimov/8225430/00
JBS:
https://bugs.openjdk.java.net/browse/JD
Hello,
Please help to review the change that fixes
java/net/httpclient/SomeTest.java timeout issue:
http://cr.openjdk.java.net/~aefimov/8228508/00
The test now uses the 'com/sun/net/httpclient/EchoHandler.java' test class.
The test fails before the fix on Windows 7 and passes after. No mach5
Hi,
Please help to review few test fixes which address intermittent
networking failures:
http://cr.openjdk.java.net/~aefimov/8225430/00
JBS:
https://bugs.openjdk.java.net/browse/JDK-8225430
The following tests have been marked with @intermittent keyword:
java/net/DatagramSocket/ReuseAddressTe
Thanks for the review Brian. I will help Patrick to push the change
Best Regards,
Aleksei
On 25/06/2019 15:57, Patrick wrote:
Ok, thanks Brian.
Will change before pushing.
On 6/25/19 3:51 PM, Brian Burkhalter wrote:
Hi Patrick,
Looks OK to me except the 2017 copyright year in URLStreamHandl
lines.
Sometimes a convenient way to do that is to create
a server socket without any arguments and then bind it.
This has the additional advantage of avoiding the 3-args
constructor which Alan doesn't like ;-)
best regards,
-- daniel
On 23/05/2019 15:01, Aleks Efimov wrote:
Hi,
Please help
Hi,
Please help to review another part of test fixes to address intermittent
networking failures:
http://cr.openjdk.java.net/~aefimov/8224035/00
JBS:
https://bugs.openjdk.java.net/browse/JDK-8224035
With Best Regards,
Aleksei
Hi Daniel,
The changes looks good to me!
Best Regards,
Aleksei
On 16/05/2019 13:23, Daniel Fuchs wrote:
Hi,
Please find below a fix for [1]:
8223856: Replace wildcard address with loopback or local host in
tests - part 8
http://cr.openjdk.java.net/~dfuchs/webrev_8223856/webrev.00/i
Vyom, Daniel,
Thanks for your reviews!
Best Regards,
Aleksei
On 15/05/2019 18:51, Vyom Tiwari wrote:
Hi Aleks,
latest changes looks good to me .
Thanks,
Vyom
On Wed, May 15, 2019 at 11:12 PM Aleks Efimov
mailto:aleksej.efi...@oracle.com>> wrote:
Hi Daniel,
Thanks for the
I've broke the long lines in few places. Will push the changes shortly.
With Best Regards,
Aleksei
On 15/05/2019 17:59, Daniel Fuchs wrote:
Hi Aleksei,
On 15/05/2019 17:07, Aleks Efimov wrote:
Hi,
Another part of test fixes to address intermittent networking test
failures can be viewed h
Hi,
Another part of test fixes to address intermittent networking test
failures can be viewed here:
http://cr.openjdk.java.net/~aefimov/8223798/00/
Could I please ask for the help to review it?
JBS:
https://bugs.openjdk.java.net/browse/JDK-8223798
With Best Regards,
Aleksei
pty() || file.startsWith("!");
URI httpURI = URIBuilder.newBuilder()
.scheme("http")
.loopback()
.port(port)
.path(jar);
return new URL("jar:" + httpURI + file);
}
best regards,
-- daniel
+ server = HttpServer.create();
}
public void start() throws IOException {
- server.bind(new InetSocketAddress(0), 0);
+ server.bind(new InetSocketAddress(address, 0), 0);
best regards,
-- daniel
On 13/05/2019 16:07, Aleks Efimov wrote:
Hi,
Please help to
Hi,
Please help to review another part of test fixes to address
intermittent networking test failures.
Webrev:
http://cr.openjdk.java.net/~aefimov/8223638/00/index.html
JBS:
https://bugs.openjdk.java.net/browse/JDK-8223638
With Best Regards,
Aleksei
Thank you Daniel!
On 10/05/2019 14:16, Daniel Fuchs wrote:
Looks god to me!
cheers,
-- daniel
On 10/05/2019 13:24, Aleks Efimov wrote:
Thank you for the review Daniel!
I've added the suggested comment to ServerSocket_accept + fixed the
white-spaces.
About ChunkedErrorStream.java:
line 153. This test now uses the external
address instead of using the loopback but I guess that's OK.
Otherwise looks good!
best regards,
-- daniel
On 09/05/2019 19:42, Aleks Efimov wrote:
Hi,
Please help to review another part of test fixes to address
intermittent fail
Hi,
Please help to review another part of test fixes to address intermittent
failures.
Webrev:
http://cr.openjdk.java.net/~aefimov/8223465/00/
JBS:
https://bugs.openjdk.java.net/browse/JDK-8223465
With Best Regards,
Aleksei
40 matches
Mail list logo
