Hi Alan,
Thank you for the review. I've renamed 'appendAddresses' to
'concatAddresses' per your suggestion.
And also removed 'arrangeAddresses' method and moved its code to
'lookupAllHostAddr'.
Webrev with new version can be viewed here:
http://cr.openjdk.java.net/~aefimov/8244958/02
-Aleksei
On 26/05/2020 09:51, Alan Bateman wrote:
On 25/05/2020 11:47, Aleks Efimov wrote:
Hi Alan, Daniel,
Thank you for looking into this change. I've cleaned-up the fix and
the test according to your comments.
Modified fix can be viewed here:
http://cr.openjdk.java.net/~aefimov/8244958/01
Thanks for the update, I think this version looks okay. I suspect if I
were doing this then I wouldn't have created the arrangeAddresses
methods as the term "arrange" is a bit unusual here. Also I think I
would use "concat" instead of append as the method concatenates the
two lists. Style-wise I think it would be cleaner to move the
declaration of hostsFile to after the constants, that will put it
closer to the constructor that initializes it.
-Alan.
