Re: RFR: 8280494: (D)TLS signature schemes [v3]

2022-01-28 Thread Xue-Lei Andrew Fan
On Fri, 28 Jan 2022 01:05:22 GMT, Bernd wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Enrich the APIs specification > > src/java.base/share/classes/sun/security/ssl/SSLConfiguration.java line 410: > >> 408

Re: RFR: 8280494: (D)TLS signature schemes [v3]

2022-01-28 Thread Xue-Lei Andrew Fan
> This update is to support signature schemes customization for individual > (D)TLS connection. Please review the CSR as well: > CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 > RFE: https://bugs.openjdk.java.net/browse/JDK-8280494 Xue-Lei Andrew Fan has updated the pull request increment

Re: RFR: 8280494: (D)TLS signature schemes [v2]

2022-01-28 Thread Xue-Lei Andrew Fan
On Fri, 28 Jan 2022 00:58:37 GMT, Bernd wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Copyright correction > > src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 763: > >> 761: >> 762:

Re: RFR: 8280494: (D)TLS signature schemes [v2]

2022-01-28 Thread Xue-Lei Andrew Fan
On Fri, 28 Jan 2022 15:26:56 GMT, Sean Mullan wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Copyright correction > > src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 94: > >> 92: >> 93:

Re: RFR: 8280494: (D)TLS signature schemes [v2]

2022-01-28 Thread Xue-Lei Andrew Fan
On Fri, 28 Jan 2022 00:54:53 GMT, Bernd wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Copyright correction > > src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 92: > >> 90: private int

Re: RFR: 8280494: (D)TLS signature schemes [v2]

2022-01-28 Thread Xue-Lei Andrew Fan
On Fri, 28 Jan 2022 15:50:49 GMT, Jamil Nimeh wrote: >> You should also define the interaction with the system properties (probably >> as an @implNote). Does `getSignatureSchemes` ever return the value of the >> system properties? Does the `setSignatureSchemes` API always override the >> prope

Re: RFR: 8280494: (D)TLS signature schemes [v2]

2022-01-28 Thread Xue-Lei Andrew Fan
On Fri, 28 Jan 2022 15:17:25 GMT, Sean Mullan wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Copyright correction > > src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 709: > >> 707: *

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos [v13]

2022-01-28 Thread Daniel Fuchs
On Fri, 28 Jan 2022 16:58:55 GMT, Michael McMahon wrote: >> Hi, >> >> This change adds Channel Binding Token (CBT) support to HTTPS >> (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, >> Kerberos) authentication scheme. When enabled, the implementation >> preemptively inclu

Re: RFR: 8279842: HTTPS Channel Binding support for Java GSS/Kerberos [v13]

2022-01-28 Thread Michael McMahon
> Hi, > > This change adds Channel Binding Token (CBT) support to HTTPS > (java.net.HttpsURLConnection) when used with the Negotiate (SPNEGO, Kerberos) > authentication scheme. When enabled, the implementation preemptively includes > a CBT with authentication requests over Kerberos. The feature

Re: RFR: JDK-8280498: [aix]: jdk/java/net/Inet4Address/PingThis.java fails

2022-01-28 Thread Michael Felt
On Mon, 10 Jan 2022 15:56:07 GMT, Michael Felt wrote: > with IP "0.0.0.0" > > - it either does nothing and ping fails, or, in some virtual environments > is treated as the default route address. > - IPv6 support for ::1 is available since 1977; however, ::0 is not accepted > as a vaild psuedo IP

Re: RFR: 8280494: (D)TLS signature schemes [v2]

2022-01-28 Thread Jamil Nimeh
On Fri, 28 Jan 2022 15:44:16 GMT, Sean Mullan wrote: >> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 710: >> >>> 708: * Signature Schemes section of the Java Cryptography >>> 709: * Architecture Standard Algorithm Name Documentation, and may also >>> 710: * in

Re: RFR: 8280494: (D)TLS signature schemes [v2]

2022-01-28 Thread Sean Mullan
On Fri, 28 Jan 2022 15:17:28 GMT, Sean Mullan wrote: >> Xue-Lei Andrew Fan has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Copyright correction > > src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 710: > >> 708: *

Re: RFR: JDK-8280498: [aix]: jdk/java/net/Inet4Address/PingThis.java fails

2022-01-28 Thread Michael Felt
On Mon, 10 Jan 2022 15:56:07 GMT, Michael Felt wrote: > with IP "0.0.0.0" > > - it either does nothing and ping fails, or, in some virtual environments > is treated as the default route address. > - IPv6 support for ::1 is available since 1977; however, ::0 is not accepted > as a vaild psuedo IP

Re: RFR: 8280494: (D)TLS signature schemes [v2]

2022-01-28 Thread Sean Mullan
On Fri, 28 Jan 2022 07:21:56 GMT, Xue-Lei Andrew Fan wrote: >> This update is to support signature schemes customization for individual >> (D)TLS connection. Please review the CSR as well: >> CSR: https://bugs.openjdk.java.net/browse/JDK-8280495 >> RFE: https://bugs.openjdk.java.net/browse/JDK-

RE: RFR: JDK-8280498: [aix]: jdk/java/net/Inet4Address/PingThis.java fails

2022-01-28 Thread Michael Felt
-Original Message- From: net-dev On Behalf Of Michael McMahon Sent: Friday, 28 January 2022 16:14 To: net-dev@openjdk.java.net Subject: Re: RFR: JDK-8280498: [aix]: jdk/java/net/Inet4Address/PingThis.java fails On Fri, 28 Jan 2022 14:46:32 GMT, Michael Felt wrote: >> If it defeats t

Re: RFR: JDK-8280498: [aix]: jdk/java/net/Inet4Address/PingThis.java fails

2022-01-28 Thread Daniel Fuchs
On Fri, 28 Jan 2022 15:11:04 GMT, Michael McMahon wrote: >>> Or is it possible to change the implementation on AIX so the test passes >>> without change? >> >> * Digging into the java guts to map "0.0.0.0" to "127.0.0.1" seems too far >> to me - as I believe interfaces are not suppossed to be

Re: RFR: JDK-8280498: [aix]: jdk/java/net/Inet4Address/PingThis.java fails

2022-01-28 Thread Michael McMahon
On Fri, 28 Jan 2022 14:46:32 GMT, Michael Felt wrote: >> If it defeats the purpose, then it needs to be skipped. >> >> * When I was trying to understand the test, it seemed to be that it >> _assumed_ that "0.0.0.0" was 'converted' to 127.0.0.1. >> * If there is an international standard (ISO, P

Re: RFR: JDK-8280498: [aix]: jdk/java/net/Inet4Address/PingThis.java fails

2022-01-28 Thread Michael Felt
On Fri, 28 Jan 2022 14:37:00 GMT, Michael Felt wrote: >> Or is it possible to change the implementation on AIX so the test passes >> without change? > > If it defeats the purpose, then it needs to be skipped. > > * When I was trying to understand the test, it seemed to be that it _assumed_ > t

Re: RFR: JDK-8280498: [aix]: jdk/java/net/Inet4Address/PingThis.java fails

2022-01-28 Thread Michael Felt
On Fri, 28 Jan 2022 14:30:01 GMT, Michael McMahon wrote: >> test/jdk/java/net/Inet4Address/PingThis.java line 62: >> >>> 60: else { >>> 61: addrs.add("0.0.0.0"); >>> 62: } >> >> This conflicts with the purpose of the test. Maybe this test needs to be >>

Re: RFR: JDK-8280498: [aix]: jdk/java/net/Inet4Address/PingThis.java fails

2022-01-28 Thread Michael Felt
On Fri, 28 Jan 2022 14:26:51 GMT, Thomas Stuefe wrote: > > Does the label being removed mean the site knows I now have an _oca_? > > Yes. The oca label was removed by the bot. It also did sent the mail to the > associated ML > (https://mail.openjdk.java.net/pipermail/net-dev/2022-January/01738

Re: RFR: JDK-8280498: [aix]: jdk/java/net/Inet4Address/PingThis.java fails

2022-01-28 Thread Michael McMahon
On Fri, 28 Jan 2022 14:28:43 GMT, Alan Bateman wrote: >> with IP "0.0.0.0" >> >> - it either does nothing and ping fails, or, in some virtual environments >> is treated as the default route address. >> - IPv6 support for ::1 is available since 1977; however, ::0 is not accepted >> as a vaild psu

Re: RFR: JDK-8280498: [aix]: jdk/java/net/Inet4Address/PingThis.java fails

2022-01-28 Thread Thomas Stuefe
On Fri, 28 Jan 2022 13:52:12 GMT, Michael Felt wrote: > Does the label being removed mean the site knows I now have an _oca_? Yes. The oca label was removed by the bot. It also did sent the mail to the associated ML (https://mail.openjdk.java.net/pipermail/net-dev/2022-January/017386.html). Y

Re: RFR: JDK-8280498: [aix]: jdk/java/net/Inet4Address/PingThis.java fails

2022-01-28 Thread Alan Bateman
On Mon, 10 Jan 2022 15:56:07 GMT, Michael Felt wrote: > with IP "0.0.0.0" > > - it either does nothing and ping fails, or, in some virtual environments > is treated as the default route address. > - IPv6 support for ::1 is available since 1977; however, ::0 is not accepted > as a vaild psuedo IP

RE: Pull Request: 7013: AIX: InetAddress.getByName(addr) does not work as expected

2022-01-28 Thread Michael Felt
Hi, I went to the ticket you opened – and it seems I need to do something additional – as I cannot login to comment (should I need to). Thx again for opening the ticket. From: Thomas Stüfe Sent: Saturday, 22 January 2022 11:23 To: Alan Bateman Cc: Michael Felt ; ppc-aix-port-dev ; net-

Re: RFR: JDK-8280498: [aix]: jdk/java/net/Inet4Address/PingThis.java fails

2022-01-28 Thread Christoph Langer
On Thu, 20 Jan 2022 12:59:25 GMT, Michael Felt wrote: >> with IP "0.0.0.0" >> >> - it either does nothing and ping fails, or, in some virtual environments >> is treated as the default route address. >> - IPv6 support for ::1 is available since 1977; however, ::0 is not accepted >> as a vaild psu

Re: RFR: JDK-8280498: [aix]: jdk/java/net/Inet4Address/PingThis.java fails

2022-01-28 Thread Thomas Stuefe
On Thu, 20 Jan 2022 12:59:25 GMT, Michael Felt wrote: >If above is sufficient for the JBS issue - fantistic - otherwise I'll try and get something less chatty from code. That would be nice. >> * and of course, we need you to sign the OCA. > where is that? https://openjdk.java.net/contribute/ o

Re: RFR: JDK-8280498: [aix]: jdk/java/net/Inet4Address/PingThis.java fails

2022-01-28 Thread Michael Felt
On Mon, 10 Jan 2022 15:56:07 GMT, Michael Felt wrote: > with IP "0.0.0.0" > > - it either does nothing and ping fails, or, in some virtual environments > is treated as the default route address. > - IPv6 support for ::1 is available since 1977; however, ::0 is not accepted > as a vaild psuedo IP

Re: RFR: JDK-8280498: [aix]: jdk/java/net/Inet4Address/PingThis.java fails

2022-01-28 Thread Thomas Stuefe
On Mon, 10 Jan 2022 15:56:07 GMT, Michael Felt wrote: > with IP "0.0.0.0" > > - it either does nothing and ping fails, or, in some virtual environments > is treated as the default route address. > - IPv6 support for ::1 is available since 1977; however, ::0 is not accepted > as a vaild psuedo IP

RFR: JDK-8280498: [aix]: jdk/java/net/Inet4Address/PingThis.java fails

2022-01-28 Thread Michael Felt
with IP "0.0.0.0" - it either does nothing and ping fails, or, in some virtual environments is treated as the default route address. - IPv6 support for ::1 is available since 1977; however, ::0 is not accepted as a vaild psuedo IPv6 address. '::1' must be used instead. ping: bind: The socket name

RFR: 8280868: LineBodyHandlerTest.java creates and discards too many clients

2022-01-28 Thread Daniel Fuchs
Please find enclosed a simple test fix for: 8280868: LineBodyHandlerTest.java creates and discards too many clients The LineBodyHandlerTest.java creates and discards many clients (64). The test has been observed failing intermittently on some systems (Windows 10) while trying to open the client's