On Fri, 28 Jan 2022 14:30:01 GMT, Michael McMahon <micha...@openjdk.org> wrote:

>> test/jdk/java/net/Inet4Address/PingThis.java line 62:
>> 
>>> 60:             else {
>>> 61:                 addrs.add("0.0.0.0");
>>> 62:             }
>> 
>> This conflicts with the purpose of the test. Maybe this test needs to be 
>> skipped on AIX?
>
> Or is it possible to change the implementation on AIX so the test passes 
> without change?

If it defeats the purpose, then it needs to be skipped.

* When I was trying to understand the test, it seemed to be that it _assumed_ 
that "0.0.0.0" was 'converted' to 127.0.0.1.
* If there is an international standard (ISO, POSIX) that states 0.0.0.0 needs 
to be treated as 127.0.0.1 - AIX clearly has a bug. Same for `::)` mapping to 
`::1` - AIX doesn't do that IPv4 (now), and, afaik, never has for IPv6.
* While testing I also saw that AIX reacts differently (error message iirc) 
when passed NULL, whereas it behaves "as expected" when given a null-string `""`
* FYI: Adoptium has put this test on the excluded list, but if a fix using `""` 
rather than "0.0.0.0" and/or "::1" rather than "::0", the test should perhaps 
state the exclusion as a comment in the code, and return immediately, as it 
does for Windows.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7013

Reply via email to