Hi Vladimir,
That looks good. Give me time to send that to our test system
and I'll report back.
best regards,
-- daniel
On 21/05/2020 18:07, Ivanov, Vladimir A wrote:
Thanks Daniel,
the exception was updated. Could you please review:
Bug ID:https://bugs.openjdk.java.net/browse/JDK-8245569
We
Hi Vladimir,
The changes look good to me. I imported your patch and sent it
to our test systems. Please wait until I report back that all
is clear before pushing.
best regards,
-- daniel
On 21/05/2020 19:10, Ivanov, Vladimir A wrote:
Hello everyone,
seems, the test java/net/SocketOption/Afte
Hello everyone,
seems, the test java/net/SocketOption/AfterClose.java was updated in parallel
with SO_INCOMING_NAPI_ID changes.
To support new option this test should be updated.
Could you please review changes at
http://cr.openjdk.java.net/~sviswanathan/Vladimir/8245517/webrev.00/ ?
Thanks, Vla
Thanks Daniel,
the exception was updated. Could you please review:
Bug ID: https://bugs.openjdk.java.net/browse/JDK-8245569
Webrev: http://cr.openjdk.java.net/~sviswanathan/Vladimir/8245569/webrev.00/
Thanks, Vladimir
-Original Message-
From: Viswanathan, Sandhya
Sent: Thursday, May 21
Hi Daniel,
Vladimir just pointed our that I missed pushing the SO_INCOMING_NAPI_ID tests
(forgot to do hg add).
I will create a separate JBS entry for tests. Vladimir could do this change as
part of that.
Best Regards,
Sandhya
-Original Message-
From: net-dev On Behalf Of Daniel Fuchs
Hi Vladimir,
On 14/05/2020 22:50, Ivanov, Vladimir A wrote:
Thanks a lot Daniel! I missed these double checks.
Updated webrev may be reviewed as http://cr.openjdk.java.net/~sviswanathan/Vladimir/8243099/webrev.14
I use only one condition for the 'if' in the 'startup' method while kernel shoul
Hi Jay,
A couple of comments. There are other places in SocketPermission which
assume that the addresses array only contains one element, eg getCanonName()
assumes there is only one such name. The fix would have to account for
the possibility
of multiple canonical names (obtained from DNS rever
Hello,
Please review the fix and Jtreg testcase to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8243376
The proposed changeset is hosted at:
http://cr.openjdk.java.net/~vtewari/8243376/webrev/index.html
The scenario is:
- Some specified target hostname resolves to two IP addres
