Hi Daniel/Michael,
Please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8237858/webrev0.1/index.html) where i did the similar changes in (aix_close,solaris_close,bsd_close).c
files as well.
Thanks,
Vyom
- Original message -From: Michael McMahon Sent by: "net-dev" To: Daniel
Hi Daniel,
In PlainSocketImpl.socketAccept() we are taking care of 0 timeout as follows.
/* passing a timeout of 0 to poll will return immediately, but in the case of ServerSocket 0 means infinite. */ if (timeout <= 0) { ret = NET_Timeout(env, fd, -1, 0); } el
On 10/03/2020 18:32, Patrick Concannon wrote:
Hi Alan and Daniel,
Thanks for the feedback.
I've changed the test to be DatagramChannel specific, and it now
checks getOption(SO_SNDBUF) for both IPv4 and IPv6. You can find the
updated webrev below.
http://cr.openjdk.java.net/~pconcannon/8239
Hi Alan and Daniel,
Thanks for the feedback.
I've changed the test to be DatagramChannel specific, and it now checks
getOption(SO_SNDBUF) for both IPv4 and IPv6. You can find the updated
webrev below.
http://cr.openjdk.java.net/~pconcannon/8239355/webrevs/webrev.02
Kind regards,
Patrick
As it happens, I'm not sure that NET_Timeout is ever called with timeout
= 0.
A zero value for the socket option means block forever and there is no
support
for polling in the API.
- Michael.
On 10/03/2020 18:21, Daniel Fuchs wrote:
Hi Vyom,
Now I have second thoughts. The documentation of
Hi Vyom,
Now I have second thoughts. The documentation of poll(2) says:
int poll(struct pollfd *fds, nfds_t nfds, int timeout);
[...]
Specifying a negative value in timeout means an infinite
timeout.
Specifying a timeout of zero causes poll() to return
Hi Daniel,
Thanks for review and running all tests, In past we(i am the culprit) removed the "if(timeout > 0) {" condition by mistake. This check is to make sure that if the timeout set only then we do all other time calculation but somehow it was not very clear by reading the code.
NET_Timeou
The change looks okay to me. Though the comment about the -1 case also
applies
if timeout is 0. The behavior is still okay in that case, but the
comment should acknowledge that,
however unlikely it is to occur.
- Michael.
On 10/03/2020 16:37, Daniel Fuchs wrote:
Hi Vyom,
I have sent your pro
Hi Vyom,
I have sent your proposed fix to our test system and observed no
regression. I agree your proposed changes seem to address the
issue adequately. However, I'd like to hear a second opinion on the
possible side effects of this fix, since NET_Timeout may be called
at many other places.
I s
Julia,
> On 5 Mar 2020, at 13:50, Julia Boes wrote:
>
> Hi,
>
> Please see this fix that adds support for non-default file systems to the
> HttpClient. More specifically, the change is in
> RequestPublishers.FilePublisher where an UnsupportedOperationException is
> thrown if a java.io.File c
Hi John,
Looks good to me.
best regards,
-- daniel
On 02/03/2020 08:08, sha.ji...@oracle.com wrote:
Hi,
java/net/httpclient/whitebox/java.net.http/jdk/internal/net/http/FlowTest.java
would not use a specific TLS protocol, instead just use the default TLS
protocol, exactly TLSv1.3 now.
dif
11 matches
Mail list logo
