On 10/03/2020 18:32, Patrick Concannon wrote:
Hi Alan and Daniel,
Thanks for the feedback.
I've changed the test to be DatagramChannel specific, and it now
checks getOption(SO_SNDBUF) for both IPv4 and IPv6. You can find the
updated webrev below.
http://cr.openjdk.java.net/~pconcannon/8239355/webrevs/webrev.02
Thanks for adding a test for getOption(SO_SNDBUF). That test
(testGetOption) should be checking that SO_SNDBUF is >= expected value
as it's okay for net.inet.udp.maxdgram to have a larger than what the
test expects.
testSend sends to the loopback address but I think we need this test to
send datagrams on the network (sending to the loopback is okay too but I
think you want this test to send a datagram on the network because we
want fragmentation on the network(.
The java.net.preferIPv6Addresses system property is about configuring
the order of name service lookup. These runs shouldn't impact anything
here, dual and preferIPv4Stack=true should be all that is needed.
A minor nit is that we should probably find a name for the test that is
consistent with the other tests in this area. Something like
LargeDatagram or MinSendBufferSize is okay.
-Alan
