Hi Alan and Daniel,
Thanks for the feedback.
I've changed the test to be DatagramChannel specific, and it now checks
getOption(SO_SNDBUF) for both IPv4 and IPv6. You can find the updated
webrev below.
http://cr.openjdk.java.net/~pconcannon/8239355/webrevs/webrev.02
Kind regards,
Patrick
On 09/03/2020 20:03, Alan Bateman wrote:
On 09/03/2020 18:08, Daniel Fuchs wrote:
Hi Alan,
On 09/03/2020 17:01, Alan Bateman wrote:
On 09/03/2020 12:39, Patrick Concannon wrote:
bug: https://bugs.openjdk.java.net/browse/JDK-8239355
webrev:
http://cr.openjdk.java.net/~pconcannon/8239355/webrevs/webrev.00/index.html
This is a change to the DatagramChannel implementation. I guess I
assumed there would be a DatagramChannel test that checked that
getOption(SO_SNDBUF) returned a minimum value for both the IPv4 and
IPv6 cases.
+1. It's so obvious I didn't think of it when Patrick & I discussed
the test.
Okay, I think that would be useful to add as a macOS specific test.
Also we can test DatagramChannel sending datagrams of maximum size on
all platforms (doesn't need to be macOS specific). We probably don't
need a DatagramSocket test for this change as it doesn't touch that
code (and the code in PDSI isn't quite right).
-Alan
