Re: [PATCH] 7006496: Use modern Windows API to retrieve OS DNS servers

2019-12-02 Thread Aleks Efimov
Hey Anuraag, I've looked at the failures and I believe that your second patch accidentally removed 'loadDNSconfig0()' native call. Putting it back to src/java.base/windows/classes/sun/net/dns/ResolverConfigurationImpl.java:145 resolves all these failures. -Aleksei On 02/12/2019 13:04, Alek

Re: RFR: 8235141: Specify the required standard socket options for the socket types in the java.net package

2019-12-02 Thread Alan Bateman
On 02/12/2019 15:36, Daniel Fuchs wrote: Hi, Please find below a doc-only fix that specifies, for each socket type in the java.net package, the minimal set of option that that type supports. The doc changes have been largely imported from corresponding types in java.nio.channels. 8235141: Spe

RFR: 8235141: Specify the required standard socket options for the socket types in the java.net package

2019-12-02 Thread Daniel Fuchs
Hi, Please find below a doc-only fix that specifies, for each socket type in the java.net package, the minimal set of option that that type supports. The doc changes have been largely imported from corresponding types in java.nio.channels. 8235141: Specify the required standard socket options

Re: RFR: 8231516: network QuickAckTest.java failed due to "SocketException: maximum number of DatagramSockets reached"

2019-12-02 Thread Roger Riggs
I'm not sure its worth the time, but on failure, a combination of netstat and lsof could identify the consumers of the sockets. Roger On 11/29/19 2:49 AM, Alan Bateman wrote: On 22/11/2019 16:35, Chris Hegarty wrote: : QuickAckTest only creates one DatagramSocket and one MulticastSocket, so

Re: [PATCH] 7006496: Use modern Windows API to retrieve OS DNS servers

2019-12-02 Thread Aleks Efimov
Hi Anuraag, I've submited your patch to our CI system and I'm observing a bunch of NPE failures with such stack trace: java.lang.NullPointerException     at java.base/sun.net.dns.ResolverConfigurationImpl.allocateListForDelimitedString(ResolverConfigurationImpl.java:108)     at java.base/sun.