On 02/12/2019 15:36, Daniel Fuchs wrote:
Hi,
Please find below a doc-only fix that specifies, for each
socket type in the java.net package, the minimal set of option
that that type supports.
The doc changes have been largely imported from corresponding
types in java.nio.channels.
8235141: Specify the required standard socket options for the
socket types in the java.net package
https://bugs.openjdk.java.net/browse/JDK-8235141
webrev:
http://cr.openjdk.java.net/~dfuchs/webrev_8235141/webrev.00/
A few suggestion for wording:
"offers some convenience methods to get and set some commonly used options"
-> "defines convenience methods to set and get several socket options".
"However, socket options can be more generally configured using the
setOption method"
-> "This class also defines the setOption and getOption methods to set
and query socket options".
The tables looks right.
The RequiredOptions appears to overlap significantly with existing
tests, e.g. test/jdk/java/nio/channels already has a SocketOptionTests
test for each of the network channel types.
-Alan
