On 27/05/2019 19:37, Chris Hegarty wrote:
:
Thanks, both issues resolved in-place.
Looks good.
:
ServerSocket options are mentioned here as that is the behaviour in
the current shipping release ( to return the server related options ), not
the client related ones, see
http://hg.openjdk.
Alan,
> On 27 May 2019, at 17:11, Alan Bateman wrote:
>
> On 27/05/2019 16:48, Chris Hegarty wrote:
>>
>>
>> Updated webrev:
>> https://cr.openjdk.java.net/~chegar/8224477/webrev.04/
> This version looks good.
>
> A minor nit is that there's a blank line added to SocketChannelImpl.setOption
On 27/05/2019 16:48, Chris Hegarty wrote:
Updated webrev:
https://cr.openjdk.java.net/~chegar/8224477/webrev.04/
This version looks good.
A minor nit is that there's a blank line added to
SocketChannelImpl.setOption that separates a comment from the code that
it documents, I assume this i
Alan,
On 27/05/2019 12:50, Alan Bateman wrote:
..
This looks a good cleanup. There may be an argument to have the default
implementations of get/setOption throw NPE when name is null.
Good point. Done.
Does isServer need to be package-private? I didn't spot any usages in
PSI/PDSI.
Not yet
On 24/05/2019 19:35, Daniel Fuchs wrote:
Hi,
Please find a patch that fixes a batch of tests that have been
observed to fail intermittently. Usual symptoms, usual probable
cause, and usual recipe:
8224761: Replace wildcard address with loopback or local host in
tests - part 12
http
On 27/05/2019 11:48, Chris Hegarty wrote:
This next iteration addresses all of Alan's comments and suggestions.
Additionally, while here we can take the opportunity to cleanup the spec
inconsistencies of the getOption/setOption methods across the socket
impls. The current default implementation
[adding nio-dev]
On 23/05/2019 18:19, Arthur Eubanks wrote:
bug: https://bugs.openjdk.java.net/browse/JDK-8224645
webrev: http://cr.openjdk.java.net/~aeubanks/8224645/webrev.00/
Hi Arthur,
I would suggest three things:
1. replace `if (hasNext()) {` with `while (hasNext()) {`
2. add
On 23/05/2019 18:19, Arthur Eubanks wrote:
bug: https://bugs.openjdk.java.net/browse/JDK-8224645
webrev: http://cr.openjdk.java.net/~aeubanks/8224645/webrev.00/
Hi Arthur,
I would suggest three things:
1. replace `if (hasNext()) {` with `while (hasNext()) {`
2. add a counter, and inc
I ran that changed test on Solaris many times. Those runs included some of the
machines on which the previous incarnation failed. The runs were successful.
Other platforms looked fine too.
Looks good.
> On 23 May 2019, at 18:19, Arthur Eubanks wrote:
>
> bug: https://bugs.openjdk.java.net/brows
On 24/05/2019 08:28, Alan Bateman wrote:
On 23/05/2019 17:32, Chris Hegarty wrote:
...
This next iteration addresses all of Alan's comments and suggestions.
Additionally, while here we can take the opportunity to cleanup the spec
inconsistencies of the getOption/setOption methods across the
Thanks Vyom,
On 27/05/2019 10:32, Vyom Tewari26 wrote:
Overall changes looks good to me, in "B6726695.java" you have used
".loopback()" which is not consistent with the other similar URL
construction changes although i can see that "ProxyTest.java" uses
".loopback()" as well.
Yes consistency
Hi Daniel,
Overall changes looks good to me, in "B6726695.java" you have used ".loopback()" which is not consistent with the other similar URL construction changes although i can see that "ProxyTest.java" uses ".loopback()" as well.
Thanks,
Vyom
- Original message -From: Daniel Fuchs
12 matches
Mail list logo
