Thanks Vyom, On 27/05/2019 10:32, Vyom Tewari26 wrote:
Overall changes looks good to me, in "B6726695.java" you have used ".loopback()" which is not consistent with the other similar URL construction changes although i can see that "ProxyTest.java" uses ".loopback()" as well.
Yes consistency is not that important here. Sometimes you have the server/server socket address available and can use that. Sometimes it's not directly available unless you modify the test to pass it - in which case using loopback() when you know that the server is bound to the loopback is also acceptable. best regards, -- daniel
