Alan, > On 27 May 2019, at 17:11, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 27/05/2019 16:48, Chris Hegarty wrote: >> >> >> Updated webrev: >> https://cr.openjdk.java.net/~chegar/8224477/webrev.04/ > This version looks good. > > A minor nit is that there's a blank line added to SocketChannelImpl.setOption > that separates a comment from the code that it documents, I assume this is > left over from previous iteration when there was a null check in the > SO_REUSEADDR handling. > > Also the two TestDefaultBehavior tests both name the test impl > "DelegatingSocketImpl" but it doesn't really delegate, they are really no-op > impls.
Thanks, both issues resolved in-place. > On the CSR. The Problem section suggests that supportedOptions returned a set > of options that are reasonable for a ServerSocket. I assume this should be > client Socket as most of the options were not interesting for a ServerSocket. ServerSocket options are mentioned here as that is the behaviour in the current shipping release ( to return the server related options ), not the client related ones, see http://hg.openjdk.java.net/jdk/jdk/file/jdk-12-ga/src/java.base/share/classes/java/net/SocketImpl.java#l472 -Chris.
