Those suggestions are reasonable Christoph. I think given the subtle
nature of the bug
(removing the #include not causing a compile error) I'm a bit wary about
pushing wide scale
native code changes at this stage of JDK 9. We might therefore defer the
other cleanups until 10
opens up in the new
Bernd,
I'll add a test for SO_SNDBUF. These parameters are too system dependent
to use hard coded values in the tests though. I'm not sure you could depend
on the initial/default value never being the same as the maximum value
either.
Thanks,
Michael
On 09/12/2016, 11:31, Bernd Eckenfels wrot
Should the test maybe assert that a change was made (or maybe be a bit more
whitebox and assert the result is >64k? Should it test SND+RCV?
Gruss
Bernd
--
http://bernd.eckenfels.net
On Fri, Dec 9, 2016 at 12:04 PM +0100, "Michael McMahon"
wrote:
Could I get the following change r
Hi Michael,
the bug then obviously was a side effect of my change
http://hg.openjdk.java.net/jdk9/dev/jdk/rev/9f0ab4b20ff7 for 8167481. Sorry for
that.
To follow the concept of my cleanups I'd prefer if you could use #if
defined(MACOSX) rather than #ifdef MACOSX in net_util_md.c to be consiste
On 09/12/16 10:33, Michael McMahon wrote:
Could I get the following change reviewed please?
http://cr.openjdk.java.net/~michaelm/8170920/webrev.1/
Looks good.
You may just want to remove the "from" year from the copyright
year range in the test, before pushing.
-Chris.
Could I get the following change reviewed please?
http://cr.openjdk.java.net/~michaelm/8170920/webrev.1/
Thanks,
Michael.
