mutt/2713: memory allocation bug

2007-01-26 Thread vincent
gt;Submitter-Id: net >Arrival-Date: Sat Jan 27 04:27:55 +0100 2007 >Originator: Vincent Lefevre >Release:1.5.13 (2007-01-26) >Organization: >Environment: System: Darwin 8.8.0 (Power Macintosh) [using ncurses 5.5] [using libiconv 1.11] [using libidn 0.6.3 (compiled with

mutt/2799: Avoid gpgme (AM_PATH_GPGME) dependency for autoconf

2007-02-24 Thread vincent
>Class: sw-bug >Submitter-Id: net >Arrival-Date: Sun Feb 25 02:32:45 +0100 2007 >Originator: Vincent Lefevre >Release:CVS >Organization: >Environment: >Description: To be able to run autoconf, one needs to have gpgme installed due to the use of the AM_P

mutt/2820: Mutt doesn't build with --without-wc-funcs

2007-03-04 Thread vincent
t;Class: sw-bug >Submitter-Id: net >Arrival-Date: Sun Mar 04 12:31:35 +0100 2007 >Originator: Vincent Lefevre >Release:cvs >Organization: >Environment: Mac OS X 10.4.8 (PowerPC). >Description: When I configure Mutt using --without-wc-funcs (this should be

Re: mutt: Add "Mailbox Matching in Hooks" section to manual.

2015-07-28 Thread Vincent Lefevre
t isn't? I think that this is buggy since "the current mailbox" is supposed to be anchored at the beginning of the string. -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Re: mutt: Add "Mailbox Matching in Hooks" section to manual.

2015-07-28 Thread Vincent Lefevre
incorrect if the -f flag is passed to mutt. SpoolFile may be empty, so that it wouldn't be a solution either. Perhaps the empty string is OK, but an error should be generated when ^ expands to the empty string. The advantage is that the user would be aware of the error. -- Vincent

Re: mutt: Add "Mailbox Matching in Hooks" section to manual.

2015-07-29 Thread Vincent Lefevre
ansion returns an empty string. Thanks. This seems to be OK. -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Re: Overlong lines

2015-08-20 Thread Vincent Lefevre
do that. But as I said 11 years ago[*]: I think that a 1-line menu is a bad idea (this is even worse in French). Also, one should also take into account that terminals can have fewer than 80 columns (e.g. that could be PDAs). BTW, the sort menu should also be reconsidered IMHO, though there

Re: Preparing for a new release

2015-08-20 Thread Vincent Lefevre
/mutt/patches/#trash also mentions >The folder history doesn't clutter up with unwanted trash entries. > > (I am not sure, what is meant with this one) In "=INBOX.Trash", the "=INBOX.Trash" will be saved to the history, and it is not possible to temporarily disable the history (e.g. for such macros). So, indeed, this would be very annoying. -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Re: Preparing for a new release

2015-08-20 Thread Vincent Lefevre
On 2015-08-21 01:33:10 +0200, Vincent Lefevre wrote: > On 2015-08-20 07:49:11 +0200, Christian Brabandt wrote: > > Fifth, http://cedricduval.free.fr/mutt/patches/#trash also mentions > >The folder history doesn't clutter up with unwanted trash entries. > > > &g

Re: Preparing for a new release

2015-08-21 Thread Vincent Lefevre
On 2015-08-20 19:53:36 -0700, Kevin J. McCarthy wrote: > Vincent Lefevre wrote: > > In "=INBOX.Trash", the "=INBOX.Trash" will be > > saved to the history, and it is not possible to temporarily disable > > the history (e.g. for such macros). So, indeed

Re: Preparing for a new release

2015-08-21 Thread Vincent Lefevre
On 2015-08-21 13:05:39 +0200, Vincent Lefevre wrote: > On 2015-08-20 19:53:36 -0700, Kevin J. McCarthy wrote: > > Vincent Lefevre wrote: > > > In "=INBOX.Trash", the "=INBOX.Trash" will be > > > saved to the history, and it is not possible to tempo

Re: Preparing for a new release

2015-08-21 Thread Vincent Lefevre
On 2015-08-21 13:21:56 +0200, Vincent Lefevre wrote: > On 2015-08-21 13:05:39 +0200, Vincent Lefevre wrote: > > On 2015-08-20 19:53:36 -0700, Kevin J. McCarthy wrote: > > > Vincent Lefevre wrote: > > > > In "=INBOX.Trash", the "=INBOX.Trash" w

Re: manual.txt has encoding errors

2015-09-05 Thread Vincent Lefevre
Or stick with ASCII (but do not use w3m, which cannot transcode non-ASCII characters). [*] https://sourceware.org/bugzilla/show_bug.cgi?id=16621 -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Re: [patch] Implement GMail-style muting of threads

2015-09-11 Thread Vincent Lefevre
y other function that works on patterns, possibly via a macro. -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Re: [patch] Implement GMail-style muting of threads

2015-09-19 Thread Vincent Lefevre
On 2015-09-15 09:56:56 +0200, Andreas Schäfer wrote: > On 13:33 Fri 11 Sep , Vincent Lefevre wrote: > > If something needs to be done, I'd rather see an improvement of > > the pattern system, where one can have pattern variables, and some > > functions to operate on t

Re: Problem with key bindings

2016-01-14 Thread Vincent Lefevre
ande line (or in cooked mode), the left arrow yields ^[[D, but in app mode (e.g. in tack), it yields ^[OD. > All key assignments without a ';' in them work file and all that > include a ';' fail. You can try to type the individual keys like Esc [ 2 0 ; 2 ~ to see if th

Re: Problem with key bindings

2016-01-15 Thread Vincent Lefevre
h the auxiliary on the Solaris system. However, not all keys have a terminfo name. This means that you may be forced to use ";" in a key sequence for a binding. -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Re: Problem with key bindings

2016-01-15 Thread Vincent Lefevre
On 2016-01-15 14:20:05 +, Ian Collier wrote: > On Fri, Jan 15, 2016 at 03:12:14PM +0100, Vincent Lefevre wrote: > > However, not all keys have a terminfo name. This means that you may be > > forced to use ";" in a key sequence for a binding. > > My opinion

Re: Problem with key bindings

2016-01-21 Thread Vincent Lefevre
nce if there is no keysym -- which, of course, is what > what-key was reporting. AFAIK, this is called keyname (keysym is an X11 thing). -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA -

Option -H and signature / my_hdr

2016-02-16 Thread Vincent Lefevre
ome-Header: ..." and it will be added every time. -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Re: Option -H and signature / my_hdr

2016-02-19 Thread Vincent Lefevre
seful? Perhaps. I wonder whether this should be done with a new option or a command-line switch (or both). -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Re: Option -H and signature / my_hdr

2016-03-07 Thread Vincent Lefevre
o again. > > The patch is really raw, and only briefly documented. If this is > interesting, I will clean it up. Please let me know what you think. I haven't tried it yet (I'm rather busy these days), but I think that it is a good idea. -- Vincent Lefèvre - Web: <http

Re: 1.6.0 proposed schedule

2016-03-07 Thread Vincent Lefevre
patch: http://marc.info/?l=mutt-dev&m=115272028620011&w=2 patch-1.5.23hg.dm.domain.vl.1 is from Derek Martin, written in 2013, and I've modified the patch to avoid a memory leak. It fixes: https://dev.mutt.org//trac/ticket/3298 -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% a

Re: 1.6.0 proposed schedule

2016-03-08 Thread Vincent Lefevre
updated > > for the latest changes in the trunk. > > Thanks, Vincent. I'll take a look at those patches. I think you said > you've been using the DNS patch for some time with no problems, is that > right? Yes, I've been using it on all my machines, and with t

Re: Ticket 3298 patch feedback

2016-03-08 Thread Vincent Lefevre
ame(): %s\n", d)); just before the "ret = 0;" line in getdomain.c (this may be useful for debugging). I used that to also check that the right domain part was taken into account. -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

use of ftruncate without checking the return value

2016-03-11 Thread Vincent Lefevre
in mutt_index_menu () at curs_main.c:1115 #12 0x00405c9f in main (argc=1, argv=) at main.c:1209 -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA - computer arithmetic / AriC project (L

Re: manual.txt has encoding errors

2016-03-26 Thread Vincent Lefevre
On 2016-03-23 08:46:35 +0100, Olaf Hering wrote: > On Sat, Sep 05, Vincent Lefevre wrote: > > > On 2015-09-02 16:50:21 +0200, Olaf Hering wrote: > > > After some debugging it turned out that mutt has a bug: > > > LC_ALL=C w3m -dump doc/manual.html > bad.txt &

Re: make build date in version string configurable?

2016-03-30 Thread Vincent Lefevre
'const char *ReleaseDate = "'`head -n 1 $(srcdir)/ChangeLog | LC_ALL=C cut -d ' ' -f 1`'";' > reldate.h.tmp So, why isn't it fixed for you? -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <htt

Re: make build date in version string configurable?

2016-03-30 Thread Vincent Lefevre
option. The date in Mutt's version string is *not* the build date, but the release date, which is fixed. -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Re: make build date in version string configurable?

2016-03-30 Thread Vincent Lefevre
On 2016-03-30 13:45:42 +0200, Olaf Hering wrote: > On Wed, Mar 30, Vincent Lefevre wrote: > > > There is no need for such an option. The date in Mutt's version > > string is *not* the build date, but the release date, which is > > fixed. > > ... and as such

Re: symbol conflict with 1.6 on OpenIndiana

2016-04-05 Thread Vincent Lefevre
READ to MUTT_CMD and MUTT_READ and was able > > to compile afterwards. > > Thanks for the heads-up Fabian. I'll put this on the list of things to fix. Unfortunately this will break patches. -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated

Re: Neomutt - Release 20160404 (Mutt-1.6.0)

2016-04-05 Thread Vincent Lefevre
h quasi-delete. No. This is completely different. The goal of the trash folder is to really delete mail from the usual folders, keeping a temporary backup of these messages. The goal of Quasi-Delete seems more like filtering, a bit like , but stronger, with a result that looks like a folder. I

Re: Neomutt - Release 20160404 (Mutt-1.6.0)

2016-04-05 Thread Vincent Lefevre
of code. Couldn't ~. be changed internally to ~m at evaluation time? -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Re: Neomutt - Release 20160404 (Mutt-1.6.0)

2016-04-05 Thread Vincent Lefevre
On 2016-04-05 16:40:14 +0100, Richard Russon wrote: > On Tue, Apr 05, 2016 at 04:32:11PM +0200, Vincent Lefevre wrote: > > On 2016-04-05 14:43:15 +0100, Richard Russon wrote: > > > > The limiting machinery doesn't take any parameters > > > Couldn't ~. b

Re: Neomutt - Release 20160404 (Mutt-1.6.0)

2016-04-11 Thread Vincent Lefevre
CLI-oriented so I would say, the > whole "git vs hg" thing is human-related one, i.e. it's about what's more > comfortable for people, but feature-wide they are not too far away. While I've already used the GUI for git, I've never used one for hg (and I did

Re: [PATCH] Add spacing to truncated multi-column characters when using soft-fill.

2016-04-13 Thread Vincent Lefevre
gt; The second patch fixes softpad when the pad character itself is multicolumn. In this second patch: + pad = ((signed)(destlen - wlen - len)) / pl; The cast to "signed" seems useless and confusing: what is its goal? -- Vincent Lefèvre - Web: <https://www.vinc17.n

Re: [PATCH] Add spacing to truncated multi-column characters when using soft-fill.

2016-04-13 Thread Vincent Lefevre
On 2016-04-13 07:24:50 -0700, Kevin J. McCarthy wrote: > On Wed, Apr 13, 2016 at 10:34:31AM +0200, Vincent Lefevre wrote: > > On 2016-04-12 12:41:05 -0700, Kevin J. McCarthy wrote: > > > I'm attaching a slightly revised part1 patch, and adding another patch > > > to

Re: [PATCH] Add spacing to truncated multi-column characters when using soft-fill.

2016-04-14 Thread Vincent Lefevre
e.ac now. So, division with negative arguments should be OK. Note that instead of using the type size_t, you can probably use the type long, to avoid the problem with the cast. -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Re: [PATCH 0 of 8] Change Mutt to use window structures for screen drawing

2016-04-21 Thread Vincent Lefevre
, but wouldn't closing the branch (hg commit --close-branch) be sufficient? Or what about a bookmark instead of a branch? -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Re: [PATCH 0 of 8] Change Mutt to use window structures for screen drawing

2016-04-22 Thread Vincent Lefevre
which will make it no longer inactive. > Bookmarks may be an idea. Looking at the wiki page, it says bookmarks > can be removed, but the commits still stay. Yes, commits should stay. That's the goal of a VCS. But AFAIK, they will not be in the way. So, as long as there are no major c

Re: [PATCH 0 of 8] Change Mutt to use window structures for screen drawing

2016-04-25 Thread Vincent Lefevre
s should be seen as a single commit (if one wants to), thus hiding any temporary work. Note that the work in the feature branch should really be kept. This can be useful if a bug or some suspicious code is discovered later, in order to know what led to this code or what could be wrong if it is mod

Re: [PATCH 0 of 8] Change Mutt to use window structures for screen drawing

2016-04-25 Thread Vincent Lefevre
On 2016-04-25 13:18:53 +0200, Oswald Buddenhagen wrote: > On Mon, Apr 25, 2016 at 10:49:01AM +0200, Vincent Lefevre wrote: > > Rewriting the history is useful only when [...] > > > the whole argumentation is besides the point, as we're talking about > non-mainline branc

Re: [PATCH] Create a wrapper sys_socket.h to work around Solaris namespace issues. (closes #3833)

2016-05-01 Thread Vincent Lefevre
On 2016-04-26 09:54:48 -0700, Kevin J. McCarthy wrote: > David, Brendan, Vincent (and anyone else), does the prefix 'MUTT_' sound > reasonable, or is there another prefix that would be better? It is reasonable, but as reasonable as M_ (for a prefix used internally). If systems ca

Re: [PATCH 0 of 8] Change Mutt to use window structures for screen drawing

2016-05-02 Thread Vincent Lefevre
On 2016-04-30 14:30:52 +0200, Oswald Buddenhagen wrote: > On Mon, Apr 25, 2016 at 06:12:25PM +0200, Vincent Lefevre wrote: > > On 2016-04-25 13:18:53 +0200, Oswald Buddenhagen wrote: > > > On Mon, Apr 25, 2016 at 10:49:01AM +0200, Vincent Lefevre wrote: > > > > Rewrit

Re: [PATCH] Create a wrapper sys_socket.h to work around Solaris namespace issues. (closes #3833)

2016-05-03 Thread Vincent Lefevre
On 2016-05-02 15:02:44 -0500, Derek Martin wrote: > On Sun, May 01, 2016 at 07:26:53PM -0700, Kevin J. McCarthy wrote: > > On Sun, May 01, 2016 at 07:02:38PM +0200, Vincent Lefevre wrote: > > > On 2016-04-26 09:54:48 -0700, Kevin J. McCarthy wrote: > > > > David, Bre

Re: [PATCH 0 of 8] Change Mutt to use window structures for screen drawing

2016-05-03 Thread Vincent Lefevre
On 2016-05-03 08:45:40 +0200, Oswald Buddenhagen wrote: > On Mon, May 02, 2016 at 02:41:54PM +0200, Vincent Lefevre wrote: > > What I've said is that the work is done in a separate branch (a feature > > branch). Then, all that needs to be done is a merge to the main branch

mutt_window_getyx

2016-05-03 Thread Vincent Lefevre
utt_window_getyx (mutt_window_t *, int *y, int *x); One way to explicitly silent the "unused var" warning is to do: (void) y; /* don't care about y: avoiding unused var warning */ -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML -

Re: [PATCH] Create a wrapper sys_socket.h to work around Solaris namespace issues. (closes #3833)

2016-05-04 Thread Vincent Lefevre
On 2016-05-03 13:02:56 -0500, Derek Martin wrote: > On Tue, May 03, 2016 at 11:11:44AM +0200, Vincent Lefevre wrote: > > On 2016-05-02 15:02:44 -0500, Derek Martin wrote: > > > The difference is the OS is using M_, and such short prefixes are > > > common for OS-level

Re: [PATCH] change M_* symbols to MUTT_*

2016-05-12 Thread Vincent Lefevre
hat the patch broke indentation in .h files due to the use of tab characters in the code. -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

messages from OPS.MIX and OPS.SIDEBAR

2016-06-12 Thread Vincent Lefevre
Is there any reason why the messages from the OPS.MIX and OPS.SIDEBAR files start with a capital letter, contrary to the messages from the other OPS files? -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Wo

Re: [SPAM?] trash folder patch (was Re: [PATCH] Combine the basic and extended buffy functions.)

2016-06-15 Thread Vincent Lefevre
rename as well as mailbox driver reorganization)? I use the attached one, which is Cedric Duval's slightly updated for the latest changes. -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA -

Re: [PATCH 3/5] examine_directory: set directory/symlink size to zero

2016-06-16 Thread Vincent Lefevre
can still be interesting information. Last year, reading some empty directory after reboot was taking 100 seconds! [*] The cause was that the directory was very large. Now, perhaps this is less important info in Mutt. [*] https://lists.debian.org/debian-user/2015/04/msg00651.html -- Vincent Lefèv

Re: message stored in Sent folder even if sending fails

2016-07-26 Thread Vincent Lefevre
mail=/bin/false this is indeed wrong: each time I try to send the message, a copy of the message is stored in $record, which gives the false impression that the mail has been sent. -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Re: message stored in Sent folder even if sending fails

2016-07-26 Thread Vincent Lefevre
On 2016-07-26 07:01:57 -0400, Patrick Shanahan wrote: > * Vincent Lefevre [07-26-16 06:52]: > > If I use > > > > set sendmail=/bin/false > > > > this is indeed wrong: each time I try to send the message, a copy of > > the message is stored in $record, wh

Re: message copy enhancement

2016-07-28 Thread Vincent Lefevre
of the bugs also > explains why Mutt adds those headers (an optimization), and by and > large their addition should not be of any consequence to the user... > Tools whose behaviors are impacted by arbitrary message headers are, I > think, broken. In particular, the "Lines:" hea

Re: message stored in Sent folder even if sending fails

2016-07-28 Thread Vincent Lefevre
On 2016-07-27 15:43:40 +0100, Ian Collier wrote: > On Wed, Jul 27, 2016 at 02:46:18AM +0200, Vincent Lefevre wrote: > > Mutt should store the message to the Sent folder *after* running > > sendmail and *only* if sendmail returned with a zero exit status. > > What happens

Re: message stored in Sent folder even if sending fails

2016-07-28 Thread Vincent Lefevre
enu screen that says "saving the outgoing message > failed, what now?" Actually the mail should not be lost: as long as it hasn't been saved to the Sent folder, it should be kept in the temporary file on disk. Moreover, a new menu screen isn't needed, just a prompt. -- Vi

Re: message stored in Sent folder even if sending fails

2016-08-02 Thread Vincent Lefevre
On 2016-07-29 12:35:31 -0500, Derek Martin wrote: > On Thu, Jul 28, 2016 at 11:12:48AM +0200, Vincent Lefevre wrote: > > I think that the right solution would be to prompt the user for > > retrying. The user should have the choice between: > > > > 1. Retry (default)

Re: message stored in Sent folder even if sending fails

2016-08-03 Thread Vincent Lefevre
On 2016-08-03 12:36:06 +0200, Michael Tatge wrote: > Hi, > > * On Wed, Jul 27, 2016 02:46AM +0200 Vincent Lefevre (vinc...@vinc17.org) > muttered: > > Mutt should store the message to the Sent folder *after* running > > sendmail and *only* if sendmail returned with a z

Re: message stored in Sent folder even if sending fails

2016-08-05 Thread Vincent Lefevre
e $tmpdir (not ideal because it affects even cache-like temporary data in Mutt, i.e. which may be lost, but that's currently the best solution) or they don't care about losing the mail they are composing, otherwise bug 3236 would have already been fixed: https://dev.mutt.org/tra

Re: [PATCH] Preserve pager position only for ops that redirect back to the same message.

2016-08-06 Thread Vincent Lefevre
that redirect > back to the same message only. I'm trying this patch right now. -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Re: [PATCH] Preserve pager position only for ops that redirect back to the same message.

2016-08-07 Thread Vincent Lefevre
er fixing, except that it causes a bug. > Once in a while, a message happens to share the same address as the last > saved header pointer, and the pager tries to open the new message and > scroll down to the position in the old message. which could even be below the last line of the new message

Re: [Mutt] #3752: default user_agent to no

2016-08-08 Thread Vincent Lefevre
On 2016-08-08 08:25:14 -, Mutt wrote: > Here's a real-life example of how metadata version leaks like these are > actually used in practice to help identify people: This is pointless here. The "From:" header already identifies the user. -- Vincent Lefèvre - Web: &l

Re: [Mutt] #3752: default user_agent to no

2016-08-08 Thread Vincent Lefevre
On 2016-08-08 17:18:57 +0300, Consus wrote: > On 16:16 Mon 08 Aug, Vincent Lefevre wrote: > > On 2016-08-08 08:25:14 -, Mutt wrote: > > > Here's a real-life example of how metadata version leaks like these are > > > actually used in practice to help i

Re: mutt: 2 new changesets

2016-08-09 Thread Vincent Lefevre
lect that by using https here too (this would also be safer). The URL on https://www.openhub.net/p/mutt/enlistments could be updated too (Brendan is the manager). -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Re: Preserve pager position only for ops that redirect back to the same message.

2016-08-13 Thread Vincent Lefevre
re you at before? I also notice this. So, I suppose that this comes from the patch. I think that this should be fixed, as the goal of is to see the headers (even though one could write a macro to do ). -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Re: Preserve pager position only for ops that redirect back to the same message.

2016-08-13 Thread Vincent Lefevre
ith r6205 (May 2012). Before that, Mutt can no longer be built. I wonder why I didn't notice this before (or perhaps I did, but didn't bother to report it). That said, I normally use when the top of the message is visible. -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% acc

Re: Some patches rebased on top of mutt-1.7.0

2016-08-22 Thread Vincent Lefevre
ose menu, pressing or '?' to browse a directory and > > select the file by tagging and press 'q'. > > Right, the only difference is you press enter, not 'q'. I confirm that with Enter, this works with 1.7.0 (+ unrelated patches). -- Vincent Lefèvre - W

Re: mutt: Filter out zero width no-break space (U+FEFF).

2016-08-23 Thread Vincent Lefevre
On 2016-08-23 04:34:20 -0700, Brendan Cully wrote: > changeset: 6771:768b430f3dca > user: Vincent Lefevre > date: Tue Aug 23 13:32:31 2016 +0200 > link: http://dev.mutt.org/hg/mutt/rev/768b430f3dca > > Filter out zero width no-break space (U+FEFF). FYI, it

Re: index format locale bug

2016-08-23 Thread Vincent Lefevre
onfiguration was > set date_format="%A, %Y-%m-%d %H:%M:%S %Z" > which, except the %A, can be used internationally. I agree, except that I would keep the bang. The reason is that the default $attribution value is in English ("On %d, %n wrote:"), so that by default, one expec

Re: index format locale bug

2016-08-23 Thread Vincent Lefevre
, who may think that something is broken on his system. -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Re: index format locale bug

2016-08-23 Thread Vincent Lefevre
On 2016-08-23 14:57:16 -0500, Derek Martin wrote: > On Tue, Aug 23, 2016 at 02:13:45PM +0200, Vincent Lefevre wrote: > > I agree, except that I would keep the bang. The reason is that the > > default $attribution value is in English ("On %d, %n wrote:"), so > > th

Re: Mutt code style

2016-09-02 Thread Vincent Lefevre
patches >on top of vanilla mutt. One can still apply the patch ignoring whitespace (-l), clean up (reindent, etc.), and rebuild the patch. A bit annoying but this would have to be done only once. -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Re: [SPAM?] [PATCH] doc: A css fix to ease reading the manual on big screens

2016-09-03 Thread Vincent Lefevre
ise, perhaps something useful could be put in the margins when the viewport is large enough, like the table of contents. Some web sites do this. -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA - comp

Re: [PATCH] setenv/unsetenv for altering process environment (to affect children)

2016-09-06 Thread Vincent Lefevre
, and if there ARE bugs that trigger this, the above will > make them easy to identify and fix. =8^) I completely agree. BTW, I even build and use Mutt with GCC's UB sanitizer (-fsanitize=undefined -fno-sanitize-recover). -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Re: [SPAM?] [PATCH] doc: A css fix to ease reading the manual on big screens

2016-09-06 Thread Vincent Lefevre
ers. > Perhaps it would be beneficial to add > > > > to `mutt.xsl` to ask a browser to use an "ideal" viewport of the > device. But then, it seems that you may have problems with iOS devices, for which device-width is always 768px according to http://www.alsacreatio

Re: [PATCH] setenv/unsetenv for altering process environment (to affect children)

2016-09-07 Thread Vincent Lefevre
On 2016-09-06 10:44:12 -0500, Derek Martin wrote: > On Tue, Sep 06, 2016 at 01:10:36PM +0200, Vincent Lefevre wrote: > > On 2016-09-05 19:07:18 -0500, Derek Martin wrote: > > > On Mon, Sep 05, 2016 at 10:32:40AM -0500, Derek Martin wrote: > > > > Is strfcpy() widel

Re: [PATCH] setenv/unsetenv for altering process environment (to affect children)

2016-09-07 Thread Vincent Lefevre
s in configure) still needed? > > Probably not. I'm not really in a hurry to rip it out, though. > Vincent, Derek, what do you think? Systems may have a C99 compiler but not necessarily snprintf. In general, the compiler and the C library are provided by different people. Now, I

Re: [PATCH] setenv/unsetenv for altering process environment (to affect children)

2016-09-07 Thread Vincent Lefevre
On 2016-09-07 09:10:09 -0500, Derek Martin wrote: > On Wed, Sep 07, 2016 at 01:26:35PM +0200, Vincent Lefevre wrote: > > > Firstly, I'll note that, given the existing macros don't seem to have > > > caused anyone any grief, the exact macro syntax is largely an ac

Re: [PATCH] setenv/unsetenv for altering process environment (to affect children)

2016-09-07 Thread Vincent Lefevre
ent. A simple > example: > > #define FOO(A, I) do { my_func((A), (I)) } while ((I)) My point was to avoid something like #define FOO(A, I) { ... } in which case, one generally adds do ... while (0). I have not suggested to use another form like the one you give. -- Vincent Lefè

Use of AC_CHECK_HEADERS (was: [Mutt] #3892: fatal error: curses.h: No such file or directory)

2016-11-03 Thread Vincent Lefevre
ariables could be defined at the same time and the Mutt code needs to ensure consistency by testing the variables in the right order. -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Re: [PATCH] search muttrc file according to XDG Base Specification (closes #3207)

2016-11-17 Thread Vincent Lefevre
mutt_message ("Mutt %s (%s)", MUTT_VERSION, ReleaseDate); > + mutt_message ("Mutt " MUTT_VERSION " (%s)", ReleaseDate); > } This change seems incorrect if MUTT_VERSION contains the % character. Ditto for the other similar changes. -- Vincent Lefèvre - W

Re: mutt: Adds the '@' pattern modifier to limit matches to known al...

2016-11-17 Thread Vincent Lefevre
only when followed by ~, then this is fine. Alternatively, what about the ~@f syntax? -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Re: [PATCH] search muttrc file according to XDG Base Specification (closes #3207)

2016-11-17 Thread Vincent Lefevre
lications use .config as expected. So, Mutt should do the same. -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Re: [PATCH] search muttrc file according to XDG Base Specification (closes #3207)

2016-11-17 Thread Vincent Lefevre
ay put new versions of config files in new locations but forget to remove the old versions. If the old location is searched first, the old version of the config file will have the precedence. However, I'm not sure. Isn't there some recommendation? -- Vincent Lefèvre - Web: <https://ww

inconsistencies in error messages

2016-11-18 Thread Vincent Lefevre
orary file %s."), tmpbody); recvcmd.c: mutt_error (_("Can't create %s."), tmpbody); recvcmd.c:mutt_error _("Can't find any tagged messages."); recvcmd.c:mutt_error (_("Can't create %s."), tmpbody); remailer.c:mutt_error _("Can't get mixmaster's type2.list!"); sendlib.c:mutt_error (_("Can't stat %s: %s"), fname, strerror (errno)); smime.c:mutt_error _("Can't sign: No key specified. Use Sign As."); There should be an error style guide, like: https://www.postgresql.org/docs/9.2/static/error-style-guide.html -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Re: mutt: Adds the '@' pattern modifier to limit matches to known al...

2016-11-18 Thread Vincent Lefevre
nce, what the following is supposed to mean? ~fa@~tb Moreover the documentation is in Section "User-Defined Variables" in the manual instead of "Pattern Modifier". -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <ht

Re: mutt: Backout inlining of MUTT_VERSION in 42fee7585fae.

2016-11-18 Thread Vincent Lefevre
ome users (including me!) modify the code to generate the MUTT_VERSION string. So, it might be an issue for some users. That's why in the doubt, it's better not to assume that the % character will not be present. -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible v

Re: mutt: Adds binding to create "hotkeys" for messages.

2016-11-18 Thread Vincent Lefevre
^^ And this message should be made translatable, starting with a lowercase character. Moreover, changing the prefix doesn't seem to work. I've changed it to # so I get: #z M ~i "<2016... Message hotkey but as soon as I hit #, I get an error saying that the key is not affected. -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Re: mutt: Adds binding to create "hotkeys" for messages.

2016-11-19 Thread Vincent Lefevre
he macro can be added by the user if he really wants that. > So I think the fix here is just to change MENU_GENERIC to MENU_MAIN. > > I'll fix that and the translation messages and push a fix later today. Thanks. I confirm that this works. -- Vincent Lefèvre - Web: <

Re: NULL vs NUL (changeset: 6873:65f180f2904f)

2016-11-21 Thread Vincent Lefevre
EBCDIC, while the null character is charset independent. > > + /* Note that X509_NAME_online will NULL-terminate buf, even when it > ^e ^ > -> > > > + /* Note that X509_NAME_oneline will NUL-terminate buf, even when it Should b

Re: Legal values for a message-id, and references header

2016-11-21 Thread Vincent Lefevre
if it is > feasible mutt should decode these, but write _unencoded_ versions of these > headers and any headers derived from them. In particular, is it easy to make > mutt's header ingestion code go "stict parse, but if that fails decode with > RFC2047 and try a second time&quo

Re: Legal values for a message-id, and references header

2016-11-22 Thread Vincent Lefevre
On 2016-11-22 20:43:12 +1100, Cameron Simpson wrote: > On 22Nov2016 03:27, vincent lefevre wrote: > > That's clearly illegal. MIME has been designed so that the main > > features should still work with software that doesn't support MIME > > (said otherwise, softwa

efficiency issue in index with messages with big Cc

2016-12-08 Thread Vincent Lefevre
22 stat("/etc/localtime", {st_mode=S_IFREG|0644, st_size=2971, ...}) = 0 16:53:22 stat("/etc/localtime", {st_mode=S_IFREG|0644, st_size=2971, ...}) = 0 16:53:22 stat("/etc/localtime", {st_mode=S_IFREG|0644, st_size=2971, ...}) = 0 16:53:22 stat("/home/vlefevre/

Re: efficiency issue in index with messages with big Cc

2016-12-25 Thread Vincent Lefevre
On 2016-12-08 16:21:47 -0800, Kevin J. McCarthy wrote: > On Thu, Dec 08, 2016 at 05:30:35PM +0100, Vincent Lefevre wrote: > > The hangs is due to this big Cc and the "subscribe" / "lists" commands > > in my muttrc. > > Hi Vincent, > > I'm ass

Re: efficiency issue in index with messages with big Cc

2016-12-25 Thread Vincent Lefevre
On 2016-12-25 22:14:56 +0100, Vincent Lefevre wrote: > The problem is due to several "color index ..." with ~l in the regexp. > I've noticed that if I leave only one, then it is much faster. So, it > seems that Mutt doesn't remember the ~l matching. The lack of e

Re: efficiency issue in index with messages with big Cc

2016-12-31 Thread Vincent Lefevre
ops, I forgot I initially set the cache->list to be a single bit. > I've changed it to an int for now in the attached patch. Thanks. Indeed, it makes Mutt much faster in these cases. -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog:

Re: mutt: Allow initial blank lines in local mailboxes.

2017-01-19 Thread Vincent Lefevre
while (...) { } IMHO, this is as visible as "continue;". > > ch will only be 0 if there's a NUL-byte in the file which > > is unexpected for Mboxes but not a problem with the issue the > > comment is talking about. > > It's unexpected but no

Re: mutt: Allow initial blank lines in local mailboxes.

2017-01-19 Thread Vincent Lefevre
ferror(f)) > ungetc(ch, f); > > Not clearly better. The C standard says that either a character (when available) or EOF is returned. Why not the following? if (ch != EOF) ungetc(ch, f); -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validate

Re: From vs Reply-To when replying and the address mailboxes match

2017-01-22 Thread Vincent Lefevre
is the real reason, this may be a good feature, but I think that it would be preferable to do this only if the Reply-To header had only an e-mail address, without a comment. -- Vincent Lefèvre - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

  1   2   3   4   5   6   >