On 2015-08-20 07:49:11 +0200, Christian Brabandt wrote: > Am 2015-08-19 23:34, schrieb Kevin J. McCarthy: > >>2) I don't know for how long we have been running mutt with the trash > >>folder patch. It looks quite clean to me. So would you consider > >>integrating this patch upstream?
FYI, I had been using it between 2005-02 and 2006-10 on my IMAP mailbox, without any problem. I stopped using it just because this was also saving spam to the trash folder. But I have still the patch applied (just with "unset trash"), and this doesn't cause any problem. > >I haven't ever taken a look at that patch, so I'd have to look at it > >more closely. I haven't had any problem just using: > > folder-hook . 'macro index,pager d "<save-message>=INBOX.Trash<enter>"' > > folder-hook =INBOX\.Trash 'macro index,pager d <delete-message>' > > folder-hook '=INBOX\.Junk Mail' 'macro index,pager d <delete-message>' > > > >The wiki used to say that didn't work with tagged messages, but that's no > >longer true. Also, it keeps me from moving spam to my trash when > >deleted. > > I have been using that approach for long enough, that I know it can cause > several annoyances. First, while I appreciate the flexibility of > folder-hooks > (and use them myself for several different purposes), I don't think it > is reasonable, to have every user invent their own, to make use of a trash > folder. > > Second, you would probably have to add some <tag-prefix-cond> > <end-cond> tags, to make this work properly with tagged messages. This adds > to > the burden that every user has to invent their own solution. > > Third, if you press 'd' on a message, later undelete the message > and even later delete the message one more time, you will end up with > many copies of the same message in your trash folder > > Fourth, does not work with <delete-pattern> and similar functions. I agree with everything. > Fifth, http://cedricduval.free.fr/mutt/patches/#trash also mentions > The folder history doesn't clutter up with unwanted trash entries. > > (I am not sure, what is meant with this one) In "<save-message>=INBOX.Trash<enter>", the "=INBOX.Trash" will be saved to the history, and it is not possible to temporarily disable the history (e.g. for such macros). So, indeed, this would be very annoying. -- Vincent Lefèvre <vinc...@vinc17.net> - Web: <https://www.vinc17.net/> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/> Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)
