Re: [Mutt] #3608: Character Š wrong in index and status on Mac OS X

2012-12-13 Thread Mutt
#3608: Character Š wrong in index and status on Mac OS X +--- Reporter: kolcon | Owner: mutt-dev Type: defect | Status: new Priority: minor | Milestone: Component: mutt| Vers

Re: [PATCH] Make imap_free_header_data type-safe

2012-12-13 Thread Cameron Simpson
On 09Sep2012 20:00, Andrew Gaul wrote: | - /* suppress GCC aliasing warning */ | - imap_free_header_data ((void**) (void*) &h.data); Pardon my ignorance, but what is (was?) the use of a cast like: (void**) (void*) A cast of a typed pointer to (void *) when handing it to somethi

Re: [PATCH] Make imap_free_header_data type-safe

2012-12-13 Thread Michael Elkins
On Thu, Dec 13, 2012 at 02:27:13PM -0800, Andrew Gaul wrote: I prefer the forward declaration; requiring a specific #include ordering makes code brittle. In this case, we would have to swap imap_private.h I agree the specific ordering makes it brittle, but so does the duplicate type declarati

Re: [PATCH] Make imap_free_header_data type-safe

2012-12-13 Thread Andrew Gaul
On Thu, Dec 13, 2012 at 02:07:07PM -0800, Michael Elkins wrote: > On Sun, Sep 09, 2012 at 08:00:38PM -0700, Andrew Gaul wrote: > >diff -r 70810a88ce9f -r 4fa799cbf296 imap/imap_private.h > >--- a/imap/imap_private.hSun Jul 22 11:15:30 2012 -0700 > >+++ b/imap/imap_private.hSun Sep 09 19:54:

Re: [PATCH] Make imap_free_header_data type-safe

2012-12-13 Thread Michael Elkins
On Sun, Sep 09, 2012 at 08:00:38PM -0700, Andrew Gaul wrote: diff -r 70810a88ce9f -r 4fa799cbf296 imap/imap_private.h --- a/imap/imap_private.h Sun Jul 22 11:15:30 2012 -0700 +++ b/imap/imap_private.h Sun Sep 09 19:54:46 2012 -0700 @@ -256,7 +256,8 @@ /* message.c */ void imap_add_ke

Re: [Mutt] #3608: Character Š wrong in index and status on Mac OS X

2012-12-13 Thread Mutt
#3608: Character Š wrong in index and status on Mac OS X +--- Reporter: kolcon | Owner: mutt-dev Type: defect | Status: infoneeded_new Priority: minor | Milestone: Component:

Re: [Mutt] #3608: Character Š wrong in index and status on Mac OS X

2012-12-13 Thread Mutt
#3608: Character Š wrong in index and status on Mac OS X +--- Reporter: kolcon | Owner: mutt-dev Type: defect | Status: infoneeded_new Priority: minor | Milestone: Component:

[PATCH 4/4] version.sh: Get detailed version info from git

2012-12-13 Thread Aaron Schrab
From: Aaron Schrab If not able to use mercurial to build a detailed version string, try using git to do so. --- version.sh | 26 ++ 1 file changed, 26 insertions(+) diff --git a/version.sh b/version.sh index 39709a0..54568ac 100644 --- a/version.sh +++ b/version.sh @@

[PATCH 1/4] version.sh: cd to script's directory

2012-12-13 Thread Aaron Schrab
From: Aaron Schrab Use the directory where the version.sh script is located as the directory where it is run. Since this will be run in a separate shell anyway, there's no need to worry about changing current directory. This eliminates the need for the caller to specify where the source directo

[PATCH 3/4] version.sh: Move mercurial code into if block

2012-12-13 Thread Aaron Schrab
From: Aaron Schrab Put the code to build a detailed version string using mercurial into an if block rather than immediately using the fallback if mercurial can't be used. This will allow checking for other sources of detailed version info, such as using git which will be supported in an upcoming

[PATCH 2/4] Generate version string during make not configure

2012-12-13 Thread Aaron Schrab
From: Aaron Schrab Switch to generating the version string during make process rather than at configure time. This makes it easier to keep the detailed version string accurate when doing development which doesn't require that the configure script be rerun. --- .hgignore|1 + Makefile.am

Cleanups and enhancements to generation of version strings

2012-12-13 Thread Aaron Schrab
The following series of commits provides some cleanups and enhancements to how the build process generates detailed version strings for builds done from a VCS. I initially did this looking to add support for builds from a git repository, but I believe that the first two commits in the series a

Re: [Mutt] #3608: Character Š wrong in index and status on Mac OS X

2012-12-13 Thread Mutt
#3608: Character Š wrong in index and status on Mac OS X +--- Reporter: kolcon | Owner: mutt-dev Type: defect | Status: new Priority: minor | Milestone: Component: mutt| Vers

Re: [Mutt] #3608: Character Š wrong in index and status on Mac OS X

2012-12-13 Thread Mutt
#3608: Character Š wrong in index and status on Mac OS X +--- Reporter: kolcon | Owner: mutt-dev Type: defect | Status: new Priority: minor | Milestone: Component: mutt| Vers

Re: [Mutt] #3608: Character Š wrong in index and status on Mac OS X

2012-12-13 Thread Mutt
#3608: Character Š wrong in index and status on Mac OS X +--- Reporter: kolcon | Owner: mutt-dev Type: defect | Status: new Priority: minor | Milestone: Component: mutt| Vers

Re: [Mutt] #3608: Character Š wrong in index and status on Mac OS X

2012-12-13 Thread Mutt
#3608: Character Š wrong in index and status on Mac OS X +--- Reporter: kolcon | Owner: mutt-dev Type: defect | Status: new Priority: minor | Milestone: Component: mutt| Vers

Re: [Mutt] #3608: Character Š wrong in index and status on Mac OS X

2012-12-13 Thread Mutt
#3608: Character Š wrong in index and status on Mac OS X +--- Reporter: kolcon | Owner: mutt-dev Type: defect | Status: new Priority: minor | Milestone: Component: mutt| Vers

Re: [Mutt] #3608: Character Š wrong in index and status on Mac OS X

2012-12-13 Thread Mutt
#3608: Character Š wrong in index and status on Mac OS X +--- Reporter: kolcon | Owner: mutt-dev Type: defect | Status: new Priority: minor | Milestone: Component: mutt| Vers

Re: [PATCH] Guard against NULL dereference in mutt_parent_message

2012-12-13 Thread Andrew Gaul
Can someone merge this commit? I sent a pull request almost three months ago. On Wed, Oct 24, 2012 at 02:36:52PM -0700, Andrew Gaul wrote: > Any comments about this patch? This addresses a crash for me. > > On Sun, Sep 23, 2012 at 10:29:57PM -0700, Andrew Gaul wrote: > > # HG changeset patch >

Re: urlview github repository

2012-12-13 Thread Andrew Gaul
Any chance that mutt could migrate to git and GitHub? This would reduce friction to contributing and make it easier to track outstanding commits. On Sun, Dec 09, 2012 at 08:02:42PM -0800, Michael Elkins wrote: > FYI, I've created a repository on github for the urlview package: > > https://github

Re: [PATCH] Make imap_free_header_data type-safe

2012-12-13 Thread Andrew Gaul
Can someone merge this commit? I sent a pull request almost three months ago. On Wed, Oct 24, 2012 at 02:36:25PM -0700, Andrew Gaul wrote: > Any comments about this patch? This cleans up a bunch of unneeded > casts. > > On Sun, Sep 09, 2012 at 08:00:38PM -0700, Andrew Gaul wrote: > > # HG chang

[Mutt] #3608: Character Š wrong in index and status on Mac OS X

2012-12-13 Thread Mutt
#3608: Character Š wrong in index and status on Mac OS X +--- Reporter: kolcon | Owner: mutt-dev Type: defect | Status: new Priority: minor | Milestone: Component: mutt| Vers