On Thu, Dec 13, 2012 at 02:07:07PM -0800, Michael Elkins wrote: > On Sun, Sep 09, 2012 at 08:00:38PM -0700, Andrew Gaul wrote: > >diff -r 70810a88ce9f -r 4fa799cbf296 imap/imap_private.h > >--- a/imap/imap_private.h Sun Jul 22 11:15:30 2012 -0700 > >+++ b/imap/imap_private.h Sun Sep 09 19:54:46 2012 -0700 > >@@ -256,7 +256,8 @@ > > > >/* message.c */ > >void imap_add_keywords (char* s, HEADER* keywords, LIST* mailbox_flags, > >size_t slen); > >-void imap_free_header_data (void** data); > >+struct imap_header_data; > >+void imap_free_header_data (struct imap_header_data** data); > > I think the forward decl can be omitted if we swap the #include of > imap_private.h and message.h? > > Other than that, the patch looks good.
I prefer the forward declaration; requiring a specific #include ordering makes code brittle. In this case, we would have to swap imap_private.h and message.h in imap/command.c, imap/util.c, and imap/message.c. -- Andrew Gaul http://gaul.org/
