Re: [Mesa-dev] [PATCH] gallivm: fix lp_build_compare_ext

arguments were 64 bit but store as 32 bit */ > + cond = LLVMBuildTrunc(builder, cond, bld_base->int_bld.int_vec_type, ""); > emit_data->output[emit_data->chan] = cond; > } > > -- > 1.9.1 > > ___ >

[Mesa-dev] [PATCH] scons: Add additional GCC function attribute macros.

Match the attributes currently checked in configure.ac. Signed-off-by: Vinson Lee --- scons/gallium.py | 5 + 1 file changed, 5 insertions(+) diff --git a/scons/gallium.py b/scons/gallium.py index 51b84d7..af30c09 100755 --- a/scons/gallium.py +++ b/scons/gallium.py @@ -380,11 +380,16

Re: [Mesa-dev] [PATCH 1/2] mesa: Detect and provide macros for function attributes pure and const.

On Tue, Jul 14, 2015 at 11:45 AM, Eric Anholt wrote: > These are really useful hints to the compiler in the absence of link-time > optimization, and I'm going to use them in VC4. > > I've made the const attribute be ATTRIBUTE_CONST unlike other function > attributes, because we have other things i

[Mesa-dev] [PATCH] st/mesa: Silence GCC unused-variable warning.

Luint*, const GLuint*, const ubyte*, const ubyte*, boolean, boolean)': st_glsl_to_tgsi.cpp:5461:36: warning: unused variable 'pscreen' [-Wunused-variable] struct pipe_screen *pscreen = st->pipe->screen; ^ Signed-off-by:

[Mesa-dev] [PATCH] ABI-check: Use more portable bash invocation.

Fixes 'make check' on FreeBSD. Signed-off-by: Vinson Lee --- src/mapi/es1api/ABI-check | 2 +- src/mapi/es2api/ABI-check | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mapi/es1api/ABI-check b/src/mapi/es1api/ABI-check index 44654cd..819568f 100755 ---

[Mesa-dev] [PATCH] radeon: Silence GCC unused-but-set-variable warnings.

on 'radeon_unmap_renderbuffer': radeon_fbo.c:419:14: warning: variable 'ok' set but not used [-Wunused-but-set-variable] GLboolean ok; ^ Signed-off-by: Vinson Lee --- src/mesa/drivers/dri/radeon/radeon_fbo.c | 6 +- 1 file changed, 5 insertions(+), 1 deleti

[Mesa-dev] [PATCH] nir: Silence GCC maybe-uninitialized warnings.

in this function [-Wmaybe-uninitialized] *_before = before; ^ Signed-off-by: Vinson Lee --- src/glsl/nir/nir_control_flow.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/glsl/nir/nir_control_flow.c b/src/glsl/nir/nir_control_flow.c index 7f51c4f..96395a4

[Mesa-dev] [PATCH] glapi: Do not use backtrace on FreeBSD.

Fix build error. CCLD libGL.la libglapi.a(glapi_libglapi_la-glapi_gentable.o): In function `__glapi_gentable_NoOp': glapi_gentable.c:76: undefined reference to `backtrace' Signed-off-by: Vinson Lee --- src/mapi/glapi/gen/gl_gentable.py | 2 +- 1 file changed, 1 insertion(+),

Re: [Mesa-dev] [PATCH] glapi: Do not use backtrace on FreeBSD.

On Thu, Feb 5, 2015 at 4:02 AM, Ian Romanick wrote: > On 01/24/2015 05:46 AM, Vinson Lee wrote: >> Fix build error. >> >> CCLD libGL.la >> libglapi.a(glapi_libglapi_la-glapi_gentable.o): In function >> `__glapi_gentable_NoOp': >> glapi_gent

[Mesa-dev] [PATCH] scons: Define _DEFAULT_SOURCE.

Fix GCC cpp warnings with glibc >= 2.19. /usr/include/features.h:148:3: warning: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Wcpp] # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" ^ Signed-off-by:

Re: [Mesa-dev] [PATCH] scons: Define _DEFAULT_SOURCE.

On Sun, Mar 1, 2015 at 8:52 AM, Emil Velikov wrote: > On 01/03/15 08:49, Vinson Lee wrote: >> Fix GCC cpp warnings with glibc >= 2.19. >> >> /usr/include/features.h:148:3: warning: #warning "_BSD_SOURCE and >> _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE&

[Mesa-dev] [PATCH] c99_alloca.h: Include stdlib.h on all non-Windows.

Fix build on FreeBSD. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89364 Signed-off-by: Vinson Lee --- include/c99_alloca.h | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/include/c99_alloca.h b/include/c99_alloca.h index 7a81c50..575f719 100644 --- a/include

[Mesa-dev] [PATCH] glsl: Fix GCC unused-variable warning in release build.

= ^ Signed-off-by: Vinson Lee --- src/glsl/ast_array_index.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/glsl/ast_array_index.cpp b/src/glsl/ast_array_index.cpp index ff0c757..ecef651 100644 --- a/src/glsl/ast_array_index.cpp +++ b/src/glsl

[Mesa-dev] [PATCH] i915: Fix GCC unused-variable warning in release build.

i915_debug_fp.c: In function ‘i915_disassemble_program’: i915_debug_fp.c:302:11: warning: unused variable ‘size’ [-Wunused-variable] GLuint size = program[0] & 0x1ff; ^ Signed-off-by: Vinson Lee --- src/mesa/drivers/dri/i915/i915_debug_fp.c | 3 +-- 1 file changed, 1 inser

[Mesa-dev] [PATCH] i915: Fix GCC unused-but-set-variable warning in release build.

i915_fragprog.c: In function ‘i915ValidateFragmentProgram’: i915_fragprog.c:1453:11: warning: variable ‘k’ set but not used [-Wunused-but-set-variable] int k; ^ Signed-off-by: Vinson Lee --- src/mesa/drivers/dri/i915/i915_fragprog.c | 5 + 1 file changed, 1 insertion

[Mesa-dev] [PATCH] i965: Silence GCC maybe-uninitialized warning.

.ud; ^ Signed-off-by: Vinson Lee --- src/mesa/drivers/dri/i965/brw_shader.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers/dri/i965/brw_shader.cpp index f2b4d82..ff0ef4b 100644 --- a/src/mesa/drivers/

[Mesa-dev] [PATCH] radeon: Fix GCC unused-but-set-variable warnings.

: variable ‘ok’ set but not used [-Wunused-but-set-variable] GLboolean ok; ^ Signed-off-by: Vinson Lee --- src/mesa/drivers/dri/radeon/radeon_fbo.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/mesa/drivers/dri/radeon/radeon_fbo.c b/src/mesa/drivers/dri

[Mesa-dev] [PATCH] egl/dri2: Fix GCC maybe-uninitialized warning.

egl_dri2.c: In function ‘dri2_bind_tex_image’: egl_dri2.c:1240:4: warning: ‘format’ may be used uninitialized in this function [-Wmaybe-uninitialized] (*dri2_dpy->tex_buffer->setTexBuffer2)(dri2_ctx->dri_context, ^ Signed-off-by: Vinson Lee --- src/egl/drivers/dri2/egl_dri2.c

[Mesa-dev] [PATCH] nv30: Remove unused function nv40_fp_bra.

Fix GCC unused-function warning. nv30/nvfx_fragprog.c:333:1: warning: ‘nv40_fp_bra’ defined but not used [-Wunused-function] nv40_fp_bra(struct nvfx_fpc *fpc, unsigned target) ^ Signed-off-by: Vinson Lee --- src/gallium/drivers/nouveau/nv30/nvfx_fragprog.c | 26 1

[Mesa-dev] [PATCH] nouveau: Silence GCC maybe-uninitialized warnings.

ed in this function [-Wmaybe-uninitialized] for (i = 0; i < size; i += 4) { ^ Signed-off-by: Vinson Lee --- src/gallium/drivers/nouveau/nouveau_compiler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/nouveau_compiler.c b/src/gallium/dr

[Mesa-dev] [PATCH v2] nv30: Add unused attribute to function nv40_fp_bra.

Silences GCC unused-function warning. nv30/nvfx_fragprog.c:333:1: warning: ‘nv40_fp_bra’ defined but not used [-Wunused-function] nv40_fp_bra(struct nvfx_fpc *fpc, unsigned target) ^ Signed-off-by: Vinson Lee --- src/gallium/drivers/nouveau/nv30/nvfx_fragprog.c | 2 +- 1 file changed, 1

[Mesa-dev] [PATCH v2] egl/dri2: Fix GCC maybe-uninitialized warning.

egl_dri2.c: In function ‘dri2_bind_tex_image’: egl_dri2.c:1240:4: warning: ‘format’ may be used uninitialized in this function [-Wmaybe-uninitialized] (*dri2_dpy->tex_buffer->setTexBuffer2)(dri2_ctx->dri_context, ^ Suggested-by: Ilia Mirkin Signed-off-by: Vinson Lee ---

[Mesa-dev] [PATCH v2] nouveau: Silence GCC maybe-uninitialized warnings.

ed in this function [-Wmaybe-uninitialized] for (i = 0; i < size; i += 4) { ^ Signed-off-by: Vinson Lee --- src/gallium/drivers/nouveau/nouveau_compiler.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/nouveau/nouveau_compiler.c b/src/gallium/dr

[Mesa-dev] [PATCH v2] nouveau: Silence GCC maybe-uninitialized warnings.

ed in this function [-Wmaybe-uninitialized] for (i = 0; i < size; i += 4) { ^ Signed-off-by: Vinson Lee --- src/gallium/drivers/nouveau/nouveau_compiler.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/nouveau/nouveau_compiler.c b/src/gallium/dr

[Mesa-dev] [PATCH] Add macro for unused function attribute.

Suggested-by: Emil Velikov Signed-off-by: Vinson Lee --- configure.ac | 1 + scons/gallium.py | 1 + src/util/macros.h | 6 ++ 3 files changed, 8 insertions(+) diff --git a/configure.ac b/configure.ac index 90c7737..2954f80 100644 --- a/configure.ac +++ b/configure.ac @@ -195,6

[Mesa-dev] [PATCH] configure: Only require libdrm 2.4.75 for intel.

Fixes: b8acb6b17981 ("configure: Require libdrm >= 2.4.75") Signed-off-by: Vinson Lee --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 92339b4..d4302bf 100644 --- a/configure.ac +++ b/configure.ac @@

Re: [Mesa-dev] [PATCH] configure: Only require libdrm 2.4.75 for intel.

On Wed, Feb 1, 2017 at 4:10 PM, Emil Velikov wrote: > On 1 February 2017 at 23:28, Vinson Lee wrote: >> Fixes: b8acb6b17981 ("configure: Require libdrm >= 2.4.75") >> Signed-off-by: Vinson Lee > Are you sure that's correct ? > > Afaict the follow-up co

Re: [Mesa-dev] [PATCH] swr: [rasterizer core] Remove dead code Clipper::ClipScalar()

Tested-by: Vinson Lee On Thu, Feb 2, 2017 at 12:42 PM, Cherniak, Bruce wrote: > I followed up with a v2 that includes the bugzilla reference. > > Good point, I’ll look into following up with a patch to remove Clip(). > > Thanks for the quick review. > >> On Feb 2, 2017,

[Mesa-dev] [PATCH] glsl: Fix missing-braces warning.

CXXglsl/ast_to_hir.lo glsl/ast_to_hir.cpp: In member function 'virtual ir_rvalue* ast_declarator_list::hir(exec_list*, _mesa_glsl_parse_state*)': glsl/ast_to_hir.cpp:4846:42: warning: missing braces around initializer for 'unsigned int [16]' [-Wmissing-braces] Signe

[Mesa-dev] [PATCH] util/disk_cache: Use backward compatible st_mtime.

how_bug.cgi?id=99918 Fixes: 207e3a6e4b ("util/radv: move *_get_function_timestamp() to utils") Signed-off-by: Vinson Lee --- src/util/disk_cache.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/disk_cache.h b/src/util/disk_cache.h index 7f4da809cc..b7

[Mesa-dev] [PATCH] glsl: Fix missing-braces warning.

CXXglsl/ast_to_hir.lo glsl/ast_to_hir.cpp: In member function 'virtual ir_rvalue* ast_declarator_list::hir(exec_list*, _mesa_glsl_parse_state*)': glsl/ast_to_hir.cpp:4846:42: warning: missing braces around initializer for 'unsigned int [16]' [-Wmissing-braces] Signe

Re: [Mesa-dev] [PATCH] st/nine: Remove code for no USER_INDEX_BUFFERS as these are always on

m_vtxbuf_idxbuf(This, > PrimitiveType, > -- > 2.11.1 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99953 Fixes: 4a883966c1f7 ("gallium: remove PIPE_CAP_USER_INDEX_BUFFERS") Tested-by: Vinson Lee ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] glx/tests: Fix bash-specific code in dispatch-index-check

27;s#// ##;s/ implemented by > [a-z]\+//') > > # remove LAST_INDEX, as it will not be in alphabetical order > -dispatch_list=$(sed '/LAST_INDEX/d' <<< "$dispatch_list") > +dispatch_list=$(printf "$dispatch_list" | sed '/LAST_INDEX/d') > > -sorted=$(LC_

[Mesa-dev] [PATCH] pipebuffer: Silence GCC unused-but-set-variable warning.

pb_buffer_fenced.c: In function 'fenced_buffer_fence': pb_buffer_fenced.c:849:18: warning: variable 'destroyed' set but not used [-Wunused-but-set-variable] boolean destroyed; ^ Signed-off-by: Vinson Lee --- src/gallium/auxiliary/pipebuffer/pb

[Mesa-dev] [PATCH] gallium/util: Silence GCC unused-but-set-variable warning.

u_surface.c: In function 'util_resource_copy_region': u_surface.c:257:21: warning: variable 'src_format' set but not used [-Wunused-but-set-variable] enum pipe_format src_format, dst_format; ^ Signed-off-by: Vinson Lee --- src/gallium/auxiliary/

[Mesa-dev] [PATCH] gallivm: Fix GCC unused-variable warning.

lp_bld_tgsi_soa.c: In function 'lp_emit_immediate_soa': lp_bld_tgsi_soa.c:3065:18: warning: unused variable 'size' [-Wunused-variable] const uint size = imm->Immediate.NrTokens - 1; ^ Signed-off-by: Vinson Lee --- src/gallium/auxiliary/galliv

[Mesa-dev] [PATCH] draw: Silence GCC unused-variable warnings.

t' [-Wunused-variable] LLVMTargetDataRef target = gallivm->target; ^ Signed-off-by: Vinson Lee --- src/gallium/auxiliary/draw/draw_llvm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/auxiliary/draw/draw_llvm.c b/src/gallium/auxiliary/draw/draw_

Re: [Mesa-dev] [PATCH] gallium/util: Silence GCC unused-but-set-variable warning.

On Wed, Jul 29, 2015 at 8:33 PM, Matt Turner wrote: > On Wed, Jul 29, 2015 at 8:12 PM, Vinson Lee wrote: >> u_surface.c: In function 'util_resource_copy_region': >> u_surface.c:257:21: warning: variable 'src_format' set but not used >> [-Wunused-

[Mesa-dev] [PATCH] vl/mpeg12: Silence GCC unused-variable warning.

vl/vl_mpeg12_bitstream.c: In function 'decode_slice': vl/vl_mpeg12_bitstream.c:928:19: warning: unused variable 'extra' [-Wunused-variable] unsigned extra = vl_vlc_get_uimsbf(&bs->vlc, 1); ^ Signed-off-by: Vinson Lee --

[Mesa-dev] [PATCH] scons: Always define __STDC_LIMIT_MACROS.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91591 Signed-off-by: Vinson Lee --- scons/gallium.py | 1 + 1 file changed, 1 insertion(+) diff --git a/scons/gallium.py b/scons/gallium.py index 51b84d7..46dbf0e 100755 --- a/scons/gallium.py +++ b/scons/gallium.py @@ -300,6 +300,7 @@ def

[Mesa-dev] [PATCH] ABI-check: Use more portable bash invocation.

Fixes 'make check' on FreeBSD. Signed-off-by: Vinson Lee --- src/mapi/es1api/ABI-check | 2 +- src/mapi/es2api/ABI-check | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mapi/es1api/ABI-check b/src/mapi/es1api/ABI-check index 44654cd..819568f 100755 ---

[Mesa-dev] [PATCH] Revert "mesa_glinterop: remove inclusion of GLX header"

: redefinition of typedef ‘GLXContext’ include/GL/glx.h:165: note: previous declaration of ‘GLXContext’ was here Fixes: 8472045b16b3 ("mesa_glinterop: remove inclusion of GLX header") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96770 Signed-off-by: Vinson Lee ---

[Mesa-dev] [PATCH] glsl: Add missing cache_destroy stub function.

itial functions to implement an on-disk cache") Signed-off-by: Vinson Lee --- src/compiler/glsl/cache.h | 5 + 1 file changed, 5 insertions(+) diff --git a/src/compiler/glsl/cache.h b/src/compiler/glsl/cache.h index 78df32b6c54e..d804169c6561 100644 --- a/src/compiler/glsl/cache.h +++ b/sr

Re: [Mesa-dev] [PATCH] mesa_glinterop: allow building without X and related headers

rop header they ensure that the X (or others > in terms of EGL) headers are included, which ensures that everything is > resolved within the compilation unit. > > Cc: Vinson Lee > Cc: "12.0" > Cc: Tapani Pälli > Cc: Chih-Wei Huang > Fixes: c10dcb2ce837 (&

Re: [Mesa-dev] [PATCH] glcpp: Update tests for new #undef of built-in macro rules.

def-builtin-allowed.c.expected > b/src/compiler/glsl/glcpp/tests/147-undef-builtin-allowed.c.expected > new file mode 100644 > index 000..cd0071f > --- /dev/null > +++ b/src/compiler/glsl/glcpp/tests/147-undef-builtin-allowed.c.expected > @@ -0,0 +1,4 @@ > +#version

[Mesa-dev] [PATCH] glsl: Add positional argument specifiers.

format Fixes: e31c72a331b1 ("glsl: Convert tuple into a class") Signed-off-by: Vinson Lee --- src/compiler/glsl/ir_expression_operation.py | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/compiler/glsl/ir_expression_operation.py b/src/compiler/glsl/ir

[Mesa-dev] [PATCH] util: Include string.h in bitscan.h.

6:18: note: previous declaration is here const int i = ffs(*mask) - 1; ^ src/util/bitscan.h:51:13: note: expanded from macro 'ffs' ^ Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97952 Signed-off-by: Vinson Lee --- src/util/bitscan.h | 1

[Mesa-dev] [PATCH] scons: Require libdrm >= 2.4.65 for DRM.

("scons: loader: use libdrm when available") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=98421 Signed-off-by: Vinson Lee --- scons/gallium.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scons/gallium.py b/scons/gallium.py index 9f7555cf8bce..8cf6cc732

[Mesa-dev] [PATCH] util: Fix Clang trivial destructor check.

lla: https://bugs.freedesktop.org/show_bug.cgi?id=98526 Signed-off-by: Vinson Lee --- src/util/macros.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/util/macros.h b/src/util/macros.h index 0563fa59b595..733bf42c 100644 --- a/src/util/macros.h +++ b/src/util/macros.h

Re: [Mesa-dev] [PATCH v2] clover: restore support for LLVM <= 3.9

On Wed, Nov 16, 2016 at 10:10 AM, Jan Vesely wrote: > On Wed, 2016-11-16 at 12:29 +0100, Vedran Miletić wrote: >> The commit 8e430ff8b060b4e8e922bae24b3c57837da6ea77 support for LLVM >> 3.9 and older versionsin Clover. This patch restores it and refactors >> the support using Clover compatibility

Re: [Mesa-dev] [PATCH v4] clover: restore support for LLVM <= 3.9

; + ::llvm::handleAllErrors(std::move(err), > [&](::llvm::ErrorInfoBase &EIB) { > + fail(r_log, error(CL_INVALID_PROGRAM), > EIB.message().c_str()); > + }); > +} > +#else > +if (!mod) > + fail(r_log, error(CL_INVALID_PROGRAM), > mod.getError().message()); > +#endif > + } >} > } > } > -- > 2.7.4 > This patch fixes builds with llvm-3.8. Tested-by: Vinson Lee ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/6] mesa: remove trailing whitespace in errors.c

mat string, followed by optional args. > */ > -- > 1.9.1 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev Reviewed-by: Vinson Lee ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/6] mesa: remove unneeded #includes in errors.c

uot; > -#include "util/hash_table.h" > -#include "util/simple_list.h" > > > static FILE *LogFile = NULL; > -- > 1.9.1 > > _______ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.

Re: [Mesa-dev] [PATCH 3/6] i915: remove unneeded #include "util/simple_list.h"

lude "intel_context.h" > -- > 1.9.1 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/mesa-dev Reviewed-by: Vinson Lee ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 4/6] r200: remove unneeded #include "util/simple_list.h"

0ddb686 100644 > --- a/src/mesa/drivers/dri/r200/r200_tex.c > +++ b/src/mesa/drivers/dri/r200/r200_tex.c > @@ -36,7 +36,6 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE > SOFTWARE. > #include "main/context.h" > #include "main/enums.h" > #include "main/image.h" > -

Re: [Mesa-dev] [PATCH 5/6] radeon: remove unneeded #include "util/simple_list.h"

rs/dri/radeon/radeon_tex.c > +++ b/src/mesa/drivers/dri/radeon/radeon_tex.c > @@ -36,7 +36,6 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE > SOFTWARE. > #include "main/context.h" > #include "main/enums.h" > #include "main/image.h" > -

Re: [Mesa-dev] [PATCH 6/6] tnl: remove unneeded #include "util/simple_list.h"

x_sse.c > @@ -29,7 +29,6 @@ > > #include "main/glheader.h" > #include "main/context.h" > -#include "util/simple_list.h" > #include "main/enums.h" > #include "swrast/s_chan.h" > #include "t_con

Re: [Mesa-dev] [PATCH v5] clover: restore support for LLVM <= 3.9

cks > v3: added support for LLVM 3.6-3.8 > v4: add missing #ifdef around > v5: simplify using templates and lambda > > Signed-off-by: Vedran Miletić > Reviewed-by[v2]: Jan Vesely > Tested-by[v4]: Vinson Lee > Tested-by[v4]: Pierre Moreau > Reviewed-by: Francisco Jere

[Mesa-dev] [PATCH] scons: Recognize LLVM_CONFIG environment variable.

Signed-off-by: Vinson Lee --- scons/llvm.py | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/scons/llvm.py b/scons/llvm.py index 977e47a..a27bf00 100644 --- a/scons/llvm.py +++ b/scons/llvm.py @@ -194,11 +194,16 @@ def generate(env

[Mesa-dev] [PATCH v2] scons: Recognize LLVM_CONFIG environment variable.

Signed-off-by: Vinson Lee Reviewed-by: Emil Velikov --- v2 Use LLVM_CONFIG for swr too. Update common.py. Use local variable llvm_config instead of env['LLVM_CONFIG']. common.py | 2 +- scons/llvm.py | 17 + src/gallium/d

[Mesa-dev] [PATCH] configure.ac: Strip patch version from LLVM version.

HAVE_LLVM variable included the patch version if the LLVM version had a patch version. For LLVM version '4.0.0', HAVE_LLVM would be '0x0400.0'. Fixes: 45574ab2e92f ("configure.ac: better detection of LLVM version") Signed-off-by: Vinson Lee --- configure.ac | 2 +

[Mesa-dev] [PATCH] llvmpipe: Link tests with CLOCK_LIB.

Fix linking error with 'make check'. CXXLD lp_test_format ../../../../src/gallium/auxiliary/.libs/libgallium.a(os_time.o): In function `os_time_get_nano': /home/jenkins/workspace/mesa/src/gallium/auxiliary/os/os_time.c:59: undefined reference to `clock_gettime' Signe

Re: [Mesa-dev] [PATCH] configure.ac: Strip patch version from LLVM version.

> Tobias > > Am Samstag, 3. Dezember 2016, 01:20:42 CET schrieb Vinson Lee: >> HAVE_LLVM variable included the patch version if the LLVM version had a >> patch version. >> >> For LLVM version '4.0.0', HAVE_LLVM would be '0x0400.0'. >> >

Re: [Mesa-dev] [PATCH] configure.ac: Strip patch version from LLVM version.

n? > > Do you set "--with-llvm-prefix=" when building mesa? > > > > Tobias > > > > Am Samstag, 3. Dezember 2016, 11:53:53 CET schrieb Vinson Lee: > >> Hi, Tobias. > >> > >> I actually need this when using LLVM from a build tree and th

[Mesa-dev] [PATCH v2] mesa/st: Use 'struct nir_shader' instead of 'nir_shader'.

’ was here Suggested-by: Rob Clark Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96235 Signed-off-by: Vinson Lee --- src/mesa/state_tracker/st_nir.h | 12 ++-- src/mesa/state_tracker/st_nir_lower_builtin.c |6 +++--- 2 files changed, 9 insertions(+), 9 deletions

[Mesa-dev] [PATCH v3] mesa/st: Use 'struct nir_shader' instead of 'nir_shader'.

’ was here Suggested-by: Rob Clark Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96235 Signed-off-by: Vinson Lee Reviewed-by: Jason Ekstrand --- v3 - Removed st_nir_lower_builtin.c changes. src/mesa/state_tracker/st_nir.h | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions

[Mesa-dev] [PATCH] nouveau/codegen: Initialize dst0 array in Converter::handleInstruction.

dst0 is not initialized if tgsi.dstCount() is false. Fixes "Uninitialized pointer read" defect reported by Coverity. Signed-off-by: Vinson Lee --- src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/galli

[Mesa-dev] [PATCH] nouveau: Explicitly upcast operands so mulitplication is 64-bit.

Fixes "Unintentional integer overflow" defects reported by Coverity. Signed-off-by: Vinson Lee --- src/gallium/drivers/nouveau/nouveau_vp3_video.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/nouveau/nouveau_vp3_video.h b/src/galli

[Mesa-dev] [PATCH v2] nv30: Clear dirty bit for processed samplers.

Otherwise, the while(dirty) loop will never exit. Fixes "Infinite loop" defect reported by Coverity. Signed-off-by: Vinson Lee --- src/gallium/drivers/nouveau/nv30/nv40_verttex.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/nouveau/nv30/nv40_vertte

[Mesa-dev] [PATCH] llvmpipe: Remove unnecessary null check of shader.

shader has already been dereferenced earlier so cannot be null here. Fixes "Dereference before null check" defect reported by Coverity. Signed-off-by: Vinson Lee --- src/gallium/drivers/llvmpipe/lp_state_fs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/s

[Mesa-dev] [PATCH] nvc0: Remove unused pointer value cfg.

cfg is only used inside for loop so also move declaration there. Fixes "Unused pointer value" defect reported by Coverity. Signed-off-by: Vinson Lee --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/galli

[Mesa-dev] [PATCH] draw: Add a null check for draw.

There is an earlier null check for draw so draw could be null here as well. Fixes "Dereference after null check" defect reported by Coverity. Signed-off-by: Vinson Lee --- src/gallium/auxiliary/draw/draw_pipe_unfilled.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[Mesa-dev] [PATCH] i915: Fix memory leak in do_blit_readpixels.

Fixes "Resource leak" defect reported by Coverity. Signed-off-by: Vinson Lee --- src/mesa/drivers/dri/i915/intel_pixel_read.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i915/intel_pixel_read.c b/src/mesa/drivers/dri/i915/intel_pixel_read.c index 26eb49

[Mesa-dev] [PATCH v2] i915, i965: Fix memory leak in intel_miptree_create_for_bo.

Fixes "Resource leak" defects reported by Coverity. Signed-off-by: Vinson Lee --- src/mesa/drivers/dri/i915/intel_mipmap_tree.c | 4 +++- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/mesa/driver

[Mesa-dev] [PATCH v2] i965: Initialize brw_blorp_const_color_program::prog_data.

Fixes "Uninitialized scalar field" defect reported by Coverity. Signed-off-by: Vinson Lee --- src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_clear.cpp b/src/mesa/drivers/dri/i965/brw_blorp_clear

[Mesa-dev] [PATCH] util/u_format: Assert that format block size is at least 1 byte.

The block size for all formats is currently at least 1 byte. Add an assertion for this. This should silence several Coverity "Division or modulo by zero" defects. Signed-off-by: Vinson Lee --- src/gallium/auxiliary/util/u_format.h | 7 ++- 1 file changed, 6 insertions(+),

[Mesa-dev] [PATCH] r600g/sb: Move variable dereference after null check.

Fixes "Deference before null check" defect reported by Coverity. Signed-off-by: Vinson Lee --- src/gallium/drivers/r600/sb/sb_ra_init.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/sb/sb_ra_init.cpp b/src/gallium/drive

[Mesa-dev] [PATCH] r600g: Prevent by invalid op overflows in release builds.

Fixes "Overflowed return value" defects reported by Coverity. Signed-off-by: Vinson Lee --- src/gallium/drivers/r600/r600_isa.h | 9 + 1 file changed, 9 insertions(+) diff --git a/src/gallium/drivers/r600/r600_isa.h b/src/gallium/drivers/r600/r600_isa.h index c6bb869..5b9c

[Mesa-dev] [PATCH] r600g: Add missing break for callstack_push FC_PUSH_WQM case.

Fixes "Missing break in switch" reported by Coverity. Signed-off-by: Vinson Lee --- src/gallium/drivers/r600/r600_shader.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index ce15cd7..d6cbfd7 100644

Re: [Mesa-dev] Janitorial work: no more intel_context.[ch]; tidying

On Mon, Sep 30, 2013 at 10:21 PM, Kenneth Graunke wrote: > On 09/27/2013 06:24 PM, Emil Velikov wrote: >> On 28/09/13 00:45, Kenneth Graunke wrote: >>> This series combines brw_context.[ch] and intel_context.[ch], >>> and cleans up our context creation code quite a bit. A bunch of >>> functionali

Re: [Mesa-dev] [PATCHv2] configure: set HAVE_COMMON_DRI when building only swrast

ication work of dri and drisw, it makes > sense just to revert the offending hunk. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=70057 > Reported-by: Vinson Lee > Signed-off-by: Emil Velikov > --- > v2: resolve typos in the commit message. Thanks Ian > >

[Mesa-dev] [PATCH] glsl: Link glcpp with math library.

prog_hash_table.o Signed-off-by: Vinson Lee --- src/glsl/Makefile.am |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/glsl/Makefile.am b/src/glsl/Makefile.am index cbf253c..05b6759 100644 --- a/src/glsl/Makefile.am +++ b/src/glsl/Makefile.am @@ -93,7 +93,9

[Mesa-dev] [PATCH] glapi: Do not include dlfcn.h on Windows.

This patch fixes this MinGW build error. CC glapi_gentable.lo glapi_gentable.c:47:19: fatal error: dlfcn.h: No such file or directory Signed-off-by: Vinson Lee --- src/mapi/glapi/gen/gl_gentable.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mapi/glapi/gen/gl_gentable.py b

[Mesa-dev] [PATCH] glsl: Use more portable bash invocation construct.

Fixes 'make check' on distros where bash is not at /bin/bash. Signed-off-by: Vinson Lee --- src/glsl/tests/lower_jumps/create_test_cases.py | 2 +- src/glsl/tests/lower_jumps/lower_breaks_1.opt_test | 2 +- src/glsl/tests/lower_jumps/lowe

[Mesa-dev] [PATCH] glsl: Initialize per_vertex_accumluator::fields.

Fixes "Uninitialized pointer field" defect reported by Coverity. Signed-off-by: Vinson Lee --- src/glsl/builtin_variables.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp index ae0a03f..3f87502 10

Re: [Mesa-dev] [PATCH] scons: Simplified fix of llvm cxxflags

.version.LooseVersion('3.1'): > -- > 1.8.4 > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev Fixes the build failure again for me. Tested-by: Vinson Lee ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] r600g/sb: Initialize shader::dce_flags.

Fixes "Uninitialized scalar field" defect reported by Coverity. Signed-off-by: Vinson Lee --- src/gallium/drivers/r600/sb/sb_shader.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/sb/sb_shader.cpp b/src/gallium/drivers/r600/sb/sb_

[Mesa-dev] [PATCH] i965: Initialize vec4_visitor member variables.

Fixes "Uninitialized pointer field" defect reported by Coverity. Signed-off-by: Vinson Lee --- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp b/src/mesa/driver

[Mesa-dev] [PATCH] radeon: Reference miptree after checking if it is null.

Fixes "Dereference before null check" defect reported by Coverity. Signed-off-by: Vinson Lee --- src/mesa/drivers/dri/radeon/radeon_texture.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/radeon/radeon_texture.c b/src/mesa/drivers/

[Mesa-dev] [PATCH v2] i915, i965: Fix memory leak in intel_miptree_create_for_bo.

Fixes "Resource leak" defects reported by Coverity. Signed-off-by: Vinson Lee --- src/mesa/drivers/dri/i915/intel_mipmap_tree.c | 4 +++- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/mesa/driver

[Mesa-dev] [PATCH] i915: Fix logic_op check.

logic_op is of type GLenum (unsigned int). Fixes "Macro compares unsigned to 0" defect reported by Coverity. Signed-off-by: Vinson Lee --- src/mesa/drivers/dri/i915/intel_blit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i915/intel_bli

[Mesa-dev] [PATCH] svga: Remove svga_hwtnl_simple_draw_range_elements dead code.

Remove dead code left behind by commit 8d7b913e4e089cc8b0b800cbcf80737d0be0a0f7. Fixes "Logically dead code" defect reported by Coverity. Signed-off-by: Vinson Lee --- src/gallium/drivers/svga/svga_draw_elements.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/galli

[Mesa-dev] [PATCH] i965: Initialize schedule_node::delay.

Fixes "Uninitialized scalar field" defect reported by Coverity. Signed-off-by: Vinson Lee --- src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp b/src/mesa/driver

[Mesa-dev] [PATCH] r600g: Add missing break for callstack_push FC_PUSH_WQM case.

Fixes "Missing break in switch" reported by Coverity. Signed-off-by: Vinson Lee --- src/gallium/drivers/r600/r600_shader.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index ce15cd7..d6cbfd7 100644

[Mesa-dev] [PATCH] r600g: Prevent invalid op overflows in release builds.

Fixes "Overflowed return value" defects reported by Coverity. Signed-off-by: Vinson Lee --- src/gallium/drivers/r600/r600_isa.h | 9 + 1 file changed, 9 insertions(+) diff --git a/src/gallium/drivers/r600/r600_isa.h b/src/gallium/drivers/r600/r600_isa.h index c6bb869..5b9c

[Mesa-dev] [PATCH] nvc0: Remove unused pointer value cfg.

cfg is only used inside for loop so also move declaration there. Fixes "Unused pointer value" defect reported by Coverity. Signed-off-by: Vinson Lee --- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/galli

[Mesa-dev] [PATCH] gallivm: Remove llvm::DisablePrettyStackTrace for LLVM >= 3.4.

LLVM 3.4 r193971 removed llvm::DisablePrettyStackTrace and made the pretty stack trace opt-in rather than opt-out. Signed-off-by: Vinson Lee --- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp b

[Mesa-dev] [PATCH] i965: Add missing break in SHADER_OPCODE_GEN7_SCRATCH_READ case.

Fixes "Missing break in switch" defect reported by Coverity. Signed-off-by: Vinson Lee --- src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp b/src/mesa/driver

[Mesa-dev] [PATCH] gallivm: Ignore unknown file type in non-debug builds.

Fixes "Uninitialized pointer read" defect reported by Coverity. Signed-off-by: Vinson Lee --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c b/src/gallium/auxiliary/gallivm/lp_bld_

[Mesa-dev] [PATCH] glsl: Link glcpp with math library.

prog_hash_table.o Signed-off-by: Vinson Lee --- src/glsl/Makefile.am |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/glsl/Makefile.am b/src/glsl/Makefile.am index cbf253c..05b6759 100644 --- a/src/glsl/Makefile.am +++ b/src/glsl/Makefile.am @@ -93,7 +93,9

  1   2   3   4   5   6   >