Re: [Mesa-dev] st/mesa: implement new DMA-buf based VDPAU interop v2 - REGRESSION on r600

2016-03-29 Thread Thomas H.P. Andersen
On Wed, Mar 30, 2016 at 6:36 AM, Dieter Nützel wrote: > Hello Christian, > > after all this new VDPAU stuff, I get after ages (months/years) only > black window with > > mplayer -vo vdpau /data/Filme/test.mkv > > on r600, NI, Turks XT. > > Switching between full screen and window mode ('F') the i

Re: [Mesa-dev] [PATCH] st/vdpau: correct null check

2016-03-30 Thread Thomas H.P. Andersen
On Wed, Mar 30, 2016 at 9:26 AM, Christian König wrote: > Am 30.03.2016 um 08:13 schrieb Thomas Hindoe Paaboel Andersen: > >> The null check of result was the wrong way around. Also, move memset >> and dereference of result after the null check. >> --- >> src/gallium/state_trackers/vdpau/surfac

Re: [Mesa-dev] [PATCH] st/va: avoid dereference after free

2016-04-06 Thread Thomas H.P. Andersen
On Sun, Mar 6, 2016 at 10:08 AM, Thomas H.P. Andersen wrote: > > > On Sat, Mar 5, 2016 at 1:30 PM, Emil Velikov > wrote: > >> Hi Thomas, >> >> On 5 March 2016 at 12:07, Thomas Hindoe Paaboel Andersen >> wrote: >> > --- >> > src/galliu

Re: [Mesa-dev] [PATCH 1/2] tgsi: fix buffer overflow

2016-04-12 Thread Thomas H.P. Andersen
On Wed, Apr 13, 2016 at 3:29 AM, wrote: > This series is, > > Reviewed-by: Edward O'Callaghan > > Thanks Edward. I do not have commit access so I need someone to push it for me. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.fr

Re: [Mesa-dev] [PATCH] mesa: use sizeof on the correct type

2016-02-23 Thread Thomas H.P. Andersen
On Tue, Feb 23, 2016 at 1:05 AM, Brian Paul wrote: > On 02/22/2016 03:58 PM, Thomas Hindoe Paaboel Andersen wrote: > >> Before the luminance stride was based on the size of GL_FLOAT >> which is just the type constant (0x1406). Change it to use the >> size of GLfloat. >> --- >> src/mesa/main/rea

Re: [Mesa-dev] [PATCH] anv: remove stray ; after if

2016-02-26 Thread Thomas H.P. Andersen
On Fri, Feb 26, 2016 at 7:54 AM, Jason Ekstrand wrote: > > On Feb 25, 2016 5:33 PM, "Matt Turner" wrote: > > > > Indeed, that looks like a mistake. > > Yes, yes it is. Good catch. > > Reviewed-by: Jason Ekstrand > Thanks. Can I ask one of you to push it? __

Re: [Mesa-dev] [PATCH 1/2] st/mesa: move dereference after null check

2016-03-01 Thread Thomas H.P. Andersen
On Wed, Mar 2, 2016 at 12:33 AM, Brian Paul wrote: > On 03/01/2016 02:45 PM, Thomas Hindoe Paaboel Andersen wrote: > >> We should not dereference shader before we have done the >> null check. >> --- >> src/mesa/state_tracker/st_atom_image.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 delet

Re: [Mesa-dev] [PATCH] st/va: avoid dereference after free

2016-03-06 Thread Thomas H.P. Andersen
On Sat, Mar 5, 2016 at 1:30 PM, Emil Velikov wrote: > Hi Thomas, > > On 5 March 2016 at 12:07, Thomas Hindoe Paaboel Andersen > wrote: > > --- > > src/gallium/state_trackers/va/image.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/src/gallium/state_trackers/v

Re: [Mesa-dev] [PATCH] amd/addrlib: use correct variable name in header

2017-04-09 Thread Thomas H.P. Andersen
On Sun, Apr 9, 2017 at 8:25 PM, Marek Olšák wrote: > Reviewed-by: Marek Olšák > > Marek Thanks. I do not have commit access, so will need someone to push it for me. > On Sat, Apr 8, 2017 at 8:36 AM, Thomas Hindoe Paaboel Andersen > wrote: >> Since the inclusion in 7f160efcde41b52ad78e562316384

Re: [Mesa-dev] [PATCH 2/9] radv: simplify if statement

2017-04-13 Thread Thomas H.P. Andersen
On Wed, Apr 12, 2017 at 12:50 AM, Bas Nieuwenhuizen wrote: > On Wed, Apr 12, 2017 at 12:48 AM, Dave Airlie wrote: >> On 12 April 2017 at 08:19, Bas Nieuwenhuizen >> wrote: >>> On Wed, Apr 12, 2017 at 12:04 AM, Thomas Hindoe Paaboel Andersen >>> wrote: --- src/amd/vulkan/radv_wsi.c |

Re: [Mesa-dev] [PATCH 1/3] nir/opt_dead_cf: correction of side effect check

2016-04-29 Thread Thomas H.P. Andersen
On Fri, Apr 29, 2016 at 8:39 PM, Jason Ekstrand wrote: > > > On Fri, Apr 29, 2016 at 11:31 AM, Thomas Hindoe Paaboel Andersen < > pho...@gmail.com> wrote: > >> Parenthesis are needed here as ! takes precedence over the &. The >> check had the opposite effect than intended. >> --- >> Not tested as

Re: [Mesa-dev] [PATCH] nir: fix check for wildcard pairs

2016-05-03 Thread Thomas H.P. Andersen
On Tue, May 3, 2016 at 9:46 PM, Ilia Mirkin wrote: > On Tue, May 3, 2016 at 3:32 PM, Thomas Hindoe Paaboel Andersen > wrote: > > It seems that the intention was to check both for null as they are > > dereferenced immediately after. > > > > Added in d3636da9 > > --- > > src/compiler/nir/nir_lowe

Re: [Mesa-dev] [PATCH v2] nir: fix assert for wildcard pairs

2016-05-04 Thread Thomas H.P. Andersen
On Wed, May 4, 2016 at 7:46 AM, Eduardo Lima Mitev wrote: > Good catch! > > Reviewed-by: Eduardo Lima Mitev > Thanks! I do not have commit access. Can I ask you to push? > > On 05/04/2016 05:48 AM, Thomas Hindoe Paaboel Andersen wrote: > > The assert was null checking dest_arr_parent twice. Th

Re: [Mesa-dev] [PATCH 3/3] mesa: remove null check before free

2016-05-04 Thread Thomas H.P. Andersen
On Wed, May 4, 2016 at 7:54 AM, Eduardo Lima Mitev wrote: > Patch 2 and 3 are: > > Reviewed-by: Eduardo Lima Mitev > Thanks! I do not have commit access. Can I ask you to push (again)? > > I barely know about coccinelle scripts so I will let others look at > first patch. > > Thanks > Eduardo