patches as well as OA
unit support can be found at https://github.com/rib/mesa - wip/rib/oa-next
Regards,
- Robert
Robert Bragg (3):
Separate INTEL_performance_query frontend
Model INTEL perf query backend after query object BE
i965: Implement INTEL_performance_query backend
src/mapi/glapi
e reworked.
Signed-off-by: Robert Bragg
---
src/mesa/drivers/dri/i965/Makefile.sources| 2 +
src/mesa/drivers/dri/i965/brw_context.c | 3 +
src/mesa/drivers/dri/i965/brw_context.h | 23 +
src/mesa/drivers/dri/i965/brw_performance_query.c | 595 ++
l Pitoiset)
- init PerfQuery.NumQueries in frontend
- s/return_string/output_clipped_string/
- s/backed/backend/ typo
- remove redundant *bytesWritten = 0
v3:
- Add InitPerfQueryInfo for lazy probing of available queries
Signed-off-by: Robert Bragg
---
src/mesa/main/dd.h| 41 +++
sr
this
separation intentionally copies what few helpers/utilities that were
shared between the two extensions, avoiding any re-factoring specific to
INTEL_performance_query so that the evolution will be easier to follow
later.
Signed-off-by: Robert Bragg
---
src/mapi/glapi/gen/gl_genexec.py
vailable, along with names, descriptions and semantic/data
types.
This code is derived from Kenneth Graunke's work, temporarily removed
while the frontend and backend interface were reworked.
Signed-off-by: Robert Bragg
---
src/mesa/drivers/dri/i965/Makefile.sources| 2 +
src/mes
On Wed, Feb 15, 2017 at 11:04 PM, Ilia Mirkin wrote:
> On Tue, Jan 24, 2017 at 5:27 PM, Robert Bragg wrote:
>>>>>> Depending on how strictly we consider that the queries should only
>>>>>> measure
>>>>>> the commands they bracket then I
On Wed, Feb 22, 2017 at 1:24 AM, Kenneth Graunke wrote:
> On Wednesday, February 15, 2017 1:37:36 PM PST Robert Bragg wrote:
>> Instead of using the same backend interface as AMD_performance_monitor
>> this defines a dedicated INTEL_performance_query interface that is
>>
On Wed, Feb 22, 2017 at 1:26 AM, Kenneth Graunke wrote:
> On Thursday, February 16, 2017 5:20:37 AM PST Robert Bragg wrote:
> [snip]
>> + switch(obj->query->kind) {
>
> Space after "switch" please.
Oh, oops, repeated that in a few places.
>
> Pa
Ideally would have caught these when adding the interface but this just
switches a few return type for the INTEL_performance_query backend
interface to bool instead of GLboolean.
Signed-off-by: Robert Bragg
---
src/mesa/drivers/dri/i965/brw_performance_query.c | 4 ++--
src/mesa/main/dd.h
->perfquery.oa_metrics_table hash table
keyed by the GUID of the metric set in XML.
Signed-off-by: Robert Bragg
---
src/mesa/drivers/dri/i965/Makefile.am | 15 +-
src/mesa/drivers/dri/i965/Makefile.sources | 2 +
src/mesa/drivers/dri/i965/brw_oa.py|
This builds on the recent i965/INTEL_performance_query work to add support for
Haswell OA unit performance counters (Gen 8 and 9 support to follow once
corresponding kernel supports lands).
Robert Bragg (8):
main/performance_query: s/GLboolean/bool/
i965: XML description of Haswell OA metric
This allows iterating list nodes from a given start point instead of
necessarily the list head.
Signed-off-by: Robert Bragg
---
src/compiler/glsl/list.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/compiler/glsl/list.h b/src/compiler/glsl/list.h
index 6afb9dcef9..47f53b865b
into account the small chance that some of the 32bit counters
could wrap around for long queries (~50 milliseconds for a GT3 Haswell @
1.1GHz) the implementation also collects periodic metrics.
Signed-off-by: Robert Bragg
---
src/mesa/drivers/dri/i965/brw_context.h | 52 +
src/mesa
sts, while that's not necessary with a dedicated struct with all
members being uint64_t.
- This structure and the code for initializing it is currently shared
(just through copy & paste) with a few other projects dealing with
OA counters, and that's been convenient s
In preparation for generating code from brw_oa_hsw.xml for describing OA
performance counter queries this adds some OA specific members to
brw_perf_query that our generated code will initialize:
- The oa_metric_set_id is the ID we will pass to
DRM_IOCTL_I915_PERF_OPEN, and is an ID got via sysfs
a. There are scripts
under gputop-scripts/ and make rules in gputop-data/Makefile.xml for
maintaining these files.
Signed-off-by: Robert Bragg
---
src/mesa/drivers/dri/i965/brw_oa_hsw.xml | 998 +++
1 file changed, 998 insertions(+)
create mode 100644 src/mesa/drivers/dri
so checking if it is less
>> than zero is useless. On queryid_to_index() is comment
>> saying 0 is reserved to be invalid thus rule it out.
>>
>> CC: Robert Bragg
>> Signed-off-by: Juha-Pekka Heikkila
>> ---
>> src/mesa/main/performance_query.c | 2 +-
>&g
-Pekka Heikkila
Signed-off-by: Robert Bragg
---
src/mesa/main/performance_query.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/performance_query.c
b/src/mesa/main/performance_query.c
index aa103516a5..56f6a7da8b 100644
--- a/src/mesa/main
On Mon, Feb 27, 2017 at 2:47 PM, Juha-Pekka Heikkila
wrote:
> In queryid_valid() fix handling of zero index.
>
> CC: Robert Bragg
> Signed-off-by: Juha-Pekka Heikkila
> ---
> src/mesa/main/performance_query.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
on Skylake
Signed-off-by: Robert Bragg
---
src/intel/common/gen_device_info.c| 21 +---
src/intel/common/gen_device_info.h| 24 ++
src/mesa/drivers/dri/i965/brw_context.c | 15 +
src/mesa/drivers/dri/i965/brw_context.h | 3 ++
src/mesa/driver
fixes piglit arb_timer_query-timestamp-get on Skylake
Signed-off-by: Robert Bragg
---
src/intel/common/gen_device_info.c| 21 +---
src/intel/common/gen_device_info.h| 24 ++
src/mesa/drivers/dri/i965/brw_context.c | 15 +
src/mesa/drivers/dri/i965/brw_con
The heuristic expecting the entrypoint to be named 'main' was causing
false warnings for modules with only a single shader that happen to use
another name. We now count entrypoints before triggering this warning.
Signed-off-by: Robert Bragg
---
src/compiler/spirv/spirv_to_nir.c | 6 +
On Sun, Nov 27, 2016 at 7:23 PM, Ilia Mirkin wrote:
> The strategy is to just keep n anv_query_pool_slot entries per query
> instead of one. The available bit is only valid in the last one.
>
> Signed-off-by: Ilia Mirkin
> ---
>
> I think this is in a pretty good state now. I've tested both the
On Tue, Dec 13, 2016 at 11:08 PM, Rob Clark wrote:
> On Tue, Dec 13, 2016 at 5:47 PM, Eric Anholt wrote:
>> Jason Ekstrand writes:
>>
>>> Hey All,
>>> I don't figure this will be terribly controversial (I'm about to be wrong,
>>> aren't I?) but how do people feel about switching our "primary"
>>
On Wed, Dec 14, 2016 at 7:17 PM, Jani Nikula
wrote:
> On Wed, 14 Dec 2016, Robert Bragg wrote:
>> On Tue, Dec 13, 2016 at 11:08 PM, Rob Clark wrote:
>>> On Tue, Dec 13, 2016 at 5:47 PM, Eric Anholt wrote:
>>>> Jason Ekstrand writes:
>>>>
>&g
Hey Tapani,
I came across this issue the other day too and can at least confirm
that I wrote an almost identical patch.
I was a bit unsure whether this was the best place to fix this issue
since it seems a bit unobvious, in isolation, why we emit these
texture ops with a place holder register, bu
This makes sure to use a no-op swizzle while iteratively rendering each
level of a mipmap otherwise we may loose components and effectively
apply the swizzle twice by the time these levels are sampled.
---
src/mesa/drivers/common/meta_generate_mipmap.c | 12
1 file changed, 12 inserti
On Tue, Jun 10, 2014 at 6:00 PM, Ian Romanick wrote:
> On 06/09/2014 07:48 AM, Robert Bragg wrote:
>> This makes sure to use a no-op swizzle while iteratively rendering each
>> level of a mipmap otherwise we may loose components and effectively
>> apply the swizzle twice by
to the last presented buffer.
[1] http://www.khronos.org/registry/egl/extensions/EXT/
EGL_EXT_swap_buffers_with_damage.txt
Robert Bragg (3):
egl: Update to revision 21254 of eglext.h
egl: Add extension infrastructure for EGL_EXT_swap_buffers_with_damage
egl/wayland: Implement
---
src/egl/main/eglapi.c | 32
src/egl/main/eglapi.h | 7 +++
src/egl/main/egldisplay.h | 1 +
src/egl/main/eglmisc.c| 1 +
4 files changed, 41 insertions(+)
diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c
index bcc5465..30d4ee2 1006
This pulls in EGL_EXT_swap_buffers_with_damage.
---
include/EGL/eglext.h | 45 ++---
1 file changed, 42 insertions(+), 3 deletions(-)
diff --git a/include/EGL/eglext.h b/include/EGL/eglext.h
index b2b5a80..1d68178 100644
--- a/include/EGL/eglext.h
+++ b/inc
---
src/egl/drivers/dri2/platform_wayland.c | 27 ---
1 file changed, 24 insertions(+), 3 deletions(-)
diff --git a/src/egl/drivers/dri2/platform_wayland.c
b/src/egl/drivers/dri2/platform_wayland.c
index e9a66af..8c12dd8 100644
--- a/src/egl/drivers/dri2/platform_wayland.
I've updated this patch to handle the case where 0 rectangles have been given
and updated the eglSwapBuffers shim to rely on that. Thanks to Eric for
noticing this.
-- >8 --
Reviewed-by: Eric Anholt
---
src/egl/drivers/dri2/platform_wayland.c | 29 ++---
1 file changed,
o the spec considering
that if an app were switching between a direct/indirect context the
age state may switch from being client-side to server-side and they
shouldn't have to be kept in sync. glXSwapBuffers has a similar
requirement so it should be possible to borrow some checks f
erformance_query and AMD_performance_monitor extensions are
now completely orthogonal within Mesa (though a driver could optionally
choose to implement both extensions within a unified backend if that
were convenient for the sake of sharing state/code).
Signed-off-by: Robert Bragg
---
src
nt backend changes as we look to
use the Linux perf interface as a means to configure the OA unit, this
patch removes the current backend. This will simplify our ability to
update the frontend infrastructure and backend interface before updating
our support for performance counters.
Signed-off-by: Ro
rdware generations.
I still anticipate some (hopefully relatively minor) tweaking of
implementation details based on review feedback for the i915_oa driver,
but I hope that this is a good point to ask for some feedback on the
Mesa changes.
If it's more convenient, these patches can also be fetche
nd backend interface were reworked.
Signed-off-by: Robert Bragg
---
src/mesa/drivers/dri/i965/Makefile.sources| 1 +
src/mesa/drivers/dri/i965/brw_context.c | 3 +
src/mesa/drivers/dri/i965/brw_context.h | 26 +
src/mesa/drivers/dri/i965/brw_performance_que
these same counters; such as for looking at the OA counters for
system wide analysis. Until we've got a bit more experience dealing with
the counters though it seems best to defer this separation and avoid
having to design a suitable api for these different use cases.
Signed-off-by: Robert
this
separation intentionally copies what few helpers/utilities
that were shared between the two extensions, avoiding any re-factoring
specific to INTEL_performance_query so that that the evolution
will be easier to follow later.
Signed-off-by: Robert Bragg
---
src/mapi/glapi/gen/gl_genex
This uses the i915_oa '3D' metric set to expose many more interesting OA
counters including information about depth, alpha and stencil testing,
sampler usage/bottlneck stats and cache throughputs.
Signed-off-by: Robert Bragg
---
src/mesa/drivers/dri/i965/brw_performance_que
the spec says, btw ?
>
> On 05/06/2015 02:53 AM, Robert Bragg wrote:
>>
>> As we've learned more about the observability capabilities of Gen
>> graphics we've found that it's not enough to only try and configure the
>> OA unit from userspace without
On Wed, May 6, 2015 at 9:36 AM, Samuel Pitoiset
wrote:
>
>
> On 05/06/2015 02:53 AM, Robert Bragg wrote:
>>
>> As we've learned more about the observability capabilities of Gen
>> graphics we've found that it's not enough to only try and configure
On Mon, May 11, 2015 at 4:11 PM, Samuel Pitoiset
wrote:
> Patches 1 and 2 look fine to me.
>
> See my comments below for this one.
>
>
> On 05/06/2015 02:53 AM, Robert Bragg wrote:
>>
>> --- a/src/mesa/main/performance_query.c
>> +++ b/src/mesa/main
On Mon, May 11, 2015 at 4:28 PM, Samuel Pitoiset
wrote:
>
>
> On 05/06/2015 02:53 AM, Robert Bragg wrote:
>>
>> This adds a bare-bones backend for the INTEL_performance_query extension
>> that exposes the pipeline statistics on gen 6 and 7 hardware.
>>
>
init PerfQuery.NumQueries in frontend
- s/return_string/output_clipped_string/
- s/backed/backend/ typo
- remove redundant *bytesWritten = 0
Signed-off-by: Robert Bragg
---
src/mesa/main/dd.h| 39 +++
src/mesa/main/mtypes.h| 25 +-
src/mesa/main/performance_query.c | 59
On Mon, Nov 10, 2014 at 2:57 PM, Neil Roberts wrote:
>
> The bit I mentioned about OACONTROL was just saying that the method of
> detecting whether we can write to OACONTROL specifically doesn't work.
> This is because writing to a register that is not in the whitelist
> returns EINVAL and Mesa ca
Hi Samuel,
I thought I should let you and others know of some related changes
I've been playing around with to try and improve our support for the
INTEL_performance_query extension in the i965 dri driver, since it's
quite related to your work.
Some of my work-in-progress changes can currently be
Hi Samuel,
On Tue, Mar 31, 2015 at 5:56 PM, Samuel Pitoiset
wrote:
> Hello Robert,
>
> Sorry for the delay, I just saw your message few days ago, and I probably
> removed the mail by mistake too...
And then I was on holiday; so more delay :-)
>
> I have never heard about your work on this area,
On Tue, Mar 31, 2015 at 6:56 PM, Alex Deucher wrote:
> On Thu, Mar 19, 2015 at 6:40 PM, Robert Bragg wrote:
>> Hi Samuel,
>>
>> I thought I should let you and others know of some related changes
>> I've been playing around with to try and improve our support fo
On Thu, Dec 22, 2016 at 11:14 AM, Ilia Mirkin wrote:
>>> Ping? Any further comments/feedback/reviews?
>>>
>>>
>>> On Dec 5, 2016 11:22 AM, "Ilia Mirkin" wrote:
>>>
>>> On Mon, Dec 5, 2016 at 11:11 AM, Robert Bragg wrote:
>>>&g
On Tue, Jan 24, 2017 at 2:37 PM, Ilia Mirkin wrote:
> On Tue, Jan 24, 2017 at 5:27 PM, Robert Bragg wrote:
>>>>>>> +/*
>>>>>>> + * GPR0 = GPR0 >> 2;
>>>>>>> + *
>>>>>>> + * Note that the upper 30 bits of
problem
correctly measuring something?
Maybe if based on inspection we can find somewhere to put a comment to
clarify the assumptions above?
Br,
- Robert
Signed-off-by: Lionel Landwerlin
Cc: Robert Bragg
---
src/mesa/drivers/dri/i965/brw_performance_query.c | 51
++-
1 file c
On Tue, Apr 4, 2017 at 10:20 AM, Lionel Landwerlin <
lionel.g.landwer...@intel.com> wrote:
> On 03/04/17 21:04, Robert Bragg wrote:
>
>
>
> On Mar 30, 2017 16:16, "Lionel Landwerlin"
> wrote:
>
> While exercising reading report with moderate load, we mig
way
they will ever be practically readable within the xml files and don't
really see much alternative to using a typesetting library like mathjax to
render the equations e.g. for a UI.
Definitely thanks for doing this experiment though!
Br,
- Robert
>
> Regardless, this series is :
>
On Mon, Feb 27, 2017 at 8:01 PM, Dylan Baker wrote:
> I have some comments below, some of them are a bit of work, some of them
> should
> be pretty easy.
>
> Dylan
>
> Quoting Robert Bragg (2017-02-24 05:58:00)
>> --- /dev/null
>> +++ b/src/mesa/drivers/dri
On Fri, Feb 24, 2017 at 2:50 PM, Emil Velikov wrote:
> Hi Robert,
>
> There's a few minor comments below. Feel free to address here or as
> follow-up, if applicable.
>
> On 24 February 2017 at 13:58, Robert Bragg wrote:
>> Avoiding lots of error prone boilerplate
On Wed, Mar 1, 2017 at 3:57 PM, Robert Bragg wrote:
> On Mon, Feb 27, 2017 at 8:01 PM, Dylan Baker wrote:
>>> +def output_rpn_equation_code(set, counter, equation, counter_vars):
>>> +c("/* RPN equation: " + equation + " */")
>>
On Wed, Mar 1, 2017 at 4:56 PM, Matt Turner wrote:
> On Wed, Mar 1, 2017 at 8:49 AM, Robert Bragg wrote:
>> On Fri, Feb 24, 2017 at 2:50 PM, Emil Velikov
>> wrote:
>>> Hi Robert,
>>>
>>> There's a few minor comments below. Feel free to
ere could be many sets.
The metrics as described in XML get translated into C structures
which are registered in a brw->perfquery.oa_metrics_table hash table
keyed by the GUID of the metric set in XML.
v2: numerous python style improvements (Dylan)
Signed-off-by: Robert Bragg
Reviewed-by:
Since seeing that I had indeed sent out a v2 patch and it was reviewed
by Plamena too (thanks) I've just gone a head and pushed that now
(though with an updated commit message instead of copy pasting the
original message).
Thanks,
- Robert
On Mon, Feb 27, 2017 at 3:43 PM, Robert Bragg
L.
v2: numerous python style improvements (Dylan)
v3: Makefile.am fixups (Emil)
Signed-off-by: Robert Bragg
Reviewed-by: Lionel Landwerlin
Reviewed-by: Dylan Baker
---
src/mesa/drivers/dri/i965/Makefile.am | 17 +-
src/mesa/drivers/dri/i965/Makefile.sources | 4 +
src/mesa/drivers/dr
On Mar 2, 2017 7:32 PM, "Emil Velikov" wrote:
On 2 March 2017 at 18:58, Robert Bragg wrote:
> Adds R/b from Dylan and Makefile fixups from Emil, including fixing race
with
> parallel make builds (thanks). Just holding fast on the use of #pragma
once
> though :-)
>
I think
e.am fixups (Emil)
v4: Pattern rule for codegen + orthogonal .c and .h rules (Robert)
Signed-off-by: Robert Bragg
Reviewed-by: Lionel Landwerlin
Reviewed-by: Dylan Baker
Reviewed-by: Emil Velikov
---
src/mesa/drivers/dri/i965/Makefile.am | 15 +-
src/mesa/drivers/dri/i965/Makefile.sour
Acked-by: Robert Bragg
On Sun, Mar 12, 2017 at 11:01 PM, Mauro Rossi wrote:
> Automake generation rules are replicated for android.
> $* macro was expected to return "hsw" but instead gives "hsw.{h,c}"
> so $(basename $*) is used as a workaround
> to set
On Thu, Mar 16, 2017 at 1:50 PM, Emil Velikov wrote:
> On 16 March 2017 at 02:49, Jonathan Gray wrote:
>> % pattern rules are a GNU extension. As there is only one file here
>> avoid patterns and globbing entirely to fix the build on non-GNU make.
>>
>> Signed-off-by: Jonathan Gray
>> ---
>> s
with strncpy was picked up by Coverity.
CID: 1402201
Signed-off-by: Robert Bragg
---
src/mesa/drivers/dri/i965/brw_performance_query.c | 43 +--
1 file changed, 32 insertions(+), 11 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_performance_query.c
b/src/mesa
Broxton's reference clock for timestamps runs at 19.2MHz and gives us
a period of 52.083 nanoseconds.
Signed-off-by: Robert Bragg
---
src/intel/vulkan/anv_device.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_dev
On Fri, Jan 6, 2017 at 9:28 PM, Kenneth Graunke wrote:
> On Friday, January 6, 2017 1:17:39 PM PST Kenneth Graunke wrote:
>> From: Robert Bragg
>>
>> v2: (Ken) Update timebase_scale for platforms past Skylake/Broxton too.
>
> Hi Robert!
>
> Your patch had merge
iod' this switches anv_GetPhysicalDeviceProperties
to using this common device info to initialize the timestampPeriod
device limit.
Signed-off-by: Robert Bragg
---
src/intel/vulkan/anv_device.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/intel/vulkan/anv_device.c b/src/in
mplicitly enabled for GLX v1.4 but that was changed in commit
d3f7597bc9f6d5
Signed-off-by: Robert Bragg
---
src/glx/dri2_glx.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c
index 10b6f52..1fd8c99 100644
--- a/src/glx/dri2_glx.c
On Feb 8, 2012 8:38 PM, "Chris Wilson" wrote:
>
> On Wed, 8 Feb 2012 19:49:54 +0000, Robert Bragg
wrote:
> > This adds the "GLX_" prefix to the string we pass to
> > __glXEnableDirectExtension() otherwise it doesn't match the name we have
> >
From: Robert Bragg
The EGL_NOK_swap_region2 spec states that the rectangles are specified
with a bottom-left origin within a surface coordinate space also with a
bottom left origin, so this patch ensures the rectangles are flipped
before passing them on to dri2_copy_region.
---
src/egl/drivers
On Tue, Sep 18, 2012 at 5:35 PM, Matt Turner wrote:
> On Tue, Sep 18, 2012 at 8:10 AM, Robert Bragg wrote:
>> From: Robert Bragg
>>
>> The EGL_NOK_swap_region2 spec states that the rectangles are specified
>> with a bottom-left origin within a surface coordinate space
There are a few automake files that reference $(X11_INCLUDES) such as
src/glx/Makefile.am but configure.ac wasn't declaring the variable for
substitution. This would break builds of glx if libxcb, for example, was
installed in its own prefix since AM_CFLAGS wouldn't coincidentally
list the needed i
On Wed, Sep 19, 2012 at 5:26 PM, Matt Turner wrote:
> On Wed, Sep 19, 2012 at 8:12 AM, Robert Bragg wrote:
>> There are a few automake files that reference $(X11_INCLUDES) such as
>> src/glx/Makefile.am but configure.ac wasn't declaring the variable for
>> substitutio
This adds an egl_probe_front_pixel_rgb function that is analogous to
piglit_probe_pixel_rgba except it probes the front buffer instead of
probing the back buffer.
---
tests/egl/egl-util.c | 30 ++
tests/egl/egl-util.h |4
2 files changed, 34 insertions(+), 0
The egl-nok-swap-buffer was mistakenly reading the back buffer to test
the correctness of eglSwapRegionNOK but once the second glClear() to red
has been issued the whole back buffer is red and so the test would
always passed since it only probed points it expected to be red anyway.
This patch now
Ah, I only just realized there is a separate list for piglit tests,
sorry. Hopefully it's ok to review these here this time, but I'll
remember to send piglit patches to the right list in the future.
regards,
- Robert
On Thu, Sep 20, 2012 at 2:21 PM, Robert Bragg wrote:
> The egl-no
On Thu, Sep 20, 2012 at 3:34 PM, Brian Paul wrote:
> On 09/20/2012 07:21 AM, Robert Bragg wrote:
>>
>> This adds an egl_probe_front_pixel_rgb function that is analogous to
>> piglit_probe_pixel_rgba except it probes the front buffer instead of
>> probing the back buffer
This adds an egl_probe_front_pixel_rgb function that is analogous to
piglit_probe_pixel_rgba except it probes the front buffer instead of
probing the back buffer.
---
tests/egl/egl-util.c | 31 +++
tests/egl/egl-util.h |4
2 files changed, 35 insertions(+), 0
The egl-nok-swap-buffer was mistakenly reading the back buffer to test
the correctness of eglSwapRegionNOK but once the second glClear() to red
has been issued the whole back buffer is red and so the test would
always passed since it only probed points it expected to be red anyway.
This patch now
On Thu, Sep 27, 2012 at 6:48 PM, Matt Turner wrote:
> On Thu, Sep 20, 2012 at 8:59 AM, Robert Bragg wrote:
>> This adds an egl_probe_front_pixel_rgb function that is analogous to
>> piglit_probe_pixel_rgba except it probes the front buffer instead of
>> probing the back buf
83 matches
Mail list logo
