On Mar 2, 2017 7:32 PM, "Emil Velikov" <emil.l.veli...@gmail.com> wrote:

On 2 March 2017 at 18:58, Robert Bragg <rob...@sixbynine.org> wrote:
> Adds R/b from Dylan and Makefile fixups from Emil, including fixing race
with
> parallel make builds (thanks). Just holding fast on the use of #pragma
once
> though :-)
>
I think you want the "required=True" for all the fields, but feel free
to do at a later stage.


The header and code args are checked like:

> if args.header:
>        header_file = open(args.header, 'w')
>
> if args.code:
>        c_file = open(args.code, 'w')

and the c() and h() funcs are then be NOOPs when there's no open file to
write to.

I just double checked that's the case and it works as expected to omit
either arg.


As-is
Reviewed-by: Emil Velikov <emil.veli...@collabora.com>


Thanks,
- Robert


-Emil
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to